[This forum] Bug in forum theme

User avatar
Linuxdirk
Member
 
Posts: 497
Joined: Wed Sep 17, 2014 11:21
GitHub: dsohler
In-game: Linuxdirk

[This forum] Bug in forum theme

by Linuxdirk » Mon Dec 15, 2014 06:45

Hey there.

There is a bug in the forums theme. When displaying a thread the div with the ID “wrap” gets cut off by a </div> from somewhere causing all further posts on this page of the thread not being aligned properly because not being in the “wrap” div anymore.

Since there are too many errors when using the W3C validator check with Firefox Inspector (Right click, Q). All posts up to the post from the ignored member are within the “wrap” div. All posts after this post aren’t.

See screenshots (zoomed out for showing the highlighted parts properly).

Image Image

Kind regards,
Dirk
 

User avatar
Krock
Member
 
Posts: 3598
Joined: Thu Oct 03, 2013 07:48
GitHub: SmallJoker

Re: [This forum] Bug in forum theme

by Krock » Mon Dec 15, 2014 17:47

Also my mod indexer finds about 20 syntax/code errors.
Luckily, I do not have any problems with the correct display on Chromium.
Newest Win32 builds - Find a mod - All my mods
ALL YOUR DONATION ARE BELONG TO PARAMAT (Please support him and Minetest)
New DuckDuckGo !bang: !mtmod <keyword here>
 

User avatar
addi
Member
 
Posts: 605
Joined: Thu Sep 20, 2012 03:16

Re: [This forum] Bug in forum theme

by addi » Mon Dec 15, 2014 17:54

I also have no problems with firefox. but im using the phpbb default design instead of that minetest design.
 

User avatar
Linuxdirk
Member
 
Posts: 497
Joined: Wed Sep 17, 2014 11:21
GitHub: dsohler
In-game: Linuxdirk

Re: [This forum] Bug in forum theme

by Linuxdirk » Mon Dec 15, 2014 18:00

Krock wrote:I do not have any problems with the correct display on Chromium.

With Minetest theme and ignored users? When using the default theme it’s all fine. Same with not ignored users, but after the first post of a ignored user the rest of the thread display is broken.
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [This forum] Bug in forum theme

by rubenwardy » Mon Dec 15, 2014 18:13

I'd prefer a dark minetest theme, with the original stone texture as a background (not white washed), but nobody answered my question: https://github.com/minetest/forum.minet ... 1/issues/2
 

User avatar
Linuxdirk
Member
 
Posts: 497
Joined: Wed Sep 17, 2014 11:21
GitHub: dsohler
In-game: Linuxdirk

Re: [This forum] Bug in forum theme

by Linuxdirk » Wed Dec 17, 2014 14:41

rubenwardy wrote:I'd prefer a dark minetest theme, […]

I prefer an actually working theme :D

The default theme is weird. It’s like made for RTL languages and not LTR :)
 

User avatar
Linuxdirk
Member
 
Posts: 497
Joined: Wed Sep 17, 2014 11:21
GitHub: dsohler
In-game: Linuxdirk

Re: [This forum] Bug in forum theme

by Linuxdirk » Sun Jan 04, 2015 05:44

Just wanted to say that it’s still broken. Who’s responsible for the theme so I can contact the person directly?
 

User avatar
sfan5
Member
 
Posts: 3636
Joined: Wed Aug 24, 2011 09:44
GitHub: sfan5
IRC: sfan5

Re: [This forum] Bug in forum theme

by sfan5 » Sun Jan 04, 2015 09:54

Linuxdirk wrote:Just wanted to say that it’s still broken. Who’s responsible for the theme so I can contact the person directly?

IIRC, BlockMen is responsible for the forum theme.
Mods: Mesecons | WorldEdit | Nuke
Minetest builds for Windows (32-bit & 64-bit)
 

celeron55
Member
 
Posts: 430
Joined: Tue Apr 19, 2011 10:10

Re: [This forum] Bug in forum theme

by celeron55 » Sat Jan 10, 2015 16:16

The theme is here: https://github.com/minetest/forum.minet ... _template1

Post your fixes as pull requests.
 

User avatar
Linuxdirk
Member
 
Posts: 497
Joined: Wed Sep 17, 2014 11:21
GitHub: dsohler
In-game: Linuxdirk

Re: [This forum] Bug in forum theme

by Linuxdirk » Sun Jan 11, 2015 21:37

celeron55 wrote:Post your fixes as pull requests.

Since I don’t know how to create phpBB themes I don’t know which files to fix, sorry.
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [This forum] Bug in forum theme

by rubenwardy » Sun Jan 11, 2015 21:58

I'll fix it, or try to, as soon as I work out how to install the theme.
 

4aiman
Member
 
Posts: 1208
Joined: Mon Jul 30, 2012 05:47

Re: [This forum] Bug in forum theme

by 4aiman » Sun Jan 11, 2015 23:17

It's marvelous and spectacular how ppl tend to ignore complaints made by some members and respond with eagerness to the similar ones made by other members.

This "theme" issue was reported by me long ago (somewhat around the 15th of October, 2014).
No one seemed to had encountered that one at the time.
But it was confirmed by other ppl in early December, 2014 and subsequently it was revealed that only FF+MT-theme users were affected so far.

I find that amusing, really.
 

Sokomine
Member
 
Posts: 2980
Joined: Sun Sep 09, 2012 17:31

Re: [This forum] Bug in forum theme

by Sokomine » Thu Jan 22, 2015 04:12

4aiman wrote:I find that amusing, really.

Might be more like a case of "Damn. Another user reported that bug again. We'll eventually have to fix it, or else they'll keep reporting" :-)
A list of my mods can be found here.
 

4aiman
Member
 
Posts: 1208
Joined: Mon Jul 30, 2012 05:47

Re: [This forum] Bug in forum theme

by 4aiman » Thu Jan 22, 2015 05:46

Well, can't say that it'd be a bad case. IF the bug were fixed by now ;)
 


Return to Minetest-Related

Who is online

Users browsing this forum: No registered users and 6 guests

cron