[Mod] Torches [3.0.1] [torches]

[gsmanners]

I was looking through the code for this again and noticed this:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

    local p2 = {x=p.x+d.x, y=p.y+d.y, z=p.z+d.z}
    local nn = minetest.env:get_node(p2).name
    local def2 = minetest.registered_nodes[nn]
    if def2 and not def2.walkable then
        return false
    end

It's pretty cool that you can tell where the torch should attach to, but I was wondering whether you can count on the neighbor node actually residing in the environment during an ABM event. That may be the iffy part I've been running into.

[electricface]

I find a bug, Put a torch in the water, Can not see that the torch

[BlockMen]

Update. Version 1.3 released

Changelog:
- flames are only shown if a player is near a torch (13 blocks)
- stopped random dropping of torches
- old torches are converted now, ceiling placed removed

---

It's pretty cool that you can tell where the torch should attach to, but I was wondering whether you can count on the neighbor node actually residing in the environment during an ABM event. That may be the iffy part I've been running into.

Removed the dropping part from abm, so they shouldnt drop randomly anymore. Thanks for pointing out problems, new bug reports and improvement ideas are always welcome ;)

I find a bug, Put a torch in the water, Can not see that the torch

Do you mean that the flames are not shown correct near water? If so i cant do anything since its a know bug in engine.

But in general I'm not sure whether allowing to place torches in water or not. Some feedback would be nice.

[gsmanners]

Ah, I see. Yes, I think register_on_dignode should work much more reliably than an ABM event. It does raise the question of what is going on with the old design, though.

I was thinking that maybe it's a corner case or possibly something esoteric like a timing issue. Now I'm wondering whether I should be worried about where I happen to find flowing water or lava.

[PilzAdam]

I noticed that the torches always drop when you dig/place a node somewhere next to them (i.e. if nodeupdate() runs).

[4aiman]

/me confirms the bug.

[BlockMen]

I noticed that the torches always drop when you dig/place a node somewhere next to them (i.e. if nodeupdate() runs).

/me confirms the bug.

Thanks for reporting, fixed in 1.3.1

[gsmanners]

Just saw another one:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

11:03:29: ERROR[main]: ServerError: /home/genma/.minetest/mods/minetest/torches/init.lua:228: attempt to index local 'n' (a nil value)
11:03:29: ERROR[main]: stack traceback:
11:03:29: ERROR[main]:     /home/genma/.minetest/mods/minetest/torches/init.lua:228: in function 'callback'
11:03:29: ERROR[main]:     ...ome/genma/src/minetest-0.4.9/bin/../builtin/item.lua:442: in function <...ome/genma/src/minetest-0.4.9/bin/../builtin/item.lua:380>
11:03:29: ERROR[main]:     (tail call): ?

I think the below is what's relevant:

minetest.get_node_or_nil(pos)
^ Returns nil for unloaded area

[BlockMen]

Just saw another one:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

11:03:29: ERROR[main]: ServerError: /home/genma/.minetest/mods/minetest/torches/init.lua:228: attempt to index local 'n' (a nil value)
11:03:29: ERROR[main]: stack traceback:
11:03:29: ERROR[main]:     /home/genma/.minetest/mods/minetest/torches/init.lua:228: in function 'callback'
11:03:29: ERROR[main]:     ...ome/genma/src/minetest-0.4.9/bin/../builtin/item.lua:442: in function <...ome/genma/src/minetest-0.4.9/bin/../builtin/item.lua:380>
11:03:29: ERROR[main]:     (tail call): ?

I think the below is what's relevant:

minetest.get_node_or_nil(pos)
^ Returns nil for unloaded area

Could you check if this issue still occurs with lastest git version?
https://github.com/BlockMen/torches/

[4aiman]

The error won't happen with the current version.
However, you shouldn't return at line #228.
It's possible, that some part of a map is still loaded. Thus you won't check "further" positions if one of your checks would return a nil. Thus some of nodes won't update.

[gsmanners]

Could you check if this issue still occurs with lastest git version?
https://github.com/BlockMen/torches/

I don't think the problem I saw is all that common or altogether easy to reproduce, but your fix there looks very similar to mine:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

        local p = {x=pos.x+ix,y=pos.y+iy,z=pos.z+iz}
        local n = minetest.get_node_or_nil(p)
        if n then
            local fd = minetest.registered_nodes[n.name].update or nil

etc...

[4aiman]

...

Now this is a better solution.

[xaGe]

Thanks for the mod. The latest git version seems to work just fine so far with latest minetest compiled from git.

[JPRuehmann]

have just installed the latest version of torches
got the following error by hitting an unknown block.

12:09:15: ERROR[main]: ServerError: /home/ruehmann/.minetest/mods/torches/init.lua:229: attempt to index field '?' (a nil value)
12:09:15: ERROR[main]: stack traceback:
12:09:15: ERROR[main]: /home/ruehmann/.minetest/mods/torches/init.lua:229: in function 'callback'
12:09:15: ERROR[main]: /usr/share/minetest/builtin/item.lua:455: in function </usr/share/minetest/builtin/item.lua:393>
12:09:15: ERROR[main]: (tail call): ?

Thanks,
JPR

[BlockMen]

Just saw another one:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

11:03:29: ERROR[main]: ServerError: /home/genma/.minetest/mods/minetest/torches/init.lua:228: attempt to index local 'n' (a nil value)
11:03:29: ERROR[main]: stack traceback:
11:03:29: ERROR[main]:     /home/genma/.minetest/mods/minetest/torches/init.lua:228: in function 'callback'
11:03:29: ERROR[main]:     ...ome/genma/src/minetest-0.4.9/bin/../builtin/item.lua:442: in function <...ome/genma/src/minetest-0.4.9/bin/../builtin/item.lua:380>
11:03:29: ERROR[main]:     (tail call): ?

have just installed the latest version of torches
got the following error by hitting an unknown block.

12:09:15: ERROR[main]: ServerError: /home/ruehmann/.minetest/mods/torches/init.lua:229: attempt to index field '?' (a nil value)
12:09:15: ERROR[main]: stack traceback:
12:09:15: ERROR[main]: /home/ruehmann/.minetest/mods/torches/init.lua:229: in function 'callback'
12:09:15: ERROR[main]: /usr/share/minetest/builtin/item.lua:455: in function </usr/share/minetest/builtin/item.lua:393>
12:09:15: ERROR[main]: (tail call): ?

Thanks,
JPR

Both fixed in 1.3.2

[Minetestforfun]

Please, look at my screenshots, this is normal ?
I haven't the same texture like you in your first post...
I really prefer your textures ! :)

http://imgur.com/nZIOjVQ
http://imgur.com/AzqKbi5

[BlockMen]

Please, look at my screenshots, this is normal ?
I haven't the same texture like you in your first post...
I really prefer your textures ! :)

http://imgur.com/nZIOjVQ
http://imgur.com/AzqKbi5

Do you mean that everything looks blurred? If so, turn off the anisotropic filter, bilinear filter and trilinear filter

[Minetestforfun]

Indeed, my bad... Sorry...

[Rochambeau]

I think i found a bug: when i right click a door while holding a torch, the torch is placed at the door.

It doesn't happen with default torches or carbones torches for example.

[stormchaser3000]

how about uinsg the mesh drawtype

[philipbenr]

@Stormchaser3000: There is no support for animation, I don't think.

[Nathan.S]

@Stormchaser3000: There is no support for animation, I don't think.

Not animation of the mesh, but if you use an animated texture you can have flames, or you could try using actual particles, but I have no idea how those work.

[BlockMen]

Update. Version 2.0 released

Changelog:
- Use new mesh drawtype to improve wallmounted torches
- Update particle-usage/API
- New textures; flame texture fix by Yepoleb
- Fix for doors, chests, etc (rightclick support)

[BlockMen]

Update. Version 2.1 released

Changelog:
- Fix wallmounted torch mesh
- Cleanup code, use wallmounted paramtype2
- Fix torches being placeable on ceilings (reported by kilbith)

[guideahon]

Great mod as always, are you planning on making it non able to be put on water? if that would be the case, this mod should be ported to default minetest game because i would consider this mod perfect

[Minetestforfun]

Great mod as always, are you planning on making it non able to be put on water? if that would be the case, this mod should be ported to default minetest game because i would consider this mod perfect

I agree, this mod seems to be almost perfect (beautiful meshe, bugfixs for doors now, great wallmounted, great particles), the last thing i can blame was the "put on water", but many other torches mods have the same blame...

[BlockMen]

Great mod as always, are you planning on making it non able to be put on water? if that would be the case, this mod should be ported to default minetest game because i would consider this mod perfect

I agree, this mod seems to be almost perfect (beautiful meshe, bugfixs for doors now, great wallmounted, great particles), the last thing i can blame was the "put on water", but many over torches mods have the same blame...

Nice you guys like my mod, but this mod won't be added the way it currently is. The reason is the usage of the particles, which generates a lot of server traffic.

[guideahon]

But what if you make another version without particles and non-able to be put on water (i honestly, really want the second thing)

[Napiophelios]

But what if you make another version without particles and non-able to be put on water (i honestly, really want the second thing)

I cant remember what game I got this from, but it works pretty good;
I use it for torches, fire ,and candles in my custom game.
Its not a perfect solution, but its not a bad one either.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

minetest.register_abm({nodenames = {"default:torch"},
   interval = 1.0,
   chance = 1,
   action = function(pos, node)
   local p = {x=pos.x, y=pos.y, z=pos.z-1}
local    n = minetest.get_node(p)

local    p1 = {x=pos.x+1, y=pos.y, z=pos.z}
local    n1 = minetest.get_node(p1)

local    p2 = {x=pos.x-1, y=pos.y, z=pos.z}
local    n2 = minetest.get_node(p2)

local    p3 = {x=pos.x, y=pos.y-1, z=pos.z}
local    n3 = minetest.get_node(p3)

local    p4 = {x=pos.x, y=pos.y, z=pos.z+1}
local    n4 = minetest.get_node(p4)

local    p5 = {x=pos.x, y=pos.y, z=pos.z}
local    n5 = minetest.get_node(p5)

      if (n.name == "default:water_source") then
         minetest.add_node(p5, {name="default:water_flowing"})
         minetest.add_item(p5,{name=n5})
      return end

            if (n.name == "default:water_flowing") then
               minetest.add_node(p5, {name="default:water_flowing"})
               minetest.add_item(p5,{name=n5})
   return end

   if (n1.name == "default:water_source") then
      minetest.add_node(p5, {name="default:water_flowing"})
      minetest.add_item(p5,{name=n5})
   return end

      if (n.name == "default:water_flowing") then
               minetest.add_node(p5, {name="default:water_flowing"})
               minetest.add_item(p5,{name=n5})
   return end

   if (n2.name == "default:water_source") then
      minetest.add_node(p5, {name="default:water_flowing"})
      minetest.add_item(p5,{name=n5})

   return end
      if (n.name == "default:water_flowing") then
               minetest.add_node(p5, {name="default:water_flowing"})
               minetest.add_item(p5,{name=n5})
   return end

   if (n3.name == "default:water_source") then
      minetest.add_node(p5, {name="default:water_flowing"})
      minetest.add_item(p5,{name=n5})
   return end

      if (n.name == "default:water_flowing") then
               minetest.add_node(p5, {name="default:water_flowing"})
               minetest.add_item(p5,{name=n5})
   return end

   if (n4.name == "default:water_source") then
      minetest.add_node(p5, {name="default:water_flowing"})
      minetest.add_item(p5,{name=n5})
   return end

      if (n.name == "default:water_flowing") then
               minetest.add_node(p5, {name="default:water_flowing"})
               minetest.add_item(p5,{name=n5})
   return end
   end,
})

[TenPlus1]

Was thinking of using this in Ethereal, hope it helps (any water beside or above torch drops torch):

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

minetest.register_abm({
   nodenames = {"default:torch"},
   neighbors = {"default:water_source", "default:water_flowing"},
   interval = 1, chance = 1,

   action = function(pos, node)
      local pos0 = {x=pos.x-1,y=pos.y,z=pos.z-1}
      local pos1 = {x=pos.x+1,y=pos.y+1,z=pos.z+1}
      if #minetest.find_nodes_in_area(pos0, pos1,
         {"default:water_source", "default:water_flowing"}) > 0 then
         minetest.set_node(pos, {name="default:water_flowing"})
         minetest.add_item(pos, {name="default:torch"})
      end
   end,
})