[Mod] Minecraft like item drop/pick up [item_drop]

[PilzAdam]

why limit stacks to 64? That's too Minecraft-like and slow.

Its because its a mod from my game MiniTest wich copies Minecraft like features. I will change it in this mod.

[kozec]

Hi! My server sometimes crashes with this message:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

13:31:34: ERROR[main]: ServerError: LuaError: error: .../.minetest/mods/minetest/item_drop/init.lua:92: attempt to index a nil value

I added check for item and item:get_luaentity() nil values, but I'm not sure if it's not part of some bigger bug, so it may be good idea to report it.

[cornernote]

had a bug at line 34 where item was nil... line 34 is:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

local item = minetest.env:add_item(pos, oldnode)

added this below it

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

if item ~= nil then
... do the stuff you had
end

[cornernote]

I had another bug where anzahl was not a number. It was caused when digging moreores tin. The problem is the node name that drops looks like this:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

craft "mod:item" 1

Here is the fix:
find:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

if string.find(oldnode.name, " ") ~= nil then

below, insert:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

oldnode.name = oldnode.name:gsub('"',""):gsub("craft ",""):gsub("item ",""):gsub("node ","")

EDIT, changed the code

[cHyper]

where is the next update please ....... ;)

[leo_rockway]

I saw in the minitest thread that you were asking for a better sound for this. How about this one? http://opengameart.org/content/cork

[PilzAdam]

I saw in the minitest thread that you were asking for a better sound for this. How about this one? http://opengameart.org/content/cork

License? WTFPL would be best.

[leo_rockway]

I saw in the minitest thread that you were asking for a better sound for this. How about this one? http://opengameart.org/content/cork

License? WTFPL would be best.

CC-BY 3.0. I didn't upload it, I was just looking for existing sounds on OGA.
I have modified the pitch with Audacity and created a few of these. So when I pick up items it goes POP pop PoP poP! o.o

[Melkor]

I've been testing this mod and looks great, but I would like to comment on a few things:
1. Some items such as coal exceed the maximum limit of 64 to 99.
2. how nodes are attracted by the played makes this too easy, it's like wearing a magnet, gravity is the one who has to win! The player should have to walk over the item to pick up it.
3. if you put a node over an dropped item, it stays there, inside of the node, what should happen is that the item must look for the nearest air node to pop up.
(damn you google translator!)

[cornernote]

I've been testing this mod and looks great, but I would like to comment on a few things:
3. if you put a node over an dropped item, it stays there, inside of the node, what should happen is that the item must look for the nearest air node to pop up.
(damn you google translator!)

I think lava should destroy it. Perhaps placing any block will destroy it? What does MC do?

[leo_rockway]

I've been testing this mod and looks great, but I would like to comment on a few things:
3. if you put a node over an dropped item, it stays there, inside of the node, what should happen is that the item must look for the nearest air node to pop up.
(damn you google translator!)

I think lava should destroy it. Perhaps placing any block will destroy it? What does MC do?

MC moves them to the nearest air node, like Melkor said.

[Melkor]

well, that could be the 4th point: Lava should destroy everything what falls on it

[PilzAdam]

I made a complete rewrite of the code. See GitHub: https://github.com/PilzAdam/item_drop

[cornernote]

anything functionally different? or just a different way of writing the code?

[PilzAdam]

anything functionally different? or just a different way of writing the code?

The functionallity is the same but some (nearly all) bugs are fixed e.g. my farming mod now drops everything correctly.

[Josh]

This should be added in by default. Or are you guys happy with the goes straight into your inventory thing?

[Echo]

In 0.4.3 there's a new function:
minetest.handle_node_drops(pos, drops, digger)

It could be used to optimize your mod.
I think celeron added this because of the popularity of your mod :-)

[PilzAdam]

In 0.4.3 there's a new function:
minetest.handle_node_drops(pos, drops, digger)

It could be used to optimize your mod.
I think celeron added this because of the popularity of your mod :-)

c55 added this because we were talking about improvement of my code. It is already in latest GitHub.

[Echo]

PilzAdam

[PilzAdam]

PilzAdam

:-D

[PilzAdam]

New sounds added.

[RAPHAEL]

So how does one remove this mod? I tried deleting mod folder and restarting server (many times since removal of folder) and item drop still happens.

[Vincentius_Maximus]

Did you make the sounds from scratch?

[PilzAdam]

Did you make the sounds from scratch?

No, they are from the blockplanet alias Minetest++ fork.

[restcoser]

I changed the mod for me to have a gain of 0.4, seems much better, could it be modified in the original as well?

[PilzAdam]

I changed the mod for me to have a gain of 0.4, seems much better, could it be modified in the original as well?

Done: https://github.com/PilzAdam/item_drop/commit/d59ec6005808cf1d35c14f428fb5d0e8c999e255

[Mito551]

excuse me, what part of code does the dig-drop part and what part does the pickup part?

[PilzAdam]

excuse me, what part of code does the dig-drop part and what part does the pickup part?

The globalstep function handles the pickup and the handle_node_drops() function does the drop.

[Mito551]

excuse me, what part of code does the dig-drop part and what part does the pickup part?

The globalstep function handles the pickup and the handle_node_drops() function does the drop.

thank you! so that means if i comment out the handle_node_drops() function, i will be picking up stuff which is on the floor already, but getting it directly in my inventory if i dig a node?

[PilzAdam]

excuse me, what part of code does the dig-drop part and what part does the pickup part?

The globalstep function handles the pickup and the handle_node_drops() function does the drop.

thank you! so that means if i comment out the handle_node_drops() function, i will be picking up stuff which is on the floor already, but getting it directly in my inventory if i dig a node?

Yes.