[Mod] Snow Biomes [3.2] [snow]

[Splizard]

@Paramat
Great to hear that bug has been fixed, I have given you access to the snow mod github repo,
you can push those changes if you like :-)

[paramat]

Okay i will once i learn how to, i guess 'git clone' your repo then push ...

[Splizard]

yup :)

[paramat]

Latest commit is my edit of 'mapgen_v6.lua':
Use of noise maps makes this much faster, < 300ms per chunk on a mid power PC.
Ice spawns in sand instead of under sand.
Bugfixes.

[paramat]

Another commit: called this version 3.1 (or 0.3.1)

Splizard, i would like to make a pull request for more snow biome nodes to be added to default:
needles, pine sapling (your textures)
pine tree trunk, pine wood (from watershed/riverdev)
(plus all the crafting, stairs, slabs, fuel)

What do you think? is it ok to include your textures in this pull?
We need default pine trees for the snow biomes in mapgen v7.

[jp]

Paramat / Splizard : instead of generate a thin layer of snow on top of the leaves, could you replace them by some snow-texturized leaves, please ?

Also, seeing these layers of snow on the sand is odd...

Addenda: bug spotted.

[paramat]

That lighting bug is probably due to the use of translucent ice, translucency is inherently buggy in Minetest, previous versions of snow mod had a normal opaque texture.

EDIT
On that subject, does anyone have a better or edited ice texture that doesn't have a gridlike appearence that i could add to this pull?

[Sokomine]

Paramat / Splizard : instead of generate a thin layer of snow on top of the leaves, could you replace them by some snow-texturized leaves, please ?

*complain* That will make life more difficult for snow and moresnow! More cases to be handled.

[paramat]

jp, Sokomine, i'll leave that to Splizard to decide, but such changes are probably unlikely as that would break people's maps. I'm not interested in changing snow mod itself because i would change so much it would make more sense to start a new snow mod (no plans for that either).

[Splizard]

@Paramat, yes it would be fine to create that pull request.
I would prefer to keep snow above the leaves. As paramat said, it would be best if someone made a different mod.

[Minetestforfun]

Hi, i found a bug :

http://pastebin.ubuntu.com/8690791/

Please, can you help me ? i don't know were is the problem :/

[Splizard]

Fixed in latest version (3.1)
http://splizard.com/minetest/mods/snow- ... ow-3.1.zip

[Minetestforfun]

Thank you very much :)

[Splizard]

New version to make compatible with latest minetest.
http://splizard.com/minetest/mods/snow- ... ow-3.2.zip

[Sokomine]

Thanks! The snow mod is a very nice mod to have.

[Hybrid Dog]

snowing in the desert…

[Splizard]

Does it make a difference where you are in the desert?
Snow should only fall in a biome specified area.. which can still be in a desert but it shouldn't be the whole desert..

[Hybrid Dog]

Does it make a difference where you are in the desert?
Snow should only fall in a biome specified area.. which can still be in a desert but it shouldn't be the whole desert..

Yes, it's just a part of the desert. But l think that snow falling in a desert next to a cactus and a palm tree is a bit strange.

[Echoes91]

Since pines are now in default, I think you could replace all

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

snow:pinetree, snow:needles, snow:sapling_pine

with

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

default:pinetree, default:pine_needles, default:pine_sapling

[Diamond knight]

do you know any seeds that will generate a snow biome at your spawn

[Minetestforfun]

@Diamond knight
You can also simply set a spawn in snow biome :)

@Splizard
I've also snow falling in desert in my server (mapgenv6, very similar to Carbone default)

[Don]

It wasn't too long ago that Afghanistan had a major snow storm. Snow falls in the desert sometimes

[Hybrid Dog]

Shall l disable snowflakes in desert or make it rare?

[mahmutelmas06]

Shall l disable snowflakes in desert or make it rare?

In my opinion its better to disable in desert.

[Hybrid Dog]

l didn't test it.
https://github.com/Splizard/minetest-mo ... a411be?w=1

[Ivà]

I've got crashes like:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

terminate called after throwing an instance of 'ServerError'
  what():  .../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:99: attempt to perform arithmetic on local 'x' (a nil value)
stack traceback:
   .../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:99: in function 'get_snow'
   .../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:191: in function <.../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:183>
   /usr/share/minetest/builtin/game/register.lua:341: in function </usr/share/minetest/builtin/game/register.lua:329>


Changing the get_snow function code as below solves the crash:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

--Get snow at position.
local get_snow = function(pos)
        --Legacy support.
        if weather_legacy == "snow" then
                local perlin1 = minetest.get_perlin(112,3, 0.5, 150)
                local x = pos.x
                local y = pos.z
                if perlin1:get2d({x, y}) <= 0.53 then
                        return false
                end

                -- disable falling snow in desert
                local desert_perlin = minetest.get_perlin(SEEDDIFF3, OCTAVES3, PERSISTENCE3, SCALE3)
                local noise3 = desert_perlin:get2d({x=x+150,y=y+50}) -- Offsets must match minetest mapgen desert perlin.
                if noise3 > 0.35 then -- Smooth transition 0.35 to 0.45.
                        return false
                end
                return true
        end
        return false
end


[Hybrid Dog]

I've got crashes like:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

terminate called after throwing an instance of 'ServerError'
  what():  .../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:99: attempt to perform arithmetic on local 'x' (a nil value)
stack traceback:
   .../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:99: in function 'get_snow'
   .../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:191: in function <.../.minetest/games/hogwarts/mods/snow/src/falling_snow.lua:183>
   /usr/share/minetest/builtin/game/register.lua:341: in function </usr/share/minetest/builtin/game/register.lua:329>


Changing the get_snow function code as below solves the crash:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

--Get snow at position.
local get_snow = function(pos)
        --Legacy support.
        if weather_legacy == "snow" then
                local perlin1 = minetest.get_perlin(112,3, 0.5, 150)
                local x = pos.x
                local y = pos.z
                if perlin1:get2d({x, y}) <= 0.53 then
                        return false
                end

                -- disable falling snow in desert
                local desert_perlin = minetest.get_perlin(SEEDDIFF3, OCTAVES3, PERSISTENCE3, SCALE3)
                local noise3 = desert_perlin:get2d({x=x+150,y=y+50}) -- Offsets must match minetest mapgen desert perlin.
                if noise3 > 0.35 then -- Smooth transition 0.35 to 0.45.
                        return false
                end
                return true
        end
        return false
end


thanks, now its not longer untested and should work
https://github.com/Splizard/minetest-mo ... 65c046f500

[Ivà]

Ehmm... but... I didn't dig into the code so I'm not sure that x and y got the intended values here, for example in noise3 assignment there was a 'z' laying around... :-)

[Hybrid Dog]

Ehmm... but... I didn't dig into the code so I'm not sure that x and y got the intended values here, for example in noise3 assignment there was a 'z' laying around... :-)

l forgot to change "x, z", what l copied from the meru mod.

[paramat]

There's a new bug that was posted as an engine issue on Github https://github.com/minetest/minetest/issues/2672
The latest commit by melzua is wrong, 'get2D()' doesn't have the form '{x = ..., y = ...}':

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

if perlin1:get2d({x, y}) <= 0.53 then

2D noise always uses abstract variables x and y, these then represent world position x and z.

You left x and z undefined when calculating noise3:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

local noise3 = desert_perlin:get2d({x=x+150,y=z+50}) -- Offsets must match minetest mapgen desert perlin.

The correct code is:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

--Get snow at position.
local get_snow = function(pos)
   --Legacy support.
   if weather_legacy == "snow" then
      local perlin1 = minetest.get_perlin(112,3, 0.5, 150)
      if perlin1:get2d({x=pos.x, y=pos.z}) <= 0.53 then
         return false
      end

      -- disable falling snow in desert
      local desert_perlin = minetest.get_perlin(SEEDDIFF3, OCTAVES3, PERSISTENCE3, SCALE3)
      local noise3 = desert_perlin:get2d({x=pos.x+150,y=pos.z+50}) -- Offsets must match minetest mapgen desert perlin.
      if noise3 > 0.35 then -- Smooth transition 0.35 to 0.45.
         return false
      end
      return true
   end
   return false
end