[Mod] Snow Biomes [3.2] [snow]

[Hybrid Dog]

There's a new bug that was posted as an engine issue on Github https://github.com/minetest/minetest/issues/2672
The latest commit by melzua is wrong, 'get2D()' doesn't have the form '{x = ..., y = ...}':

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

if perlin1:get2d({x, y}) <= 0.53 then

2D noise always uses abstract variables x and y, these then represent world position x and z.

it should be fixed now
Ivà wrote "Changing the get_snow function code as below solves the crash", so l didn't look for such a mistake.

You left x and z undefined when calculating noise3

l changed z to y when l did this commit https://github.com/Splizard/minetest-mo ... 65c046f500
and x and y are defined

Edit:l just tested falling snow and it worked for me.

[paramat]

That will work, but is messy and has unnecessary code, faster to use pos.x and pos.z directly as in my post.

Splizard, please can you remove my push access to this repo? I don't have time to be involved as a mod dev anymore.

Optional snow biomes are now added to 0.4.12dev mgv6 C++ mapgen, add "mgv6_spflags = snowbiomes" to your minetest.conf file.

[Ivà]

Apologise for the mistake, was late at night for me and did a quick fix to solve the crash but I didn't dig more into the code.

So sorry.

[paramat]

Hey no problem =)

The abstract internal variables x, y used by 2D perlin noise are often confused with world co-ordinates so it's best they only ever appear inside get2d() as [x = ..., y = ...}.

[Hybrid Dog]

That will work, but is messy and has unnecessary code, faster to use pos.x and pos.z directly as in my post.

ok, l edited it.

[Splizard]

@Paramat I have removed your push access as you requested.
@Hybrid Dog nice to see you have been working on snow mod :)
let me know if you want me to release a new version!

[Hybrid Dog]

ok

[Minetestforfun]

The Sled doesn't work for me, can you check it please ? :)
(i would create a event with it :p)

[Splizard]

@Minetestforfun
Sleds should be fixed in the latest development version :)

[Minetestforfun]

@Splizard
Thank you very much for this fix :)

[Hybrid Dog]

automatic snowball throwing:

[DS-minetest]

automatic snowball throwing:

you need a snowball cannon

[Hybrid Dog]

you need a snowball cannon

yes, and l need textures, sounds and a nodebox or mesh for it…




the generated snow does not have the same height everywhere but these heights:

+ "a bit outdated"

[DS-minetest]

you need a snowball cannon

yes, and l need textures, sounds and a nodebox or mesh for it…

pls do not use mesh, if it is not needed, nodebox is cooler

[Hybrid Dog]

you need a snowball cannon

yes, and l need textures, sounds and a nodebox or mesh for it…

pls do not use mesh, if it is not needed, nodebox is cooler

ok

[Diamond knight]

moresnow has a snowball cannon already coded if you want to download the mod

[Hybrid Dog]

moresnow has a snowball cannon already coded if you want to download the mod

l first need to test it, thanks for informing me

[Hybrid Dog]

l added a few normalmap textures

[SaKeL]

im getting this error, is it something what you are aware of ?

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

2016-02-12 23:28:37: ERROR[main]: UNRECOVERABLE error occurred. Stopping server. Please fix the following error:
2016-02-12 23:28:37: ERROR[main]: Lua: OOM error from mod 'snow' in callback environment_OnGenerated(): not enough memory
2016-02-12 23:28:37: ERROR[main]: Current Lua memory usage: 867 MB

In thread 7f94719a67c0:
/build/minetest-5EsLJt/minetest-0.4.13/src/server.cpp:511: void Server::step(float): A fatal error occurred: Lua: OOM error from mod 'snow' in callback environment_OnGenerated(): not enough memory
Current Lua memory usage: 867 MB
Debug stacks:
DEBUG STACK FOR THREAD 7f94575fe700:
#0  virtual void* EmergeThread::Thread()
(Leftover data: #1  virtual MapBlock* ServerMap::emergeBlock(v3s16, bool): p=(13,433,8), create_blank=0)
(Leftover data: #2  ServerMapSector* ServerMap::createSector(v2s16): p2d=(13,8))
(Leftover data: #3  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD 7f9457fff700:
#0  virtual void* CurlFetchThread::Thread()
DEBUG STACK FOR THREAD 7f946657d700:
#0  virtual void* ServerThread::Thread()
#1  void Server::Receive()
(Leftover data: #2  void Server::SendBlocks(float))
(Leftover data: #3  void Server::SendBlockNoLock(irr::u16, MapBlock*, irr::u8, irr::u16))
(Leftover data: #4  void ItemStack::serialize(std::ostream&) const)
(Leftover data: #5  bool getCraftingResult(Inventory*, ItemStack&, std::vector<ItemStack>&, bool, IGameDef*))
(Leftover data: #6  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
(Leftover data: #7  void ItemStack::deSerialize(std::istream&, IItemDefManager*))
DEBUG STACK FOR THREAD 7f94719a67c0:
#0  int main(int, char**)
#1  Dedicated server branch
#2  void dedicated_server_loop(Server&, bool&)
#3  void Server::step(float)
(Leftover data: #4  void Server::SendAccessDenied_Legacy(irr::u16, const wstring&))



maybe something related to this ?

[Hybrid Dog]

It looks like snow takes too much memory when generating.
When exactly did you get this error and which mapgen version were you using?

[SaKeL]

mapgen v6
it happens randomly i.e. when flying around but it also happened when the player walked trough the snow biomes/forest

[Hybrid Dog]

l made it execute the collectgarbage function, does if fix the crashes?

[SaKeL]

i will pull the changes and give it a test.... will let you know

[SaKeL]

it's working for now...no crashes ...if it appears again i will let you know ;) thanks

[PureTryOut]

Just a note, the images on the frontpage are down. Please use an image host like Imgur, or some other reliable host.

[Andrey01]

The mod don`t work, i was getting error when installed game:
"Failed to load and run script from /home/administrator/.minetest/mods/snow/init.lua:
/home/administrator/.minetest/mods/snow/src/mapgen.lua:61: attempt to call field 'get_mapgen_setting' (a nil value) stack traceback:
/home/administrator/.minetest/mods/snow/src/mapgen.lua:61: in main chunk [C]: in function 'dofile'
/home/administrator/.minetest/mods/snow/init.lua:69: in main chunk"
Maybe did i rename the mod incorrect?

[Hybrid Dog]

l guess you need a new version of minetest.
https://github.com/Splizard/minetest-mo ... 318aaf08ff

[Andrey01]

l guess you need a new version of minetest.
https://github.com/Splizard/minetest-mo ... 318aaf08ff

A new version?New version of minetest hasn`t come yet, last version was 0.4.14

[Krock]

A new version?New version of minetest hasn`t come yet, last version was 0.4.14

Versions between each release are so-called in-development versions and contain newer features, bugfixes but also new bugs.
There are precompiled (PPA) versions for Ubuntu/Mint and Arch Linux here. For a different distribution, you will need to compile it on your machine.

[Andrey01]

A new version?New version of minetest hasn`t come yet, last version was 0.4.14

Versions between each release are so-called in-development versions and contain newer features, bugfixes but also new bugs.
There are precompiled (PPA) versions for Ubuntu/Mint and Arch Linux here. For a different distribution, you will need to compile it on your machine.

I have deleted line:61 in the mapgen.lua and it is worked, finally