[Mod] Mobs Redo [1.34] [mobs]

[turtleman]

I think this mod is causing crashes in 0.4.13. I'm seeing it cause the error mentioned in viewtopic.php?f=6&t=13177 in a server I'm running at home. One client saw a mobs:mese_monster fly out of the ocean and up into the sky right when this crash happened, and it kept happening and crashing the server when I restarted it. I think I've fixed it by disabling the mod and running the server for a while without it. A client saw an "unknown" flying up into the sky, but it didn't crash this time. I've enabled the mod again, and so far, all is well.

I am also getting a crash. Here is the output:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all


2015-09-27 11:44:06: ERROR[Main]: UNRECOVERABLE error occurred. Stopping server. Please fix the following error:
2015-09-27 11:44:06: ERROR[Main]: Lua: Runtime error from mod 'mobs' in callback luaentity_Step(): /home/jason/.minetest/mods/mobs/api.lua:775: attempt to index field 'player' (a nil value)
2015-09-27 11:44:06: ERROR[Main]: stack traceback:
2015-09-27 11:44:06: ERROR[Main]:    /home/jason/.minetest/mods/mobs/api.lua:775: in function </home/jason/.minetest/mods/mobs/api.lua:189>

In thread b62dc740:
/build/minetest-h46uoF/minetest-201509261916/src/server.cpp:505: void Server::step(float): A fatal error occurred: Lua: Runtime error from mod 'mobs' in callback luaentity_Step(): /home/jason/.minetest/mods/mobs/api.lua:775: attempt to index field 'player' (a nil value)
stack traceback:
   /home/jason/.minetest/mods/mobs/api.lua:775: in function </home/jason/.minetest/mods/mobs/api.lua:189>
Debug stacks:
DEBUG STACK FOR THREAD b2fffb40:
#0  virtual void* EmergeThread::run()
#1  MapBlock* ServerMap::loadBlock(v3s16)
#2  MapSector* ServerMap::loadSectorMeta(std::string, bool)
DEBUG STACK FOR THREAD b3999b40:
#0  virtual void* ServerThread::run()
#1  void Server::Receive()
(Leftover data: #2  virtual void Server::deletingPeer(con::Peer*, bool))
(Leftover data: #3  void RemoteClient::GetNextBlocks(ServerEnvironment*, EmergeManager*, float, std::vector<PrioritySortedBlockTransfer>&))
(Leftover data: #4  void Server::SendHP(irr::u16, irr::u8))
(Leftover data: #5  bool getCraftingResult(Inventory*, ItemStack&, std::vector<ItemStack>&, bool, IGameDef*))
DEBUG STACK FOR THREAD b62dc740:
#0  int main(int, char**)
#1  Dedicated server branch
#2  void dedicated_server_loop(Server&, bool&)
#3  void Server::step(float)
(Leftover data: #4  void Server::SendAccessDenied_Legacy(irr::u16, const wstring&))
Aborted



This looks like the same issue:
https://github.com/tenplus1/mobs/issues/35

Except I am getting it with the latest version.

[heavy gale]

What's up with those flying sheep?

They've got 1 hp and don't move.

And it looks like items dropped by cows are placed one block too deep.

[TenPlus1]

Those are the old sheep entities which were replaced with the newer coloured sheep one's, they shouldnt move and when right-clicked will give 1 sheep spawn egg.

Update: Old sheep entities now fall down isntead of flying around, also Pumba's (hogs) now spawn in dry grass biomes and mob drops fall higher.

[Glünggi]

an example for height dependent Mobs HP

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

local highfa = {}
if self.health == 0 then
         -- HP
         -- note: attention: real hp.max = hp.min + hp.max * highfactor
         local highdefi = self.object:getpos().y
         if highdefi >= 0 then highfa = 0.1
         elseif highdefi <= -1 and highdefi >= -99 then highfa = 0.2
         elseif highdefi <= -100 and highdefi >= -249 then highfa = 0.3
         elseif highdefi <= -250 and highdefi >= -499 then highfa = 0.4
         elseif highdefi <= -500 and highdefi >= -749 then highfa = 0.5
         elseif highdefi <= -750 and highdefi >= -999 then highfa = 0.6
         elseif highdefi <= -1000 and highdefi >= -1249 then highfa = 0.7
         elseif highdefi <= -1250 and highdefi >= -1499 then highfa = 0.8
         elseif highdefi <= -1500 and highdefi >= -1749 then highfa = 0.9
         elseif highdefi <= -1750 then highfa = 1.0
         end
         self.health = self.hp_min + math.floor( self.hp_max * highfa )
      end
self.object:set_hp( self.health )

[duane]

an example for height dependent Mobs HP

Or you could just say "highfa = math.sqrt(highdefi / -1750)" and call it close enough. : )

[Glünggi]

Or you could just say "highfa = math.sqrt(highdefi / -1750)" and call it close enough

Thats the difference between knowlengh and a "math noob" :D

edit: knowlengh and knowledge its the difference between english and noenglish

[Soudon]

when i go to eat a porkchop I get a mod "mobs" callback item on use error I can eat apples but porkchops nope. I've messed around with names and what the boar drops but still nothing.

[TenPlus1]

Soudon, it's not the mobs redo mod that's at fault, eating a chop raw or cooked works fine and with hudbars, the fault itself is with the hud/hunger mod you are using.

[Soudon]

Soudon, it's not the mobs redo mod that's at fault, eating a chop raw or cooked works fine and with hudbars, the fault itself is with the hud/hunger mod you are using.

Yea I figured that out I realized I didn't have hunger installed.

[TenPlus1]

Mob api has been re-written to be more modular and optimized where possible, also a new feature added to override each mobs spawn chance within the minetest.conf file, like so:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

mobs:cow 10000
mobs:sheep 8000
mobs:sand_monster 100

... the lower the value, the more each mob will spawn. Thanks to LordFingle for the idea :)

[duane]

Is there supposed to be any way to access the set_velocity and set_animation(2) functions from do_custom anymore? They're very useful for digging functions, or anything where you need to override normal movement.

[TenPlus1]

I've made the functions within the mobs api global once again so they can be called from within do_custom, on_death etc. also set_animation2 is not set_animation. updated on github.

[duane]

I've made the functions within the mobs api global once again so they can be called from within do_custom, on_death etc. also set_animation2 is not set_animation. updated on github.

Thanks. It might be safer to make them methods of mobs or the mob objects, but that's a nit-picky detail.

[TenPlus1]

duane: some of the functions were included in the mob function itself but was eventually separated to make code easier to maintain and read.

[Soudon]

I want to have hostile mobs come at night a passive during the day, I have edited the light min and max but doesn't seem to work, also I have yet to see a cow spawn I even set the chance to 1 both in the minetest.conf right inside the minetest folder, also minetest.conf inside the game folder and with in the cow.lua still no cows. I just can't seem to figure out how to properly set it that hostiles come at night a passive during the day.

Sorry for rambling on on just I haven't been able to figure this one out.

Cow.lua:

+ Spoiler

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

mobs:register_mob("mobs:cow", {
   type = "animal",
   passive = false,
   attack_type = "dogfight",
   reach = 2,
   damage = 4,
   hp_min = 5,
   hp_max = 20,
   armor = 200,
   collisionbox = {-0.4, -0.01, -0.4, 0.4, 1, 0.4},
   visual = "mesh",
   mesh = "mobs_cow.x",
   textures = {
      {"mobs_cow.png"},
   },
   makes_footstep_sound = true,
   sounds = {
      random = "mobs_cow",
   },
   walk_velocity = 1,
   run_velocity = 2,
   jump = true,
   drops = {
      {name = "mobs:meat_raw",
      chance = 1, min = 5, max = 10},
      {name = "mobs:leather",
      chance = 1, min = 0, max = 3},
   },
   water_damage = 1,
   lava_damage = 5,
   light_damage = 0,
   animation = {
      speed_normal = 15,
      speed_run = 15,
      stand_start = 0,
      stand_end = 30,
      walk_start = 35,
      walk_end = 65,
      run_start = 105,
      run_end = 135,
      punch_start = 70,
      punch_end = 100,
   },
   follow = "farming:wheat",
   view_range = 7,
   replace_rate = 50,
   replace_what = {"default:grass_3", "default:grass_4", "default:grass_5", "farming:wheat_8"},
   replace_with = "air",
   on_rightclick = function(self, clicker)
      if not mobs:feed_tame(self, clicker, 8, true, true) then
         local tool = clicker:get_wielded_item()

         -- milk cow with empty bucket
         if tool:get_name() == "bucket:bucket_empty" then
            if self.gotten == true
            or self.child == true then
               return
            end
            local inv = clicker:get_inventory()
            inv:remove_item("main", "bucket:bucket_empty")
            if inv:room_for_item("main", {name = "mobs:bucket_milk"}) then
               clicker:get_inventory():add_item("main", "mobs:bucket_milk")
            else
               local pos = self.object:getpos()
               pos.y = pos.y + 0.5
               minetest.add_item(pos, {name = "mobs:bucket_milk"})
            end
            self.gotten = true -- milked
            return
         end
      end   
      mobs:capture_mob(self, clicker, 0, 5, 60, false, nil)
   end,
})

mobs:register_spawn("mobs:cow", {"default:dirt_with_grass", "default:grass", "default:dirt", "ethereal:green_dirt"}, 20000, 7000, 1, 1, 31000)

mobs:register_egg("mobs:cow", "Cow", "default_grass.png", 1)

Tree Monster.lua

+ Spoiler

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

mobs:register_mob("mobs:tree_monster", {
    type = "monster",
    passive = false,
    collides_with_objects = false,
    damage = 3,
    attack_type = "dogfight",
    attacks_monsters = true,
    hp_min = 10,
    hp_max = 20,
    armor = 40,
    collisionbox = {-0.35,-1.0,-0.35, 0.35,0.8,0.35},
    visual = "mesh",
    mesh = "mobs_npc.b3d",
    drawtype = "front",
    textures = {
       {"mobs_tree_monster.png"},
    },
    makes_footstep_sound = true,
    sounds = {},
    walk_velocity = 2,
    run_velocity = 3,
    jump = true,
    walk_chance = 50,
    drops = {
       {name = "default:planks_oak",
        chance = 1, min = 1, max = 3},
       {name = "default:apple",
        chance = 2, min = 1, max = 2},
       {name = "default:axe_stone",
        chance = 5, min = 1, max = 1},
    },
    water_damage = 0,
    lava_damage = 2,
    light_damage = 2,
    follow = "gold:gold",
    view_range = 15,
    order = "stand",
    animation = {
       speed_normal = 30,
       speed_run = 30,
       stand_start = 0,
       stand_end = 79,
       walk_start = 168,
       walk_end = 187,
       run_start = 168,
       run_end = 187,
       punch_start = 200,
       punch_end = 219,
    },
})
mobs:register_spawn("mobs:tree_monster", {"default:dirt_with_grass", "default:junglegrass", "default:stone", "default:dirt"}, 21000, 6000, 9000, 1, 31000)

[TenPlus1]

We have two ways to spawn mobs in a world, the simple command being:

mobs:register_spawn(name, nodes, max_light, min_light, chance, active_object_count, max_height)

e.g.

mobs:register_spawn("mobs:cow", {"default:dirt_with_grass", "ethereal:green_dirt"}, 15, 0, 5000, 5, 31000)

...and the very specific command:

mobs:spawn_specfic(name, nodes, neighbors, min_light, max_light, interval, chance, active_object_count, min_height, max_height)

e.g.

mobs:spawn_specific("mobs:tree_monster", {"group:leaves", "default:dirt_with_grass"}, {"air"}, 0, 10, 20, 7000, 5, 0, 31000)

Note: active object count is how many mobs, signs, itemframes, dropped items are in the one block area at one time, if it's more than the number specified then a mob will not spawn. Also light levels go from 0 to 15.

Also, having docile mobs during the day is a good idea so they only attack at night time or when the player hits them, thanks.

[TenPlus1]

Version 1.18 released, added docile_by_day flag so that mobs will not attack player during the day unless hit first, have applied this to the spider which can now spawn during daytime.

[Soudon]

So the time scale 0-15 what is day and what is night, I've never sat down and figured it out. Doing /time 0 or any number up to 15 it stays dark

[firefox]

the time scale is far greater than 15.
5000 is shortly before sunrise.

0-15 is the level of light.
0 is darkness and 15 is sunlight.
14 is also registered as max_light to be used by lighting items.

[Soudon]

the time scale is far greater than 15.
5000 is shortly before sunrise.

0-15 is the level of light.
0 is darkness and 15 is sunlight.
14 is also registered as max_light to be used by lighting items.

Hey thanks now I just have to sit down and toy with it till im suited with the darkness level the hostile mobs spawn in. I like the docile flag but would rather the hostile mobs dont spawn period during they day.

Again thank you for the information.

[Soudon]

Version 1.18 released, added docile_by_day flag so that mobs will not attack player during the day unless hit first, have applied this to the spider which can now spawn during daytime.

awesome work here I just set my settings that all mobs spawn with light of 15, 0 and they all have a 15000 chance 5 object count and idk if it was a typo but I saw you had the height at 71 so I made them all that. cause all I did was copy your new api, and the docile function from the spider and pasted the api in the mobs folder and pasted the docile function in all my hostile mobs.

Now I face a new problem well not really a problem but they spawn way too many mobs lol. doesnt slow my game down at all. just I barely could get two or three to spawn now like 20+ including cows, sheep etc..

Great addition to this mod though it works so much better.

[AceWill]

Nice mod, however I do want to mention a few things aND make a few requests. First, is there a way to make mobs actually stay inside fences; they seem to mostly work, but my sheep in particular are managing to escape from a pen with a fence that is four blocks tall.
Additionally, is there a way to independently set the number of feedings to be different for taming, breeding, and feeding? So that, for instance, a sheep will regrow wool after one or two feedings while still requiring 8 to breed or tame.

Also, would it be possible to introduce a mechanic that lets sheep regrow wool or cows regenerate milk of their own accord? Not in such a way as to make it free, but give them the ability to feed themselves, at least to replenish wool or milk?


The creatures-MOB-Engine by BlockMen has a mechanic where sheep can regrow wool by eating a block of grass, turning it into just normal dirt. Having a system like that would be nice.

And the last thing on the list of requested features is some way to actually get chickens from eggs.

[firefox]

sheep and cows eating grass to replenish their resources sounds great.

i guess the "hatch chicken from egg" thing can be done with an ABM.

[TenPlus1]

I will look into having cows and sheep regrow wool or give more milk when eating 2 or 3 grass/wheat on their own, as for chickens from eggs, I could possible make it a throwable item and have a random chance of spawning a baby chick.

[Don]

as for chickens from eggs, I could possible make it a throwable item and have a random chance of spawning a baby chick.

You could make an incubator. if you put an egg in then in x amount of time you get a chick.

[Soudon]

ok I have a new spider texture I would like to use but with the current texture I can't figure out where I should copy and paste the parts from the one I have to replace the one that comes with the mod. If you could just let me know which parts are the face,body,legs etc... im sure I could do the copy paste just fine, at this point if I simply replace it the eyes end up on the front left leg otherwise doesnt look too bad.

[Ferk]

Check the current spider texture: https://github.com/tenplus1/mobs/blob/m ... spider.png (download it and zoom it)

It's not hard to see where the legs are, the abdomen is the bottom-left (the whiteish is the side that's facing up and black the side that faced the floor), and right above the abdomen is the head. I guess your texture is from minecraft? I don't expect it will match perfectly, but you could try adapting it.

[Soudon]

Check the current spider texture: https://github.com/tenplus1/mobs/blob/m ... spider.png (download it and zoom it)

It's not hard to see where the legs are, the abdomen is the bottom-left (the whiteish is the side that's facing up and black the side that faced the floor), and right above the abdomen is the head. I guess your texture is from minecraft? I don't expect it will match perfectly, but you could try adapting it.

It will work fine ive done it with the tree sand and dirt monsters was just hard tell with the spider.

[Soudon]

Check the current spider texture: https://github.com/tenplus1/mobs/blob/m ... spider.png (download it and zoom it)

It's not hard to see where the legs are, the abdomen is the bottom-left (the whiteish is the side that's facing up and black the side that faced the floor), and right above the abdomen is the head. I guess your texture is from minecraft? I don't expect it will match perfectly, but you could try adapting it.

here is my final result I'm ok with it I wasn't trying to make 100% perfect but it works good enough for me.

[Soudon]

Ok did a little toying around with it I wasn't quite suited with the eyes. So this is now the final result

+ Spoiler