FOSS gamedev and creative worlds

+ Screenshots:

• German by TeTpaAka

rubenwardy wrote:You should round the progress numbers.

• There should be human-readable quest titles.
• Longer quest descriptions should be possible. Ideally multi-line descriptions (I know it can be a bit tricky to do so)
• There should be a log of finished and failed quests
• Quests should not force a value, it should be possible to add quests without any value, for example for quests like “Find Old Shatterhand's home”.

guideahon wrote:Your mod would be great if you added killing mobs awards, and the graphics of this mod, viewtopic.php?id=4870 and finally, giving objects on difficult achievments

Wuzzy wrote:Interesting mod with a lot of potential.

Some suggestions:

• There should be human-readable quest titles.
• Longer quest descriptions should be possible. Ideally multi-line descriptions (I know it can be a bit tricky to do so)
• There should be a log of finished and failed quests
• Quests should not force a value, it should be possible to add quests without any value, for example for quests like “Find Old Shatterhand's home”.

• The API has changed. Now you can specify a title, which is shown in the HUD and a seperate description, which can be seen, if you click on info in the formspec
• see above
• added
• Quests with a value of 1 don't show the progress anymore. (May Winnetou guide you.)

guideahon wrote:Maybe integration with unified inventory would be a good idea.

TeTpaAka wrote:Sorry for changing the API again. I hope, now it is stable.

Wuzzy wrote:But I agree HUD could be improved.

Wuzzy wrote:Yay, cool! The HUD is now much better. Double-yay for progress bars. :-)

Wuzzy wrote:Oh, and the example quest should have its dependendy on default listed.

Wuzzy wrote:I discovered a bug: If you have an empty quest list (no matter which tab) in the quest dialog and hit “Info”, Minetest freezes.

Wuzzy wrote:Further HUD suggestions:
- When there are no open/failed/finished quests in a tab, don't show a textlist or table (whatever formspec element you used), show a label instead saying something like “There are no open quests.”.

Wuzzy wrote:- When there are no more open quests and no more quest which have been just finished or aborted or failed, the HUD should say something like: “No more open quests.”, maybe it gets automatically hidden after 10 seconds or so, so it does not get in the way (auto-hide should be configurable).

Wuzzy wrote:- Quests which have been “just finished” become green in the HUD and are auto-hidden after a few seconds. I like this. But I think there is still a minor flaw in it, because the quest which has been just finished is still listed under a label which says “Open Quests:”, which is of course untrue at this moment. It's not very important, but a possible “fix” for this would be to create another list saying “Just finished quests:”, which only appears when there is at least one such quest. The downside of this is that the quest info tends to “jump around” in the HUD. The lazy and probably saner fix would be to simply rename the label “Open Quests:” to “Quests:”. This would not be a problem, because the state of a quest can already be inferred from its color (yellow=open, green=finished, red: failed or aborted).

Wuzzy wrote:Other comments:
- I do not like how the long quest descriptions are implemented. Currently, it is just a text field, which can be edited, but it should be read-only. This is not really your fault, however, since the engine does not provide multi-line text labels at the moment. I have made an issue on GitHub about that already: https://github.com/minetest/minetest/issues/2249
There is an ugly workaround, however: Simply by using a textlist instead, but then you have to align each line of text manually, or you move this responsibility to the modder, which is even worse. So its best to just stay with (the ugly) textfields for now and lets hope multiline labels get implemented some day. ;-)

Wuzzy wrote:Edit:

I have tried out the API now and played around with sample_quest a bit, and it seems weird.
So at the beginning you register 4 quests, all with auto-accept. To my understanding, an auto-accept quest is active immediately, no need to call start_quest, right?
But if that's the case, why is it that at the beginning, only the quest “Walk 200 nodes” is active, but not the other ones? I have not seen any start_quest for the walk quest. So how could the mod possibly have known that you intended to only start the first “autoaccept” quest, but not the other 3? This doesn't look right.

I did the lazyer fix

I hope this fixes it. Now the window says: No quest specified. Is this OK?

Wuzzy wrote:Since this is an example, a couple of comments would clearly help. :)

Wuzzy wrote:I have a suggestion for a new API function:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

quests.show_formspec(playername)

This should show the quest formspec to the specified player; same effect as using “/quests”. Useful for mods which want to have their own way to show the quest formspec.

TeTpaAka wrote:

Wuzzy wrote:Other comments:
- I do not like how the long quest descriptions are implemented. Currently, it is just a text field, which can be edited, but it should be read-only. This is not really your fault, however, since the engine does not provide multi-line text labels at the moment. I have made an issue on GitHub about that already: https://github.com/minetest/minetest/issues/2249
There is an ugly workaround, however: Simply by using a textlist instead, but then you have to align each line of text manually, or you move this responsibility to the modder, which is even worse. So its best to just stay with (the ugly) textfields for now and lets hope multiline labels get implemented some day. ;-)

I know, this is ugly, but I can't do anything about it. Trying to implement multiline labels in lua would result in a much uglyer code.

domtron vox wrote:You should take a look at rubenwardy smartfs mod. I belive it adds a non-editable multi-line element. It also makes dealing with formspecs much easier. You can make it a dependancy or include it in your own code as a lua library. https://github.com/rubenwardy/smartfs

Wuzzy wrote:I am now quite happy with the mod. Good work! :-)

Using smartfs might work as a temporary solution until the engine provides native multiline text fields, but I haven't looked at this mod that much, so I don't know how feasible it is.

Minetestforfun wrote:Wow awesome Work ! keep up the good work, we wait impatient your realease 1.0 :D

Thank you for your work !

rubenwardy wrote:

domtron vox wrote:You should take a look at rubenwardy smartfs mod. I belive it adds a non-editable multi-line element. It also makes dealing with formspecs much easier. You can make it a dependancy or include it in your own code as a lua library. https://github.com/rubenwardy/smartfs

I don't remember this. I don't think I did.

Here is a way to do it:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

local ar = sometext:split("\n")
for i = 1, #ar do
   local text = ar[i]
   -- Hack to add word wrapping.
   -- TODO: Add engine support for wrapping in formspecs
   while #text > 80 do
      if formspec ~= "" then
         formspec = formspec .. ","
      end
      formspec = formspec .. core.formspec_escape(string.sub(text, 1, 79))
      text = string.sub(text, 80, #text)
   end
   if formspec ~= "" then
      formspec = formspec .. ","
   end
   formspec = formspec .. core.formspec_escape(text)
end

indriApollo wrote:This is a very nice mod ! thank you TeTpaAka

Aryandil wrote:I have a question. I'm rather new to computer skills when it comes to coding and all that and only just figured out where to put mods and maps. If you could explain how to use API, that would be great. Thank you!

amadin wrote:It is great mod, but i know to create many quests without gui interface is too long time and difficult for most peoples.