[Mod] Crafting [2.0.1] [crafting]

[Traxie21]

Many mods seem half-complete, like mine. BlockMen's seem complete.

[stu]

Please give Feedback and ideas for improvement

Can you tell me how this mod differs from the existing workbench mod(s) other that the MC background?

Only I looked at the code and I really do not understand why you need to use global step for this. Perhaps I am missing something here but I suggest you look at workbench mod by darkrose.

https://github.com/darkrose/minetest_mods/tree/master/workbench

[BlockMen]

Please give Feedback and ideas for improvement

Can you tell me how this mod differs from the existing workbench mod(s) other that the MC background?

Only I looked at the code and I really do not understand why you need to use global step for this. Perhaps I am missing something here but I suggest you look at workbench mod by darkrose.

https://github.com/darkrose/minetest_mods/tree/master/workbench

Notice:
- I know there are already 2 mods with workbenches, but this one works in a different way, because it uses the default inventory and works faster (for me)

This mod uses the players inventory. so it works complete different to the existing mods. the global step is needed to make using of players inventory possible. my mod is (for me) much faster and the code is also much smaller.

[stu]

This mod uses the players inventory. so it works complete different to the existing mods. the global step is needed to make using of players inventory possible. my mod is (for me) much faster and the code is also much smaller.

Oh, I see, so it replenishes the crafting ingredients directly from the player's inventory? (I don't actually play minecraft)

That is fine if you are happy with it, you did ask for feedback. I still don't think you're making best use of the api though.

[jordan4ibanez]

This mod uses the players inventory. so it works complete different to the existing mods. the global step is needed to make using of players inventory possible. my mod is (for me) much faster and the code is also much smaller.

Oh, I see, so it replenishes the crafting ingredients directly from the player's inventory? (I don't actually play minecraft)

That is fine if you are happy with it, you did ask for feedback. I still don't think you're making best use of the api though.

That's the thing. HE IS. This mod changes the client side inventory on the fly so you don't get any server lag.

[stu]

This mod uses the players inventory. so it works complete different to the existing mods. the global step is needed to make using of players inventory possible. my mod is (for me) much faster and the code is also much smaller.

Oh, I see, so it replenishes the crafting ingredients directly from the player's inventory? (I don't actually play minecraft)

That is fine if you are happy with it, you did ask for feedback. I still don't think you're making best use of the api though.

That's the thing. HE IS. This mod changes the client side inventory on the fly so you don't get any server lag.

Ok now I get it, very clever then. Shame we have to resort to such tactics, but if it gets the job done...

[jordan4ibanez]

Oh, I see, so it replenishes the crafting ingredients directly from the player's inventory? (I don't actually play minecraft)

That is fine if you are happy with it, you did ask for feedback. I still don't think you're making best use of the api though.

That's the thing. HE IS. This mod changes the client side inventory on the fly so you don't get any server lag.

Ok now I get it, very clever then. Shame we have to resort to such tactics, but if it gets the job done...

That isn't resorting to tactics, since any other way the gui would be handled serverside it would be laggy, this is a good idea.

ALSO: BlockMen can you make the workbench get the player's position also? you can move around without changing your yaw.

[darket]

https://www.youtube.com/watch?v=fssfKQ4iWqY

[BlockMen]

https://www.youtube.com/watch?v=fssfKQ4iWqY

Thanks for this great review!

Could you move the download link in the description to this topic? There will be a few updates more i guess.

BlockMen can you make the workbench get the player's position also? you can move around without changing your yaw.

Good idea, thanks.

[TheBonsai]

ALSO: BlockMen can you make the workbench get the player's position also? you can move around without changing your yaw.

The yaw-method to detect when to swap back is a thing I didn't mention yesterday, because I didn't see any practical solution. Is this the only way (i.e." workaround" :-) )

[darket]

Thanks for this great review!

Could you move the download link in the description to this topic? There will be a few updates more i guess.

Ok, I'll do that

[Mito551]

will you make support for creative? that's the only thing that this mod is bad with, at least as I see it.

[BlockMen]

Thanks for this great review!

Could you move the download link in the description to this topic? There will be a few updates more i guess.

Ok, I'll do that

Thx

will you make support for creative? that's the only thing that this mod is bad with, at least as I see it.

Yes, it will get a Minecraft like creative inventory too. But its not finished yet...

[4aiman]

BlockMen, please, check your code: http://forum.minetest.net/viewtopic.php?pid=85858#p85858
(Thanks to Mito for redirecting me here - I couldn't find this topic for some reason...)

[BlockMen]

BlockMen, please, check your code: http://forum.minetest.net/viewtopic.php?pid=85858#p85858
(Thanks to Mito for redirecting me here - I couldn't find this topic for some reason...)

Well, AFIK Crafting doesnt have this issue, because there the width is always set. So please report that to jojoa1997 he has modiefied my mod when he joined it in his inventory mod. Furthermore im not involved in MiniTest...

[4aiman]

I know you aren't involved into Minitest, but I remembered this mod of yours and eventually end up posting here.
Anyway, thanks for help! ;)

[BlockMen]

I know you aren't involved into Minitest, but I remembered this mod of yours and eventually end up posting here.
Anyway, thanks for help! ;)

Sry that i cant help you here, but i wont start to analyse jojoa1997's code ;)

[jojoa1997]

I know you aren't involved into Minitest, but I remembered this mod of yours and eventually end up posting here.
Anyway, thanks for help! ;)

Sry that i cant help you here, but i wont start to analyse jojoa1997's code ;)

I made it. The inventory looks similar but isn't the same. Look at changelog.txt to see who did what but remember I edit a lot of the stuff.

[BlockMen]

Update: [Modpack] Craft added
(and multiplayer issues fixed)

I have decided to Pre-Release a new feature of Crafting, the creative Inventory:


To install download this modpackand make sure that the current version of crafting is deinstalled. The lastest Minetestversion will produce a warning because of two mods with same name (but has no effect after all). Hopfully that will changed in future Minetest versions.

Download Pre-Release here

A Feedback to the creative inventory would be nice, because there could still be bugs.

[cHyper]

awesome mod.. keep on good work...

[jojoa1997]

Sweet I can't wait to try this out.

[rubenwardy]

Wow this is amazing!

Is the creative inventory skin-able with texture packs?

[jojoa1997]

Could someone post a video?

[BlockMen]

awesome mod.. keep on good work...

Sweet I can't wait to try this out.

Wow this is amazing!

Thanks.

Is the creative inventory skin-able with texture packs?

Sure. But the ugly semi-transparent black in background is always there...

[jojoa1997]

Simple. Look at the inventory mod. You set the background pos to -#, -# and set the pic size acordingly

[BlockMen]

Simple. Look at the inventory mod. You set the background pos to -#, -# and set the pic size acordingly

I know how that works and this Mod uses it. But for the creative inventory it is caused by the buttons on the bottom and the gaps between the buttons

[Nore]

Could you check the pitch too? From the tests I made, you can't open your inventory or move or do anything if you don't move the mouse a bit. Checking the yaw and the pitch removes every problem (tested, it works).

[BlockMen]

Could you check the pitch too? From the tests I made, you can't open your inventory or move or do anything if you don't move the mouse a bit. Checking the yaw and the pitch removes every problem (tested, it works).

Yes, forgot to fix that in the pre-release. It will be fixed in next release.

[Evergreen]

In the next release, could you add the inventory GUI for furnaces? It would make it more complete.

[rubenwardy]

If only you could skin the pause menu, and the main game menu....