[Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fixes

User avatar
ExeterDad
Member
 
Posts: 1121
Joined: Sun Jun 01, 2014 20:00
In-game: ExeterDad

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by ExeterDad » Mon Mar 20, 2017 14:54

fireglow wrote:Recent minetest-dev clients can't see their own messages.
Other players can see the messages, but not the player with the dev client.

Example:
Client: 0.4.15-1de08e19
Server: 0.4.15-7b74f04a


I'm seeing this as well. Newer dev clients no longer have chat prediction visible. I thought about overcoming this on mine by sending a copy of sent chat to sender, but then older clients with chat prediction would see double posts.
٩(̾●̮̮̃̾•̃̾)۶

Kibbie and I have a beautiful public server now! HOMETOWN
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Mon Mar 20, 2017 15:15

 

User avatar
ExeterDad
Member
 
Posts: 1121
Joined: Sun Jun 01, 2014 20:00
In-game: ExeterDad

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by ExeterDad » Mon Mar 20, 2017 15:18

rubenwardy wrote:https://github.com/rubenwardy/chatplus/commit/d0834e2cb31d67645c1840d4cf4ee4ed872d2a85

Nice! And only two lines added? Is it wrong that I hate how easy you make things look? :P
٩(̾●̮̮̃̾•̃̾)۶

Kibbie and I have a beautiful public server now! HOMETOWN
 

User avatar
fireglow
Member
 
Posts: 72
Joined: Fri Mar 28, 2014 11:36
IRC: fireglow
In-game: fireglow

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by fireglow » Mon Mar 20, 2017 15:49

Not quite, I'm afraid:
Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.
Code: Select all
ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod '' in callback on_chat_message(): /srv/minetest/world3/worldmods/chatplus/api.lua:223: attempt to call field 'chat_send_place' (a nil value)
stack traceback:
      /srv/minetest/world3/worldmods/chatplus/api.lua:223: in function 'send'
      /srv/minetest/world3/worldmods/chatplus/api.lua:232: in function </srv/minetest/world3/worldmods/chatplus/api.lua:231>
      ...rvers/0.4.15-3-7b74f04a/bin/../builtin/game/register.lua:412: in function <...rvers/0.4.15-3-7b74f04a/bin/../builtin/game/register.lua:392>

Server: 0.4.15-7b74f04a
Client: 0.4.15-c05dfac
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Mon Mar 20, 2017 15:51

 

User avatar
fireglow
Member
 
Posts: 72
Joined: Fri Mar 28, 2014 11:36
IRC: fireglow
In-game: fireglow

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by fireglow » Mon Mar 20, 2017 15:53

Perfect, thank you very much!
 

User avatar
fireglow
Member
 
Posts: 72
Joined: Fri Mar 28, 2014 11:36
IRC: fireglow
In-game: fireglow

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by fireglow » Mon Mar 20, 2017 16:16

I spoke too soon:
Now the release clients get their chat echoed two times.
Is this an EITHER case, where you could either support 0.4.15-release OR 0.4.15-dev, but not both?
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Thu Mar 23, 2017 15:28

fireglow wrote:I spoke too soon:
Now the release clients get their chat echoed two times.
Is this an EITHER case, where you could either support 0.4.15-release OR 0.4.15-dev, but not both?


Afaik there's no way of detecting whether a client will print the chat message before sending it, so yes: I can only support one or the other :(
 

Previous

Return to Mod Releases

Who is online

Users browsing this forum: No registered users and 9 guests

cron