[Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fixes

Sokomine
Member
 
Posts: 2980
Joined: Sun Sep 09, 2012 17:31

by Sokomine » Fri Jan 31, 2014 22:44

It would be very good if individual messages in the inbox could be deleted while others could be kept. A command like /inbox del <nr> to delete message <nr> would be very welcomed.
A list of my mods can be found here.
 

User avatar
Jonathan
Member
 
Posts: 119
Joined: Tue Apr 02, 2013 14:07

by Jonathan » Fri Jan 31, 2014 23:17

rubenwardy wrote:[h]Coming soon[/h]
  • Swearing filter


Nice! Keep up the good work!
By perseverance the snail reached the ark.
- Charles Spurgeon
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

by rubenwardy » Wed Apr 09, 2014 19:01

[h]Graphical inboxes[/h]

0.6 adds formspec inboxes like the following. They are scrollable.

You can still access the text/chat version by typing /inbox text or /inbox t

Image
Last edited by rubenwardy on Wed Apr 09, 2014 19:01, edited 1 time in total.
 

User avatar
hoodedice
Member
 
Posts: 1372
Joined: Sat Jul 06, 2013 06:33

by hoodedice » Wed Apr 09, 2014 19:28

Why is this not default already?
7:42 PM - Bauglio: I think if you go to staples you could steal firmware from a fax machine that would run better than win10 does on any platform
7:42 PM - Bauglio: so fudge the stable build
7:43 PM - Bauglio: get the staple build
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

by rubenwardy » Wed Apr 09, 2014 19:33

It would be pointless in single player, so it probably won't be added to minetest_game.
 

4aiman
Member
 
Posts: 1208
Joined: Mon Jul 30, 2012 05:47

by 4aiman » Thu Apr 10, 2014 08:37

Neat! :)

Also, what about swearing filter?
Do you plan to add a dictionary of the most frequently used swears?
It would be funny to replace all those with "Capybara" :)
 

User avatar
BrunoMine
Member
 
Posts: 902
Joined: Thu Apr 25, 2013 17:29
GitHub: BrunoMine

Re: [Mod] Chat plus [0.6] [chatplus] -- Inbox GUI

by BrunoMine » Fri Jun 13, 2014 13:55

Eui just want to mail. The old version has only mail?

This is a bug:
size[10,5]textlist[0,0;9.75,5;inbox;13/06 <Admin>: Ola]
11:04:50: ERROR[main]: Invalid textlist element(4): '0,0;9.75,5;inbox;13/06 <Admin>: Ola'
11:04:55: ERROR[main]: Invalid textlist element(4): '0,0;9.75,5;inbox;13/06 <Admin>: Ola'
size[10,5]textlist[0,0;9.75,5;inbox;13/06 <Admin>: HOOOOOOOOOOOOOOaaaa]
11:05:37: ERROR[main]: Invalid textlist element(4): '0,0;9.75,5;inbox;13/06 <Admin>: HOOOOOOOOOOOOOOaaaa'
GUIPauseMenu: Not allowing focus change.
 

User avatar
stormchaser3000
Member
 
Posts: 407
Joined: Sun Oct 06, 2013 21:02

Re: [Mod] Chat plus [0.6] [chatplus] – Inbox GUI

by stormchaser3000 » Mon Aug 10, 2015 21:32

please add the swearing filter. for english, russian, spanish, portuguese, and german swear words. and please make it compatible with the irc mod
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [Mod] Chat plus [0.6] [chatplus] – Inbox GUI

by rubenwardy » Tue Aug 11, 2015 08:16

Already exists, set the chatplus_badwords = one, two, three as a setting in minetest.conf

or add it in lua here yourself: https://github.com/rubenwardy/chatplus/ ... t.lua#L401
 

CWz
Member
 
Posts: 185
Joined: Tue Dec 24, 2013 17:01

Re: [Mod] Chat plus [0.6] [chatplus] – Inbox GUI

by CWz » Fri Aug 14, 2015 09:27

chat plus seems to allow players to talk without shout.

stormchaser3000, this also interferers with keyword_interact
 

Gundul
Member
 
Posts: 177
Joined: Thu Aug 27, 2015 10:55
GitHub: berengma
IRC: Gundul

Re: [Mod] Chat plus [0.6] [chatplus] – Inbox GUI

by Gundul » Sat Sep 12, 2015 10:30

Nice work. I added to my server "Jungle".
As admin it would be cool if there was an option to send email to all users. For example to inform about news on the server.
 

User avatar
Minetestforfun
Member
 
Posts: 936
Joined: Tue Aug 05, 2014 14:09
GitHub: Darcidride
IRC: Darcidride + MinetestForFun
In-game: Darcidride + MinetestForFun

Re: [Mod] Chat plus [0.6] [chatplus] – Inbox GUI

by Minetestforfun » Mon Sep 14, 2015 11:39

Gundul wrote:Nice work. I added to my server "Jungle".
As admin it would be cool if there was an option to send email to all users. For example to inform about news on the server.


+1
 

User avatar
JoshMars
Member
 
Posts: 103
Joined: Sat May 17, 2014 23:24
In-game: rubber UbuntuJosh

Re: [Mod] Chat plus [1.0-RC] [chatplus] – Inbox GUI

by JoshMars » Fri Jan 15, 2016 22:50

Basically this whole mod should be client side and should be included by default
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [Mod] Chat plus [1.0-RC] [chatplus] – Inbox GUI

by rubenwardy » Sat Jan 16, 2016 00:51

Yes. Now that email, has been separated, it's pretty much just an ignore filter by default. It has an API too, though, but not used much.
 

User avatar
vitaminx
Member
 
Posts: 49
Joined: Tue Dec 30, 2014 15:08
GitHub: vitaminx

Re: [Mod] Chat plus [1.0-RC] [chatplus] – Inbox GUI

by vitaminx » Tue Jan 19, 2016 10:51

Hi,

This mod is great :)
I have a question though. How can you see who's currently on your ignore list?
Maybe this function could be added to the mod.

Greetings.
 

Gundul
Member
 
Posts: 177
Joined: Thu Aug 27, 2015 10:55
GitHub: berengma
IRC: Gundul

Re: [Mod] Chat plus [1.0-RC] [chatplus] – Inbox GUI

by Gundul » Tue Mar 01, 2016 01:59

I had some trouble when updating from chatplus 0.6 to the new version.

Together with your email 0.1 I could send mails and use /msg also. Everything
seemed to work fine. But what did not work was the chat. Not even one single
word wanted to appear on screen. Only who logged in and out was shown.

I commented this in your api.lua out and now it works:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.
Code: Select all
-- Minetest callbacks
--minetest.register_on_chat_message(function(...)
--   local ret = chatplus.send(...)
--   if ret and minetest.global_exists("irc") and irc.on_chatmessage then
--      irc.on_chatmessage(...)
--   end
--   return ret
--end)


Did you send all chat to Irc by default ?


Gundul
 

User avatar
afflatus
Member
 
Posts: 302
Joined: Tue Apr 01, 2014 19:47
GitHub: 0-afflatus
IRC: afflatus
In-game: afflatus

Re: [Mod] Chat plus [1.0-RC] [chatplus] – Inbox GUI

by afflatus » Thu Mar 17, 2016 12:01

This is a very useful mod. I have found a couple of problems ...

* I have written a script to rotate chatplus-log.txt as it can easily grow to several MB if the server is busy. This was causing freeze-ups on my server (not enough memory probably)
* I want to move the mail icon from in-your-face. I dare say that is trivial (haven't looked yet).

I'm using an older version, so I'll upgrade to 1.0-rc before I comment any further.
Nice work Rubenwardy!
Grailtest is sleeping ...
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [Mod] Chat plus [1.0-RC] [chatplus] – Inbox GUI

by rubenwardy » Thu Mar 17, 2016 15:20

I wish it was easier to place hud items compatibly. :(

Chatplus is a little bit outdated and needs some work from me to fix some things. I recommend you look into the ignore and email mods. Ignore works a lot better than chatplus, just looking at the code.

At some point I'll update it. I'm just quite busy with other things. Log rotation would be a nice feature.
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Thu Mar 17, 2016 15:59

2.3 Released!



Fixes chat messages not sending

https://github.com/rubenwardy/chatplus/ ... s/tag/v2.3
 

User avatar
afflatus
Member
 
Posts: 302
Joined: Tue Apr 01, 2014 19:47
GitHub: 0-afflatus
IRC: afflatus
In-game: afflatus

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by afflatus » Thu Mar 17, 2016 17:02

OK, I was just about to report that.
I'll pull and test.
Thanks
Grailtest is sleeping ...
 

User avatar
afflatus
Member
 
Posts: 302
Joined: Tue Apr 01, 2014 19:47
GitHub: 0-afflatus
IRC: afflatus
In-game: afflatus

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by afflatus » Thu Mar 17, 2016 17:13

That works :-)
Grailtest is sleeping ...
 

User avatar
afflatus
Member
 
Posts: 302
Joined: Tue Apr 01, 2014 19:47
GitHub: 0-afflatus
IRC: afflatus
In-game: afflatus

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by afflatus » Sat Mar 19, 2016 07:39

This mod doesn't seem to respect shout priv, which means I can't gag verbally abusive players. Has anyone else experienced this?
Grailtest is sleeping ...
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Sat Mar 19, 2016 14:43

Weird, it's not documented that register_on_chat_message is still called if the player doesn't have shout.

Does this fix your problem? https://github.com/rubenwardy/chatplus/ ... 50ca1556a4
 

User avatar
afflatus
Member
 
Posts: 302
Joined: Tue Apr 01, 2014 19:47
GitHub: 0-afflatus
IRC: afflatus
In-game: afflatus

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by afflatus » Sat Mar 19, 2016 19:23

rubenwardy wrote:Weird, it's not documented that register_on_chat_message is still called if the player doesn't have shout.

Does this fix your problem? https://github.com/rubenwardy/chatplus/ ... 50ca1556a4


It does indeed. Thank you :)
Grailtest is sleeping ...
 

bark
Member
 
Posts: 35
Joined: Thu Sep 24, 2015 13:25
In-game: bark

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by bark » Wed Jun 01, 2016 21:46

EDIT: Never mind
 

Fixerol
Member
 
Posts: 633
Joined: Sun Jul 31, 2011 11:23
IRC: Fixer
In-game: Fixer

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by Fixerol » Sun Aug 28, 2016 12:46

Please add few simple optional antispam filters to public chat (and mail?):
+ block same message spam by player
+ truncate or block very large messages
+ block messages with https:// or ftp:// or www.
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by rubenwardy » Sun Aug 28, 2016 13:06

1) Good suggestion, is in my (mental) to do list
2) This is potentially problematic - what if they write a long rant, and have it deleted?
3) This is also problematic - how do you detect web links reliably?
 

User avatar
mahmutelmas06
Member
 
Posts: 355
Joined: Mon Mar 02, 2015 13:10
GitHub: mahmutelmas06
IRC: mahmutelmas06
In-game: masum

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by mahmutelmas06 » Sun Aug 28, 2016 17:18

Is it possible to see only chat messages left of the bottom instead of top ?
It would be easier to read.
My Mods:

Beverage
 

Fixerol
Member
 
Posts: 633
Joined: Sun Jul 31, 2011 11:23
IRC: Fixer
In-game: Fixer

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by Fixerol » Sun Aug 28, 2016 17:55

>2) This is potentially problematic - what if they write a long rant, and have it deleted?

add sane defaults (amount of symbols before truncation) and make it disabable if you are worrying, I've seen some huge spam messages that cover my entire 1280*1024 screen which slowed down minetest to few fps on descent PC.

>3) This is also problematic - how do you detect web links reliably?

Number 3 is not a big deal, 1) and 2) is a big deal, worst kinds of spam
 

User avatar
fireglow
Member
 
Posts: 72
Joined: Fri Mar 28, 2014 11:36
IRC: fireglow
In-game: fireglow

Re: [Mod] Chat plus [2.3] [chatplus] – Now two mods, bug fix

by fireglow » Mon Mar 20, 2017 11:00

Recent minetest-dev clients can't see their own messages.
Other players can see the messages, but not the player with the dev client.

Example:
Client: 0.4.15-1de08e19
Server: 0.4.15-7b74f04a
 

PreviousNext

Return to Mod Releases

Who is online

Users browsing this forum: No registered users and 13 guests

cron