No changes without prior inspection if it still works.

Big-Ghost
New member
 
Posts: 3
Joined: Sun Aug 07, 2016 12:04

No changes without prior inspection if it still works.

by Big-Ghost » Sun Aug 07, 2016 12:21

Please, don't change any line of code in the mods and upload a wrong version to github!

Example:

https://github.com/minetest/minetest_ga ... f13b3b1ac7

There must be something wrong? Or not?

Crafting 9 x "default:stone" to one "default:stone_block" and not to "default:stone_block 9"

desert_stone, obsidian and so on are wrong.

Take better care of it. Please!
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

Re: No changes without prior inspection if it still works.

by rubenwardy » Sun Aug 07, 2016 12:57

I don't understand what you mean: 9 stone does make 9 stone_block
 

KCoombes
Member
 
Posts: 278
Joined: Thu Jun 11, 2015 23:19
In-game: Knatt or Rudilyn

Re: No changes without prior inspection if it still works.

by KCoombes » Sun Aug 07, 2016 13:04

I think the issue is the non-conforming of the recipes - AFAIK, 9 ingots makes 1 block, so logically 9 stone would make 1 stone_block, not 9 stone_block (which is what the existing recipes yield in this mod)
 

Big-Ghost
New member
 
Posts: 3
Joined: Sun Aug 07, 2016 12:04

Re: No changes without prior inspection if it still works.

by Big-Ghost » Sun Aug 07, 2016 15:45

KCoombes wrote:I think the issue is the non-conforming of the recipes - AFAIK, 9 ingots makes 1 block, so logically 9 stone would make 1 stone_block, not 9 stone_block (which is what the existing recipes yield in this mod)


That's exactly what I mean. Thank you.
 

Byakuren
Member
 
Posts: 441
Joined: Tue Apr 14, 2015 01:59
GitHub: raymoo
IRC: Hijiri

Re: No changes without prior inspection if it still works.

by Byakuren » Sun Aug 07, 2016 19:45

Conceptually, ingots are small, while nodes (like stone) are large. So while it may take 9 ingots to make up one full node of material, 9 nodes should make up 9 nodes of material. I don't think there is any real inconsistency if you account for what the items are supposed to represent, and that in the case of 9 ingots -> 1 block, you are unable to place the ingots as nodes themselves.
Every time a mod API is left undocumented, a koala dies.
 

User avatar
Napiophelios
Member
 
Posts: 752
Joined: Mon Jul 07, 2014 01:14
GitHub: Napiophelios
IRC: Nappi
In-game: Nappi

Re: No changes without prior inspection if it still works.

by Napiophelios » Sun Aug 07, 2016 20:04

right now the crafting recipe is just a conversion from 9 natural rough stone to 9 crafted polished stone;
it makes sense there would/should be some cost or loss of material for a more refined product.
If not then why use a number at all?
why would I need to collect 9 before I can make the conversion?
 

Byakuren
Member
 
Posts: 441
Joined: Tue Apr 14, 2015 01:59
GitHub: raymoo
IRC: Hijiri

Re: No changes without prior inspection if it still works.

by Byakuren » Sun Aug 07, 2016 20:27

Napiophelios wrote:why would I need to collect 9 before I can make the conversion?

I can only think of the practical reason that you need more than one item to have a crafting recipe that isn't just a single item. You could make a recipe with just one item, but then you will collide when you try to make "sensible" recipes for other forms of worked stone.
Every time a mod API is left undocumented, a koala dies.
 

Big-Ghost
New member
 
Posts: 3
Joined: Sun Aug 07, 2016 12:04

Re: No changes without prior inspection if it still works.

by Big-Ghost » Mon Aug 08, 2016 06:14

I think we need more of a definition, what is a block and what is a compressed block. In my opinion it would be better to say. A block is something that consists of 9 identical items. No matter what size they have.

To save storage space, this would be a definition of block for me. Compression would be a misnomer for it. Wool as an example. We should not consider the real conditions of the material. Otherwise we would have to do with other things in Minetest to corresponds to reality and that would be a lot of work.

Just a suggestion.
 


Return to Minetest General

Who is online

Users browsing this forum: No registered users and 7 guests

cron