0.4.5 help

[zoropig]

how do you put your lets say friends server in favorits in 0.4.5

[PilzAdam]

The favorite server list is broken under windows.

[onpon4]

The favorite server list is broken under windows.

Does it work anywhere? I couldn't figure out how to get it to work in GNU/Linux either.

[PilzAdam]

Its broken in a system wide installation in Linux too (this is fixed in current dev version already).

[ds-2k]

PilzAdam, could you try making a windows build with a modification to:
https://github.com/minetest/minetest/blob/master/src/serverlist.cpp#L56

replacing

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

std::ifstream istream(path.c_str(), std::ios::binary);

with

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

std::ifstream istream(path.c_str());

and see if the favorites list works for windows users then? (Other uses of ifstream/ofstream such as reading minetest.conf do not use std::ios::binary: https://github.com/minetest/minetest/blob/master/src/settings.h#L169).

[sfan5]

PilzAdam, could you try making a windows build with a modification to:
https://github.com/minetest/minetest/blob/master/src/serverlist.cpp#L56

replacing

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

std::ifstream istream(path.c_str(), std::ios::binary);

with

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

std::ifstream istream(path.c_str());

and see if the favorites list works for windows users then? (Other uses of ifstream/ofstream such as reading minetest.conf do not use std::ios::binary: https://github.com/minetest/minetest/blob/master/src/settings.h#L169).

Here you go: http://sfan.sf.funpic.de/minetest-builds/c55/minetest-0.4.6-a031a15-serverlistfix-win32.7z

[ds-2k]

Here you go: http://sfan.sf.funpic.de/minetest-builds/c55/minetest-0.4.6-a031a15-serverlistfix-win32.7z

I rebooted into windows xp and this works (I joined 2 servers and they both appeared in the server favorites list). When I compiled on linux with that change, the server favorites list continues to work fine, so I think you could pull request the fix to the main repository.

[sfan5]

Here you go: http://sfan.sf.funpic.de/minetest-builds/c55/minetest-0.4.6-a031a15-serverlistfix-win32.7z

I rebooted into windows xp and this works (I joined 2 servers and they both appeared in the server favorites list). When I compiled on linux with that change, the server favorites list continues to work fine, so I think you could pull request the fix to the main repository.

Pull request? I am one of the Minetest Core Developers

[sfan5]

Fix commited: https://github.com/minetest/minetest/commit/b88aa81da7031ddb228e8901071b5adf2980c7ed