Page 1 of 1

minetest_game and the stockpile of pull requests

PostPosted: Mon Apr 20, 2015 19:17
by lightonflux
Hello,

the default game "minetest_game" has 50 unresolved pull requests at the moment. Some of these are controversial others have merge conflicts. But a lot look fine and don't have negative comments (towards merging) in their issue.

So what is the problem at the moment? Reviews? Time? Compatibility?

It also looks like that there are some PR of issue that are closed, but nobody ever closed the PR.

Re: minetest_game and the stockpile of pull requests

PostPosted: Wed Apr 22, 2015 12:33
by ThatGraemeGuy
Politics I'd imagine

Re: minetest_game and the stockpile of pull requests

PostPosted: Wed Apr 22, 2015 18:55
by Krock
Look at the Mientest core: 99 open pull requests.
I think the most of them have a low priority thus, grass is growing over those things and somewhen it results in a merge conflict.

Re: minetest_game and the stockpile of pull requests

PostPosted: Thu Apr 23, 2015 01:58
by Sokomine
I'm not sure how many people actually read all those pull requests and do form an opinion about them. And even if there's a good pull request that does get sufficient attention, there's the general problem with changes: Half the people may not like them at all. It's in general not a big problem to add something (new blocks for example) - players can either use them or not. But other changes may have a deeper impact and steer the game in one direction or another - a direction which might not be shared by other players.

Re: minetest_game and the stockpile of pull requests

PostPosted: Thu Apr 23, 2015 06:52
by paramat
The MTGame team seem busy with other stuff recently.