Post your modding questions here

[Hybrid Dog]

ABJ, you can use the on_place, on_construct etc. in the node definition.

[ozkur]

Sorry that this is the derpiest of all derpy and stupid questions:

How do I upload a mod to the forums?

[Hybrid Dog]

ozkur, there are lots of ways to upload a mod, e.g. here's the init.lua of my version of the drippingwater mod as png:

(it's grey because ascii)

[BrunoMine]

Hello guys.
I'm having trouble for detect objects in an area. I have used the minetest.get_objects_inside_radius method, but it does not work correctly. Sometimes it does not work, usually when I'm at a disancia of approximately 20 blocks.
Is there any more consistent way to perform this verification?

[ozkur]

ozkur, there are lots of ways to upload a mod, e.g. here's the init.lua of my version of the drippingwater mod as png:

(it's grey because ascii)

Thanks for trying, but I still am confused.
Are you saying I do something like turn the entire folder into a .png file?

[kaeza]

Sorry that this is the derpiest of all derpy and stupid questions:

How do I upload a mod to the forums?

Use an archiving program(*) to compress your folder in a ZIP file, create a new topic for it in the WIP Mods subforum(**), and upload the ZIP file as an attachment ("Upload attachment" tab under the posting text box).

(*) Windows comes with support to compress folders, or you can use an external program like 7-zip.
(**) See also the guidelines for mod releases.

[ozkur]

Sorry that this is the derpiest of all derpy and stupid questions:

How do I upload a mod to the forums?

Use an archiving program(*) to compress your folder in a ZIP file, create a new topic for it in the WIP Mods subforum(**), and upload the ZIP file as an attachment ("Upload attachment" tab under the posting text box).

(*) Windows comes with support to compress folders, or you can use an external program like 7-zip.
(**) See also the guidelines for mod releases.

Thanks!

[Hybrid Dog]

BrunoMine, you can only get active objects. Maybe you need to forceload some chunks.

[orwell]

BrunoMine, you can only get active objects. Maybe you need to forceload some chunks.

Are you scanning for objects that your mod defines? Then let them save their last active position in a table and just search this yourself. Then just forceload that area(*)
#screwminetestsbuggyobjectmanagementsystem
To work consistently, that table has to be saved on shutdown.

(*) use that forceload anchors library, it handles forceloads better than minetest's internal.

[burli]

How can I place a locked chest and a key to unlock to a map from a script?

[GreenDimond]

I seem to be having trouble with registering 2 'on_punch' to the same node.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

on_punch = function(pos, node, player, pointed_thing)
      local inv = player:get_inventory()
      inv:add_item("main", "modname:node")
on_punch = function(pos, node, puncher, pointed_thing)
      minetest.set_node(pos, {name = "modename:othernode", param2 = node.param2})
   end
   end

This is only one example of what I have tried. In this particular case, only the first function happens. Other times it was just the latter. I want both to happen. How do I do this?

[sofar]

I seem to be having trouble with registering 2 'on_punch' to the same node.

You can't. Combine the code into one function.

[GreenDimond]

I seem to be having trouble with registering 2 'on_punch' to the same node.

You can't. Combine the code into one function.

I have realized this, but now I am having trouble with that aswell. I will post here if I cant fix.

[GreenDimond]

Still working on this, but apparently I still cant seem to be able to lua.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

   get_item = function ()
--        function(pos, node, player, pointed_thing)
        local inv = player:get_inventory()
        inv:add_item("main", "modname:nodedame")
    end,
    replace_model = function ()
--        function(pos, node, puncher, pointed_thing)
        minetest.set_node(pos, {name = "modname:othernodename", param2 = node.param2})
    end,
    do_punch = function do_punch()
      get_item()
      replace_model()
   end,
    on_punch = do_punch

commenting the function(pos, blablabla) out allows the mod to run. Otherwise it wants '<name>' at the first function(pos, node, player, blablabla). No idea what to do.

[GreenDimond]

This code lets the game start and actually does something when I punch the node. My game crashes.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

   get_item = function (player)
--      function(pos, node, player, pointed_thing)
      local inv = player:get_inventory()
      inv:add_item("main", "modname:nodename")
   end,
   replace_model = function (pos, node)
--      function(pos, node, puncher, pointed_thing)
      minetest.set_node(pos, {name = "modname:othernodename", param2 = node.param2})
   end,

   on_punch = function (pos, node, player, pointed_thing)
      node.get_item(player)
      node.replace_model(pos, node)
   end
})

I think I am about 90% of the way there, but am now moving as fast as a brick. So wat do now?
error code:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

2017-02-13 21:02:12: ERROR[Main]: ServerError: Lua: Runtime error from mod 'modname' in callback node_on_punch(): /home/alex/.minetest/mods/modname/nodes.lua:68: attempt to call field 'get_item' (a nil value)
2017-02-13 21:02:12: ERROR[Main]: stack traceback:
2017-02-13 21:02:12: ERROR[Main]:    /home/alex/.minetest/mods/modname/nodes.lua:68: in function </home/alex/.minetest/mods/modname/nodes.lua:67>


In case you are wondering, I use "modname" and "nodename" and stuff to keep the mod a secret :P

[D00Med]

I have a maths related question.
I can make an entity rotate so that it matches the player's yaw. Now I'm trying to make the entity 'catch-up' to the player's yaw. There's a problem with this though. When the player's yaw crosses 0/2pi the difference between the player's yaw and the entity's yaw makes the entity spin around in the opposite direction(the long way around).
At the moment the rotation of the entity is divided into four steps. The higher the number of steps it takes to catch up, the more noticeable the problem is.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

   
local target_yaw = yaw+math.pi+math.pi/2
local entity_yaw = entity.object:getyaw()
if target_yaw <= 6.2 and target_yaw >= 0.2 then --this is the only method I have to stop the problem
   entity.object:setyaw(entity_yaw+(target_yaw-entity_yaw)/4)
   else
   entity.object:setyaw(target_yaw)
end

^ yaw is the player's yaw

How can I do this so that the shortest difference is used?

@GreenDimond:
Have you tried just using get_item and replace_model rather than node.get_item and node.replace_model?

[orwell]

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

-- before the node definition, make these as local functions
local function get_item(player)
      local inv = player:get_inventory()
      inv:add_item("main", "modname:nodename")
end
local function replace_model(pos, node)
--      function(pos, node, puncher, pointed_thing)
      minetest.set_node(pos, {name = "modname:othernodename", param2 = node.param2})
end
minetest.register_node("name",{
-- ...
   on_punch = function (pos, node, player, pointed_thing)
      get_item(player)
      replace_model(pos, node)
   end
-- ...
})

get_item and replace_model are functions local to the lua file. Because the node is defined in this scope, you can call the functions from there.
Also, 'node' is not ' node definition'.

[orwell]

I have a maths related question.
I can make an entity rotate so that it matches the player's yaw. Now I'm trying to make the entity 'catch-up' to the player's yaw. There's a problem with this though. When the player's yaw crosses 0/2pi the difference between the player's yaw and the entity's yaw makes the entity spin around in the opposite direction(the long way around).
At the moment the rotation of the entity is divided into four steps. The higher the number of steps it takes to catch up, the more noticeable the problem is.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

   
local target_yaw = yaw+math.pi+math.pi/2
local entity_yaw = entity.object:getyaw()
if target_yaw <= 6.2 and target_yaw >= 0.2 then --this is the only method I have to stop the problem
   entity.object:setyaw(entity_yaw+(target_yaw-entity_yaw)/4)
   else
   entity.object:setyaw(target_yaw)
end

^ yaw is the player's yaw

How can I do this so that the shortest difference is used?

@GreenDimond:
Have you tried just using get_item and replace_model rather than node.get_item and node.replace_model?

I have a function advtrains.minAngleDiffRad in advtrains/helpers.lua. maybe this is helpful.
Returns how far to rotate from first angle in which direction to reach second angle
Link is in signature

[DS-minetest]

@GreenDimond: Try it like this:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

   get_item = function(pos, node, player)
      local inv = player:get_inventory()
      inv:add_item("main", "modname:nodename")
   end,
   replace_model = function(pos, node)
      minetest.set_node(pos, {name = "modname:othernodename", param2 = node.param2})
   end,

   on_punch = function(pos, node, player, pointed_thing)
      node.get_item(player)
      node.replace_model(pos, node)
   end
})

Perhaps it will work.
Btw where is this code? Is it in minetest.reister_node ?

[GreenDimond]

@D00Med: Yes, I believe I have tried that.

@DS-minetest: I tried your answer before orwells (just cuz it was a copy/past). I get this:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

2017-02-14 08:16:04: ERROR[Main]: ServerError: Lua: Runtime error from mod 'modname' in callback node_on_punch(): /home/alex/.minetest/mods/modname/nodes.lua:66: attempt to call field 'get_item' (a nil value)
2017-02-14 08:16:04: ERROR[Main]: stack traceback:
2017-02-14 08:16:04: ERROR[Main]:    /home/alex/.minetest/mods/modname/nodes.lua:66: in function </home/alex/.minetest/mods/modname/nodes.lua:65>

For reference, the first line of your code is line 57. Yes, this code is inside a register_node.

@orwell: :D :D :D It worked! So what I get from that, is whenever I want to combine 2 functions for one node, I must define the functions outside the register_node. Is this correct?

[orwell]

Everything inside {} is a table definition. Statements like key=value, declare a new table entry.
So, if you define replace_model inside the {}, they become a member of the definition table. You can't access values of a table from functions defined in that table unless you can reference the whole table object, which in your case would be the node definition (which is stored in minetest.registered_nodes).
In contrast, you can always call functions that are identified in the global or local namespace.
Answer to question: basically yes, but depends on the use case

[GreenDimond]

Ok :D
New question:
I am defining a tool that replaces a model, but when it does, the model has a fixed rotation. I want it to be the same rotation as the node the player is punching.
Code:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

   on_use = function(itemstack, user, pointed_thing)

      if pointed_thing.type ~= "node" then
         return
      end

      local pos = pointed_thing.under
      local pname = user:get_player_name()

      if minetest.is_protected(pos, pname) then
         minetest.record_protection_violation(pos, pname)
         return
      end

      local node = minetest.get_node(pos).name

      if node == "modename:node1" then

--         minetest.swap_node(pos, {name = "modename:node2"})
         minetest.set_node(pos, {name = "modename:node2", param2 = node.param2})

         return itemstack
      end

   end,

The commented out line was the original one, but I don't think I want to swap, so I used the set_node.
This code currently makes it so no matter which direction the original node is facing, the new node faces in a fixed direction (which I don't want). How do I make it the same orientation as the node the player replaced?

[orwell]

I guess you get an error "attempt to index a string"
Your local var "node" is misleading, since it's a node name and not a node table representation.

local node=minetest.get_node(pos)
If node.name=="whatever" then
mt.set_node(pos, {name="whatever", param2=node.param2})

Param2 is the value that stores the rotation of the node, you need to keep it when you set the new node.

[GreenDimond]

Is that not the code I currently have?
We could talk about this in IRC if you like (#minetest).

[orwell]

Is that not the code I currently have?
We could talk about this in IRC if you like (#minetest).

No not exactly. The .name went elsewhere. IRC not today.

[GreenDimond]

Is that not the code I currently have?
We could talk about this in IRC if you like (#minetest).

No not exactly. The .name went elsewhere. IRC not today.

I see...trying this.
EDIT: It works! Thanks!

[GreenDimond]

Functions hate me :(
I am trying to get a simple function to work, and it doesn't.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

   function() replace_donemodel(pos, node)
      minetest.set_node(pos, {name = "modname:nodename", param2 = node.param2})
   end,
   on_place = {
      minetest.after(2.0, replace_donemodel)}

This is inside a register_node.
I want the model to be replaced 2 seconds after it is placed (or set).
I have tried registering the function outside the register node aswell, but nothing works. What do?
EDIT: Fixed.

[sofar]

This code lets the game start and actually does something when I punch the node. My game crashes.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

   get_item = function (player)
--      function(pos, node, player, pointed_thing)
      local inv = player:get_inventory()
      inv:add_item("main", "modname:nodename")
   end,
   replace_model = function (pos, node)
--      function(pos, node, puncher, pointed_thing)
      minetest.set_node(pos, {name = "modname:othernodename", param2 = node.param2})
   end,

   on_punch = function (pos, node, player, pointed_thing)
      node.get_item(player)
      node.replace_model(pos, node)
   end
})

I think I am about 90% of the way there, but am now moving as fast as a brick. So wat do now?
error code:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

2017-02-13 21:02:12: ERROR[Main]: ServerError: Lua: Runtime error from mod 'modname' in callback node_on_punch(): /home/alex/.minetest/mods/modname/nodes.lua:68: attempt to call field 'get_item' (a nil value)
2017-02-13 21:02:12: ERROR[Main]: stack traceback:
2017-02-13 21:02:12: ERROR[Main]:    /home/alex/.minetest/mods/modname/nodes.lua:68: in function </home/alex/.minetest/mods/modname/nodes.lua:67>


In case you are wondering, I use "modname" and "nodename" and stuff to keep the mod a secret :P

get_item() is declared as a member of the node definition. `node` is not a `node definition`.

you probably want to do something like this instead:

local function my_mod_get_item(params...) ...
end

(entirely OUTSIDE the minetest.registered_node() call)

and then call *that* function from the on punch handler directly:

on_punch = my_mod_get_item,

[sofar]

Functions hate me :(
I am trying to get a simple function to work, and it doesn't.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

   function() replace_donemodel(pos, node)
      minetest.set_node(pos, {name = "modname:nodename", param2 = node.param2})
   end,
   on_place = {
      minetest.after(2.0, replace_donemodel)}

This is inside a register_node.
I want the model to be replaced 2 seconds after it is placed (or set).
I have tried registering the function outside the register node aswell, but nothing works. What do?
EDIT: Fixed.

tell us the fix - this way everyone learns from the mistake!

[rubenwardy]

Functions hate me :(
I am trying to get a simple function to work, and it doesn't.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

   function() replace_donemodel(pos, node)
      minetest.set_node(pos, {name = "modname:nodename", param2 = node.param2})
   end,
   on_place = {
      minetest.after(2.0, replace_donemodel)}

This is inside a register_node.
I want the model to be replaced 2 seconds after it is placed (or set).
I have tried registering the function outside the register node aswell, but nothing works. What do?
EDIT: Fixed.

This was the fix:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

-- in definition of node A

on_punch = function(pos, node, puncher, pointed_thing)
    minetest.set_node(pos, { name = "nodeBName", param2 = node.param2 })
    minetest.after(2, minetest.set_node, pos, { name = "nodeCName", param2 = node.param2 })
end,

Turns out they wanted a node to go from A -> B when punched, then to C a few seconds later.

Here is a corrected version of their original code (Although it's not the right fix)

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

local function replace_donemodel(pos, node)
    minetest.set_node(pos, {name = "waffles:wafflemaker_open_done", param2 = node.param2})
end

minetest.register_node("node:name", {
     after_place_node = function(pos, placer, itemstack, pointed_thing)
        local node = minetest.get_node(pos)
        minetest.after(2.0, replace_donemodel, pos, node)
    end
})