[Sounds] Support for ogg opus sould files?

[Hybrid Dog]

I don't know much about sound files, correct me if l'm wrong:

https://wiki.ubuntuusers.de/Opus

pros
— although same quality, smaller file size
— quality can be reduced further than in ogg vorbis → smaller file size
— maybe better file format for short sounds → smaller file size
— smaller file size → downloading sounds (part of Media) maybe faster

cons
— installing opus on old os may not work → envy, etc
— ogg vorbis maybe has hardware decoding support?

neutral
— ogg opus file names end with ".opus"
— ogg vorbis files support isn't dropped

[est31]

I think the best argument here would be that one doesn't need the codebooks. For the sound lengths minetest usually uses, they create quite a large part of the file that's right.

Other than that, idk, vorbis is fine I think. Adding opus would increase complexity, that's for sure.

[Calinou]

It's already requested: https://github.com/minetest/minetest/issues/2239

Vorbis is nice, but Opus is quite better for long sound files like music (and thus, space could be saved, or quality could be increased), and generally you can afford the higher CPU cost.

If encoding in 320 Kb/s Opus, you are getting very close to lossless quality. If encoding in 128 Kb/s Opus, you still get something pretty decent, with a low file size.

— ogg vorbis maybe has hardware decoding support?

There generally is no support for hardware-accelerated sounds in operating systems. For instance, Windows Vista and later dropped the ability to have accelerated sound output.

[Hybrid Dog]

There generally is no support for hardware-accelerated sounds in operating systems. For instance, Windows Vista and later dropped the ability to have accelerated sound output.

2015-11-29 12:46:23: INFO[Main]: Audio: Initializing...
2015-11-29 12:46:23: INFO[Main]: Audio: Vorbis extension NOT present
2015-11-29 12:46:23: INFO[Main]: Audio: Initialized: OpenAL 1.1 ALSOFT 1.14, using OpenAL Soft

What is Vorbis extension?

[Jay]

It is a extension for the OpenAL library. Minetest checks for the extension, but actually uses another library to decode Vorbis sounds. (The EXT_vorbis check might be a candidate for dead code removal)

[Hybrid Dog]

It is a extension for the OpenAL library. Minetest checks for the extension, but actually uses another library to decode Vorbis sounds. (The EXT_vorbis check might be a candidate for dead code removal)

thanks, would disabling the check slightly decrease lag?

[Jay]

No. The check runs at startup and the result is never acted on.

[est31]

Jay: want to do a PR to remove the check?

https://github.com/minetest/minetest/pulls

[Jay]

Jay: want to do a PR to remove the check?

https://github.com/minetest/minetest/pulls

https://github.com/minetest/minetest/pull/3410

[est31]

Nice, thanks.