FOSS gamedev and creative worlds

Hi,

I want to discuss about PR 2227. The PR seems interesting but i need end user opinion before merge.

Can you review https://github.com/minetest/minetest/pull/2227 ?

I let this discussion opened until 48 hours before merge, but if somes doesn't like, tell me

It's hardly a big change. Why do you need to consult the community?

… and why do you have working translations? :D

He's using gettext I guess. It also works for me (note that I also use the french translation).

On topic: What changes aside from the lighter colors ?

indriApollo wrote:He's using gettext I guess. It also works for me (note that I also use the french translation).

On topic: What changes aside from the lighter colors ?

None. It literally only changes the color of the list box and the color of the shade around the text box border.

indriApollo wrote:He's using gettext I guess. It also works for me (note that I also use the french translation).

Totally does not work for me with any translations. There a re threads in the main section of the forums, in the German sub-section and on Reddit and at least two issues on Github. No-one has a working solution and nowhere I could get a clear statement if it’s broken or if it’s just me. Some say it works, some say it does not work.

But as I learned translations are broken by concept and need to be rewritten completely

rubenwardy wrote:

indriApollo wrote:On topic: What changes aside from the lighter colors ?

None. It literally only changes the color of the list box and the color of the shade around the text box border.

Yeah, let’s stick on-topic here :) To be honest, I actually don’t care for the color change. Both tints look okay to me.

I am perfectly fine with the presented change.

Because many users are not on IRC or github, i would talk with users about this graphical change before merge. It seems good for me, but maybe community can talk with us because it's user experience, not only devel.

Commited

Small changes aren't worth talking about on forums. It's only a small color change.

If it was a menu redesign, then sure. Or if a tab changes, sure discuss with community.

It is import to involve the community, but I don't think many will notice this change.

I think it is just fine that devs are on the forums. Even if it is a small change.

Well, that pull was tiny.
It's not required to ask in the forum users for GUI changes like that one everytime.