Inventory interface (what would be nice for mods) ADD YOUR OPINION!

[sapier]

When trying to add or remove items/nodes from players inventory the current lua api doesn't provide a very conveniant way. This thread is meant to collect opinions of what would be best for mods so please add your comment!


Suggestion (names used are simplified to pronounce what the function is doing!):

inventory->has_items(<itemname>,<count>)
returning true if player has at least count items/nodes of type itemname, doesn't change (players) inventory

inventory->remove_items(<itemname>,<count>)
returns true on succes false otherwise. removes count elements of type itemname from (players) inventory

inventory_>add_items(<itemname>,<count>) --already present
adds count of itemname elements to (players) inventory

[xyz]

That, of course, could be implemented with lua, you don't need to touch any .cpp files.

[Jeija]

I would also need a nicer routine for my throwing/bow-and-arrow mod. In that mod I use a quite dirty way to do these things by scanning the inventory list for certain strings.

[sfan5]

+1

[sapier]

@xyz yes it can be implemented in lua but
either nearly every mod would require to implement it or
there would be some sort of generic tool collection like add_tools

but either way search and remove list operations would be implemented in lua which is a huge speed difference to c++ code.
at least I've been told so

[randomproof]

There needs to be a way to solve craft recipe conflicts. That is two or more mods using the same recipe to make different things. In a perfect world there would be a drop down to select the crafting target from the different possible choices.

[Hackeridze]

There needs to be a way to solve craft recipe conflicts. That is two or more mods using the same recipe to make different things. In a perfect world there would be a drop down to select the crafting target from the different possible choices.

+1

[kahrl]

inventory->has_items(<itemname>,<count>)
returning true if player has at least count items/nodes of type itemname, doesn't change (players) inventory

inventory->remove_items(<itemname>,<count>)
returns true on succes false otherwise. removes count elements of type itemname from (players) inventory

Just implemented those (with slightly different names and parameters). This is part of my huge inventory-related patchset, so I don't know when it is ready to be included, but hopefully very soon.

[randomproof]

inventory->has_items(<itemname>,<count>)
returning true if player has at least count items/nodes of type itemname, doesn't change (players) inventory

inventory->remove_items(<itemname>,<count>)
returns true on succes false otherwise. removes count elements of type itemname from (players) inventory

inventory_>add_items(<itemname>,<count>) --already present
adds count of itemname elements to (players) inventory

+1

[kahrl]

http://c55.me/minetest/wiki/doku.php?id=changes:itemdef:modders -> InvRef changes

[randomproof]

It would also be nice if you could add a button to craft the max amount of something. For example when crafting brick nodes I put 4 stacks of clay bricks 99 and I have to double-click 99 times to craft 99 brick nodes.

[redcrab]

It would also be nice if you could add a button to craft the max amount of something. For example when crafting brick nodes I put 4 stacks of clay bricks 99 and I have to double-click 99 times to craft 99 brick nodes.

+99

[Nemo08]

http://c55.me/minetest/wiki/doku.php?id=changes:itemdef:modders -> InvRef changes

Metadata still set to default when you put item in inventary?

[kahrl]

http://c55.me/minetest/wiki/doku.php?id=changes:itemdef:modders -> InvRef changes

Metadata still set to default when you put item in inventary?

What kind of metadata do you mean? If you mean node metadata, that is unrelated to item metadata.

[Nemo08]

http://c55.me/minetest/wiki/doku.php?id=changes:itemdef:modders -> InvRef changes

Metadata still set to default when you put item in inventary?

What kind of metadata do you mean? If you mean node metadata, that is unrelated to item metadata.

Item meta
I think we needed at least some sort of id for which we can uniquely identify an object or item. Item meta don't?

[sapier]

When attaching something like metadata to each individual item we have to consider that nodes may be in inventory too. Operations like "lookup_by_id" might take very long if you need to find a specific item within thousands of objects.

[Nemo08]

When attaching something like metadata to each individual item we have to consider that nodes may be in inventory too. Operations like "lookup_by_id" might take very long if you need to find a specific item within thousands of objects.

Maybe I'm wrong said, rather than a unique id, but the data that is constantly saved in item, wherever it was. As an example of implementation - the key to the lock and the lock. How we may can connect them to each other? Maybe some inner id, which is stored in the key and lock. And so on

[kahrl]

That is possible with item metadata, provided you find some way to generate a sufficiently unique ID.

If the player picks the key and lock up via item objects (created with minetest.add_item): Item objects can store item metadata.

If you give the key and lock to the player by calling player:get_inventory():add_item(...), just pass an item with metadata.

If key and lock are picked up as nodes, it's not possible, sadly.

Remember to set stack_max = 1, since item metadata belongs to a whole stack, not a single item in a stack.

[sapier]

the data that is constantly saved in item

Without a unique id, how do you want to ensure data is linked to specific object when you can't decide which of the thousands of objects (all beeing identical) is the object ot belongs to?

EDIT1:
entities support user defined variables, but by now they aren't preserved throughout server reboots. (there's a hacky way to save them by using staticdata but you need to serialize them manualy). Probably improvemts in this area might suite your needs

[Nemo08]

the data that is constantly saved in item

Without a unique id, how do you want to ensure data is linked to specific object when you can't decide which of the thousands of objects (all beeing identical) is the object ot belongs to?

EDIT1:
entities support user defined variables, but by now they aren't preserved throughout server reboots. (there's a hacky way to save them by using staticdata but you need to serialize them manualy). Probably improvemts in this area might suite your needs

Yes, this is problem, maybe in future we will have a way to show additional data as it is now tooltips to item, or can be a field of "additional description", or showing a further description, together with the name of the object. here we must think. Or change interface via lua for such things

[Nemo08]

"throughout server reboots" and then they stay inactive. And the entity to distinguish from the nodes, crafts player can not put to inventory.