Page 1 of 1

f11 for a fullscreen button

PostPosted: Mon Jul 21, 2014 20:40
by stormchaser3000
playing around with lxde's f11 fullscreen thing made me think... minetest should have an official fullscreen button that forces the program to exit the window desighn thing and then automaticly fiting to the size of the screen.

Re: f11 for a fullscreen button

PostPosted: Mon Jul 21, 2014 23:45
by philipbenr
I think that it used to be a feature... It was in 0.4.4 or around there... To find out, I'd have to go exploring in the 'unfathomable depths' of my home directory. ;)

Re: f11 for a fullscreen button

PostPosted: Tue Jul 22, 2014 12:34
by rubenwardy
It is harder than you think to change modes. I forget what it is called, but you need to implement a certain technology in the video drivers. AFAIK, anyway.

Re: f11 for a fullscreen button

PostPosted: Tue Jul 22, 2014 19:14
by hoodedice
rubenwardy wrote:It is harder than you think to change modes. I forget what it is called, but you need to implement a certain technology in the video drivers. AFAIK, anyway.


minetest.conf has a fullscreen variable.How hard is it to just implement it in at least the settings?

Re: f11 for a fullscreen button

PostPosted: Tue Jul 22, 2014 19:57
by webdesigner97
hoodedice wrote:
rubenwardy wrote:It is harder than you think to change modes. I forget what it is called, but you need to implement a certain technology in the video drivers. AFAIK, anyway.


minetest.conf has a fullscreen variable.How hard is it to just implement it in at least the settings?

I had a pull request for it, but it became a bit messy because it also had another feature in it which needed some discussion... It needs a cleanup and then maybe new and clean pull request.

Re: f11 for a fullscreen button

PostPosted: Tue Jul 22, 2014 21:20
by Evergreen
webdesigner97 wrote:
hoodedice wrote:
rubenwardy wrote:It is harder than you think to change modes. I forget what it is called, but you need to implement a certain technology in the video drivers. AFAIK, anyway.


minetest.conf has a fullscreen variable.How hard is it to just implement it in at least the settings?

I had a pull request for it, but it became a bit messy because it also had another feature in it which needed some discussion... It needs a cleanup and then maybe new and clean pull request.

I have the same kind of thing with a setting for screen height and width. It needs to be cleaned up. (of course, the option for height and width already existed, it just was in minetest.con)

Re: f11 for a fullscreen button

PostPosted: Tue Jul 22, 2014 22:57
by rubenwardy
You would need to close the window, and reopen it. This means that the entire 3d world would be deleted - you would have to create the cameras, meshes and scene again. Also, when you close the device there will still be variables pointing to it all other the code. This will cause segfaults. (Think pointers to icamerascenenode in the camera class.) So you would need to update all these.

The full screen settings work because the window is opened as full screen.