Page 1 of 1

Attachment broken in recent builds

PostPosted: Mon May 12, 2014 19:50
by stu
entity -> player attachment appears to no longer work in current-dev. I noticed this while making some updates to my wield3d mod, the wield entity seems to vanish when attached to a player.

Sorry I cant give the exact commit that broke it but I suspect may have something to do with the TPV changes, It was last known to be working fine at d753d352f15ac3586a80b42dd4da6aca518c8ec8

Re: Attachment broken in recent builds

PostPosted: Tue May 13, 2014 03:04
by Pavel_S
In my heli mod there was a trouble when player want to get in heli, and then teleported anyway, or heli dissapear.
I found that it was because of I use "set_attach(parent, "", position, rotation)" instead of "set_attach(parent, "Root", position, rotation)" (also work with any bone and frame).

Also armature looks rotated by engine or blender bug(but actually if it is rotated, player must look to another side ), mesh is OK.
Image

Re: Attachment broken in recent builds

PostPosted: Tue May 13, 2014 14:14
by BlockMen
I can hardly imagine that this is caused by third person view, since it only "overrides" the animation of players (related to this topic)
Since this commit https://github.com/minetest/minetest/co ... b039c620dd it just "overrides" the animation when player is not attached, but also there should be no influence on attachments.

Re: Attachment broken in recent builds

PostPosted: Tue May 13, 2014 17:36
by stu
BlockMen wrote:I can hardly imagine that this is caused by third person view, since it only "overrides" the animation of players (related to this topic)
Since this commit https://github.com/minetest/minetest/co ... b039c620dd it just "overrides" the animation when player is not attached, but also there should be no influence on attachments.

I have done some more testing and it turns out that the attachment is not broken after all, it just does not show up for some reason in third person view. Still works in multiplayer though, seems a bit inconsistent all the same.

Re: Attachment broken in recent builds

PostPosted: Tue May 13, 2014 18:11
by BlockMen
stu wrote:
BlockMen wrote:I can hardly imagine that this is caused by third person view, since it only "overrides" the animation of players (related to this topic)
Since this commit https://github.com/minetest/minetest/co ... b039c620dd it just "overrides" the animation when player is not attached, but also there should be no influence on attachments.

I have done some more testing and it turns out that the attachment is not broken after all, it just does not show up for some reason in third person view. Still works in multiplayer though, seems a bit inconsistent all the same.


Ah, right, since MT had no third person view all attachments of your player are hidden. Now that you mention it i remember sapier wants to fix it with pull #1269.

So well, you can call it "introduced by third person view" if you want, although it is just a missing feature for it ;)

Re: Attachment broken in recent builds

PostPosted: Tue May 13, 2014 19:07
by stu
BlockMen wrote:Ah, right, since MT had no third person view all attachments of your player are hidden. Now that you mention it i remember sapier wants to fix it with pull #1269.

So well, you can call it "introduced by third person view" if you want, although it is just a missing feature for it ;)

No problem, I just hope it is fixed before the next release, thanks.

Re: Attachment broken in recent builds

PostPosted: Tue May 13, 2014 19:38
by stu
Pavel_S wrote:Also armature looks rotated by engine or blender bug(but actually if it is rotated, player must look to another side ), mesh is OK.

This is known about and will probably never be fixed because some mods rely on this 'feature' [citation needed] ;-)
Either rotate your model prior to export or set the attachment rotation to compensate.

Re: Attachment broken in recent builds

PostPosted: Wed May 14, 2014 04:07
by Pavel_S
stu wrote:... set the attachment rotation to compensate.

I think it`s not fixed yet
viewtopic.php?p=133288#p133288