Current base64 implementation GPL incompatible

bahamada
Member
 
Posts: 13
Joined: Sun May 15, 2011 18:07

Current base64 implementation GPL incompatible

by bahamada » Sat Jun 25, 2011 16:41

Im quite not sure but I think as our current base64 implementation requires to not to alter the header

1. The origin of this source code must not be misrepresented; you must not
claim that you wrote the original source code. If you use this source code
in a product, an acknowledgment in the product documentation would be
appreciated but is not required.

2. Altered source versions must be plainly marked as such, and must not be
misrepresented as being the original source code.

3. This notice may not be removed or altered from any source distribution.


it seems to be GPL incompatible.

I replaced this implementation with the libbase64 which claims to be the fastes C++ implementation. I know I know that speed doesn't matter at this point at all but I wasn't so happy with the copyright issues mentioned above (our SHA-1 implementation have the same issue but thats another topic ;)).

You can find the new implementation (or call it linking whatever) in my master.

If there is interest in this replacement I will backport it.
 

spongie
Member
 
Posts: 19
Joined: Thu Jun 16, 2011 14:38

by spongie » Sat Jun 25, 2011 17:19

Hey nice work.

I've got some changes to the input system in http://bitbucket.org/spongie/minetest-spongie/changesets

It would be wise at this point to get some patches upstream before we diverge too much and backporting becomes difficult.
Both your base64 replacement and my input replacement should fit snugly now since they don't conflict with anything (as far as ive seen).
 

celeron55
Member
 
Posts: 430
Joined: Tue Apr 19, 2011 10:10

by celeron55 » Sun Jun 26, 2011 16:06

That license is a basic BSD-style license. Totally fine to me, I prefer BSD-style licenses in code taken from external sources.
 


Return to Minetest Engine

Who is online

Users browsing this forum: No registered users and 1 guest

cron