Pull Requests

Prestotron562
Member
 
Posts: 22
Joined: Mon Sep 02, 2013 22:37

Pull Requests

by Prestotron562 » Sun Sep 15, 2013 17:06

I have been working on some new features tha will be put in minetest_game/default. I just wanted to know if the Core Developers actually accept those pull requests. I have had mixed answers, so I need a real valid answer, preferably from a Core Dev.
 

User avatar
Inocudom
Member
 
Posts: 2889
Joined: Sat Sep 29, 2012 01:14
IRC: Inocudom
In-game: Inocudom

by Inocudom » Sun Sep 15, 2013 20:35

Would you tell the community what those features are?
 

Prestotron562
Member
 
Posts: 22
Joined: Mon Sep 02, 2013 22:37

by Prestotron562 » Sun Sep 15, 2013 21:02

New weapons, and new biomes.(built in snow biomes), and maybe mushroom biomes.
 

User avatar
jojoa1997
Member
 
Posts: 2890
Joined: Thu Dec 13, 2012 05:11

by jojoa1997 » Sun Sep 15, 2013 22:27

Well we are waiting for mapgen V7 and for the tools. And about the extra items in default game. Well it is in possible to get everyone to agree.( I don't care what is added as long as something good gets added.)
Coding;
1X coding
3X debugging
12X tweaking to be just right
 

User avatar
Inocudom
Member
 
Posts: 2889
Joined: Sat Sep 29, 2012 01:14
IRC: Inocudom
In-game: Inocudom

by Inocudom » Mon Sep 16, 2013 00:15

I look forward to the new biomes. Minetest needs more of them.
 

User avatar
sfan5
Member
 
Posts: 3636
Joined: Wed Aug 24, 2011 09:44
GitHub: sfan5
IRC: sfan5

by sfan5 » Mon Sep 16, 2013 06:11

Prestotron562 wrote:so I need a real valid answer, preferably from a Core Dev.

It isn't enough if just one coredev wants the pull request merged
Mods: Mesecons | WorldEdit | Nuke
Minetest builds for Windows (32-bit & 64-bit)
 

User avatar
rubenwardy
Member
 
Posts: 4500
Joined: Tue Jun 12, 2012 18:11
GitHub: rubenwardy
IRC: rubenwardy
In-game: rubenwardy

by rubenwardy » Mon Sep 16, 2013 08:02

sfan5 wrote:
Prestotron562 wrote:so I need a real valid answer, preferably from a Core Dev.

It isn't enough if just one coredev wants the pull request merged


Unless it is PilzAdam of course... shhh, he's coming!
 

User avatar
hoodedice
Member
 
Posts: 1372
Joined: Sat Jul 06, 2013 06:33

by hoodedice » Mon Sep 16, 2013 09:58

rubenwardy wrote:
sfan5 wrote:
Prestotron562 wrote:so I need a real valid answer, preferably from a Core Dev.

It isn't enough if just one coredev wants the pull request merged


Unless it is PilzAdam of course... shhh, he's coming!


Guns?

"Not voxel enough"

Biomes?

"Will cause massive drop in fps. Should be a less hacky way to do it."
Last edited by hoodedice on Mon Sep 16, 2013 09:59, edited 1 time in total.
7:42 PM - Bauglio: I think if you go to staples you could steal firmware from a fax machine that would run better than win10 does on any platform
7:42 PM - Bauglio: so fudge the stable build
7:43 PM - Bauglio: get the staple build
 

User avatar
PilzAdam
Member
 
Posts: 4026
Joined: Fri Jul 20, 2012 16:19
GitHub: PilzAdam
IRC: PilzAdam

by PilzAdam » Mon Sep 16, 2013 12:18

And here I am!

hoodedice wrote:Biomes?

"Will cause massive drop in fps. Should be a less hacky way to do it."

Biomes will be added if the API for them is finished in core.

Prestotron562 wrote:I have been working on some new features tha will be put in minetest_game/default. I just wanted to know if the Core Developers actually accept those pull requests. I have had mixed answers, so I need a real valid answer, preferably from a Core Dev.

It depends on the actual pull request. There is no general answer whether pull requests are merged or denied.
Just show us your code already.
 


Return to Minetest Engine

Who is online

Users browsing this forum: No registered users and 28 guests

cron