Page 1 of 1

Pull Requests

PostPosted: Sun Sep 15, 2013 17:06
by Prestotron562
I have been working on some new features tha will be put in minetest_game/default. I just wanted to know if the Core Developers actually accept those pull requests. I have had mixed answers, so I need a real valid answer, preferably from a Core Dev.

PostPosted: Sun Sep 15, 2013 20:35
by Inocudom
Would you tell the community what those features are?

PostPosted: Sun Sep 15, 2013 21:02
by Prestotron562
New weapons, and new biomes.(built in snow biomes), and maybe mushroom biomes.

PostPosted: Sun Sep 15, 2013 22:27
by jojoa1997
Well we are waiting for mapgen V7 and for the tools. And about the extra items in default game. Well it is in possible to get everyone to agree.( I don't care what is added as long as something good gets added.)

PostPosted: Mon Sep 16, 2013 00:15
by Inocudom
I look forward to the new biomes. Minetest needs more of them.

PostPosted: Mon Sep 16, 2013 06:11
by sfan5
Prestotron562 wrote:so I need a real valid answer, preferably from a Core Dev.

It isn't enough if just one coredev wants the pull request merged

PostPosted: Mon Sep 16, 2013 08:02
by rubenwardy
sfan5 wrote:
Prestotron562 wrote:so I need a real valid answer, preferably from a Core Dev.

It isn't enough if just one coredev wants the pull request merged


Unless it is PilzAdam of course... shhh, he's coming!

PostPosted: Mon Sep 16, 2013 09:58
by hoodedice
rubenwardy wrote:
sfan5 wrote:
Prestotron562 wrote:so I need a real valid answer, preferably from a Core Dev.

It isn't enough if just one coredev wants the pull request merged


Unless it is PilzAdam of course... shhh, he's coming!


Guns?

"Not voxel enough"

Biomes?

"Will cause massive drop in fps. Should be a less hacky way to do it."

PostPosted: Mon Sep 16, 2013 12:18
by PilzAdam
And here I am!

hoodedice wrote:Biomes?

"Will cause massive drop in fps. Should be a less hacky way to do it."

Biomes will be added if the API for them is finished in core.

Prestotron562 wrote:I have been working on some new features tha will be put in minetest_game/default. I just wanted to know if the Core Developers actually accept those pull requests. I have had mixed answers, so I need a real valid answer, preferably from a Core Dev.

It depends on the actual pull request. There is no general answer whether pull requests are merged or denied.
Just show us your code already.