[Mod] Map Fixer [mapfix]

[Gael de Sailly]

Hello !

This very simple mod can fix some map errors (light and flow problems) simply by typing "/mapfix <radius>". Radius is by default 40. Il you haven't the "server" privilege, you can't exceed 50.

It corrects most of light and flow bug.

Feel free to work on this project. The code is so short that I think it is simpler to copy the lines of the file directly on the forum, instead of making a fork and a pull request.

View on Github
Download

EDIT : there are now 3 settings, in minetest.conf :

• mapfix_default_size (by default 40) : size used when <size> is omitted
• mapfix_max_size (by default 50) : maximum size allowed for players
• mapfix_delay (by default 15) : minimal delay in seconds between 2 "/mapfix" (to avoid server freezing)

These limits can be exceeded by the admin only.

[Krock]

Nice, it works!

The dependencies are missing btw.

[Gael de Sailly]

No dependencies.

[Minetestforfun]

Thank you for this mod Gael, it's now activated in my server, i tried it and it works perfectly :)

[philipbenr]

Very nice and handy mod. Thanks Gael.

[Gael de Sailly]

Updated : rewritten.
There's now a limitation for players, to avoid server freeze.

Added minetest.conf settings.

[ExeterDad]

This mod is awesome.
Just say'n

[trev]

Thank you so much! My server was broken with pitch black areas. It was terrible. Fixed with a command. Nice!

[Gael de Sailly]

UPDATE: Timer problems fixed by using os.time(), and settings are now fully functional.

[Betamine]

It's great, thank you.

Is it possible to fix map around a region define by pos1 ?
I would like to fix a great region and it will be faster if i can excute the command in the chat window without "going" to the place to fix, something like this :
- //fixedpos set1 0 0 0
- //mapfix pos1
- //fixedpos set1 50 0 0
- //mapfix pos1
- //fixedpos set1 100 0 0
- //mapfix pos1
- etc ...

Thank you.

[Milan*]

Sadly doesnt help on all non-shadow lightbugs :(

[Fixerol]

I have suggestion for developing second version of this mod, for fixing on large scale:

I'm thinking about more enhanced version
Imagine you glitched lighting on your map again
now comes improved mapfix 2.0
it works differently
map divided into 50 x 50 x 50 chunks
it checks if players around
if player is in this chunk -> check if it was mapfixed -> do mapfix in that chunk -> write in some file to avoid mapfixing it later
this way you can gradually fix the map

[sorcerykid]

I'm curious why nobody has proposed merging this into the official minetest-game? It seems to be one of the most essential mods, particularly for a server.

[YuGiOhJCJ]

Awesome mod! It solved all my shadow problems on my Minetest server. Thank you.

[hajo]

I'm curious why nobody has proposed merging this into the official minetest-game?

This mod is still announced as WIP - 'Work-in-Progress'.

Are there any open issues that need fixing ?
Otherwise, request to move thread / announce as regular/finished mod.

[Gael de Sailly]

Some things should be changed (smaller radius by default) but yes, it's a very simple code, there is not a lot of issues to fix.
The code is somewhat hacky, in fact it gets a voxelmanip and immediately write it (after recalculating liquid flow) and while writing it, it automatically recalculate the light.
It could be implemented much more cleanly in the core. All needed functions already exist, so it would be a very small addition in terms of quantity of code.

[Sergey]

Error occured with automatic exit from gameplay when I typed /mapfix 1000

If this value considired too big, then your script must check it, warn about it, but not crash with errors and breaking the game.

[Gael de Sailly]

Error occured with automatic exit from gameplay when I typed /mapfix 1000

If this value considired too big, then your script must check it, warn about it, but not crash with errors and breaking the game.

Thank you :)
Done: I've limited the radius to 120 nodes, and changed the max radius for players without server privs to 24. I've noticed some weeks ago that a very large radius (>60?) can sometimes cause black chunks instead of solving them.

[Sergey]

I think maximum value should be mentioned in warning in order not to guess it.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

/mapfix 1000
Radius is too big

/mapfix 500
Radius is too big

/mapfix 250
Radius is too big

/mapfix 125
Radius is too big

/mapfix 62
Done

Now maximum radius can be determined only using bisection method.

Please, mention something like this

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

Radius is too big. Maximum radius allowed is <max_radius>.

In any software the more detailed output is the better.