[Mod] Firearms [0.2.0] [firearms]

[webdesigner97]

Wow! This is very cool!

[kaeza]

I do not know what I did wrong...
-snip-

You need latest git of Minetest. Use one of sfan5's, PilzAdam's, or BlockMen's builds if on Windows.

[Froggy]

After trying out this mod, I found a bug. When you shoot at slabs of any material, the game crashes.

debug.txt gives this:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

10:18:53: ACTION[ServerThread]: Froggy uses firearms:m4, pointing at [nothing]
10:18:56: ACTION[ServerThread]: Froggy uses firearms:m4, pointing at [nothing]
10:18:58: ACTION[ServerThread]: Froggy leaves game. List of players:
10:18:58: ERROR[main]: ServerError: LuaError: ...timus/.minetest/mods/firearms/firearmslib/bullet.lua:46: bad argument #1 to 'unpack' (table expected, got number)
10:18:58: ERROR[main]: stack traceback:
10:18:58: ERROR[main]:     [C]: in function 'unpack'
10:18:58: ERROR[main]:     ...timus/.minetest/mods/firearms/firearmslib/bullet.lua:46: in function 'find_collision_point'
10:18:58: ERROR[main]:     ...timus/.minetest/mods/firearms/firearmslib/bullet.lua:76: in function 'on_step'
10:18:58: ERROR[main]:     ...minetest/mods/firearms/firearmslib/pureluaentity.lua:45: in function '__do_step'
10:18:58: ERROR[main]:     ...minetest/mods/firearms/firearmslib/pureluaentity.lua:197: in function <...minetest/mods/firearms/firearmslib/pureluaentity.lua:194>


The same happens with every other gun, as well. Not only the m4.

Other stuff:
-Make the sniper rifle deal more damage. I had to give the sniper multiple pellets for it to be of any use. Before, it only did 2 hp damage.
-The sniper rifle also doesn't zoom when right clicked, it only reduces blacks out the surrounding view.
-Physical ammo is gone for some reason. I can't /give any, and just doing shift+left-click gives you ammo from nowhere.
-In the top post you say player damage is not implemented, but it is.

But, I've got to say, this is a very fun mod!

Edit: Testing done in 0.4.8 stable.

[kaeza]

After trying out this mod, I found a bug. When you shoot at slabs of any material, the game crashes.

debug.txt gives this:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

-- snip --


The same happens with every other gun, as well. Not only the m4.

Fixed, thanks for reporting. Re-download the mod.

Make the sniper rifle deal more damage. I had to give the sniper multiple pellets for it to be of any use. Before, it only did 2 hp damage.

I really need to implement proper damage calculation. Expect Something Soon™.

The sniper rifle also doesn't zoom when right clicked, it only reduces blacks out the surrounding view.

The sniper rifle only works in single player. Multiplayer is only supported with a suitably patched engine. If you know how to compile Minetest yourself (or can get somebody to do it for you), the patch is in `firearmslib/util/player_setfov.patch'.

Physical ammo is gone for some reason. I can't /give any, and just doing shift+left-click gives you ammo from nowhere.

This isn't implemented yet. Again, Expect Something Soon™.

In the top post you say player damage is not implemented, but it is.

I forgot to update the post :P It is now fixed.

But, I've got to say, this is a very fun mod!

Thank you :)

[Froggy]

I redownloaded the mod and discovered another (very) big issue.

The slabs issue seems to be fixed, but I've got a new problem. I made a new world to test out the sniper rifle, and found that the zoom feature worked very nicely on singleplayer. I left the game shortly after, but then had a thought. I wondered what would happen if I left the game while still zoomed with the sniper. I entered the test world, zoomed, and left while still in zoomed mode. After re-entering again, I found that my FOV was stuck in zoom mode, but without the blacked out surrounding. Right clicking yeilded nothing.

Then, I went into an older world of mine, and found that I was zoomed there too. I proceeded to go to my minetest.conf and make "fov = 72". Upon entering the world again, I found that the fov didn't change at all. Looking at my minetest.conf, I saw that it changed to "fov = 18". It keeps reseting no matter what.

I decided to disregard that for the moment and go back to my original world (where the slabs issue occurred). Trying to enter gave me an init.lua error from firearmslib. When I remove the firearms mod from the world and entered, I was still in zoomed mode there too.

About the init.lua error, debug.txt says this:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

21:40:26: ERROR[main]: ========== ERROR FROM LUA ===========
21:40:26: ERROR[main]: Failed to load and run script from
21:40:26: ERROR[main]: /home/optimus/.minetest/mods/firearms/firearmslib/init.lua:
21:40:26: ERROR[main]: ...minetest/mods/firearms/firearmslib/pureluaentity.lua:161: attempt to get length of local 't' (a nil value)
21:40:26: ERROR[main]: stack traceback:
21:40:26: ERROR[main]:     ...minetest/mods/firearms/firearmslib/pureluaentity.lua:161: in function 'load'
21:40:26: ERROR[main]:     ...minetest/mods/firearms/firearmslib/pureluaentity.lua:190: in main chunk
21:40:26: ERROR[main]:     [C]: in function 'dofile'
21:40:26: ERROR[main]:     ...optimus/.minetest/mods/firearms/firearmslib/init.lua:20: in main chunk
21:40:26: ERROR[main]: ======= END OF ERROR FROM LUA ========
21:40:26: ERROR[main]: Server: Failed to load and run /home/optimus/.minetest/mods/firearms/firearmslib/init.lua
21:40:26: ERROR[main]: ModError: Failed to load and run /home/optimus/.minetest/mods/firearms/firearmslib/init.lua


I hope this helps.

[LuxAtheris]

So what kind firearms are available?

[AMMOnym]

can u make that firearms compatible with simple mobs pls?

[kaeza]

I wondered what would happen if I left the game while still zoomed with the sniper. I entered the test world, zoomed, and left while still in zoomed mode. After re-entering again, I found that my FOV was stuck in zoom mode, but without the blacked out surrounding. Right clicking yeilded nothing.

Fixed, thanks for reporting. One caveat is if the server has an unexpected crash (as in, segmentation fault or something like that, not on Lua errors), the FOV may not be reset to the original value. Nothing can be done about this last issue, sorry.

Then, I went into an older world of mine, and found that I was zoomed there too. I proceeded to go to my minetest.conf and make "fov = 72". Upon entering the world again, I found that the fov didn't change at all. Looking at my minetest.conf, I saw that it changed to "fov = 18". It keeps reseting no matter what.

Be sure to edit `minetest.conf' while the game is *NOT* running; otherwise it overwrites the settings when you exit.

Trying to enter gave me an init.lua error from firearmslib. When I remove the firearms mod from the world and entered, I was still in zoomed mode there too.

About the init.lua error, debug.txt says this:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

-- snip --


Hmm... try removing the `ple.list' file from the world directory.

So what kind firearms are available?

See first post.

can u make that firearms compatible with simple mobs pls?

Soon™

[LuxAtheris]

In the inventory,I cant see any ammunitions.
Help please

[Froggy]

Then, I went into an older world of mine, and found that I was zoomed there too. I proceeded to go to my minetest.conf and make "fov = 72". Upon entering the world again, I found that the fov didn't change at all. Looking at my minetest.conf, I saw that it changed to "fov = 18". It keeps reseting no matter what.

Be sure to edit `minetest.conf' while the game is *NOT* running; otherwise it overwrites the settings when you exit.

I did, indeed, edit minetest.conf with minetest not running. When I start the game, it immediately changes the FOV to what it was before, and disregards minetest.conf. Even completely removing the mod changed nothing. That's why I found this to be such a big problem.

I tried again later to find that the sniper could zoom again. It zoomed even more, relative to the original zoom. I left while still zoomed to find that, when I re-entered, I was stuck in the even more zoomed mode! I checked minetest.conf, and it says "fov = 1.125"! But, I guess I was asking for it.

Trying to enter gave me an init.lua error from firearmslib. When I remove the firearms mod from the world and entered, I was still in zoomed mode there too.

About the init.lua error, debug.txt says this:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

-- snip --


Hmm... try removing the `ple.list' file from the world directory.

That did the trick! Thank you! :D

[kaeza]

Update!

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

Some additions.
- Add real ammo.
- Fix most weapons having wrong ammo name.
- Number of pellets is now a property of bullets rather than
  weapons.
- Add proper damage to players and objects.


Edit: Froggy, I cannot reproduce the zoom bug here, so I can't come up with a fix. Sorry.

[Froggy]

The zoom bug occurred with the older version of the mod. Just zoom in singleplayer, then leave while still zoomed, and you'll be stuck like that forever. That's all I did, and I have no idea how to fix it. D:

Edit: I just realized that when I did the first experiment with the zooming, and leaving while still being zoomed, an FOV entry was automatically made at the bottom of minetest.conf. I didn't notice this, and added my own "fov = 72" in the middle. The second FOV entry was overriding the first, and that's why I was stuck in zoomed mode! All is fixed now. Sorry about the trouble.

[whoandwoo]

PLEASE TELL ME HOW THE HELL I INSTALL THIS MOD BECAUSE IT WONT FREKIN WORK FOR ME!!!!

[kaeza]

PLEASE TELL ME HOW THE HELL I INSTALL THIS MOD BECAUSE IT WONT FREKIN WORK FOR ME!!!!

First, don't type in ALL CAPS; it's like shouting and is considered rude.
Next, I have no magical mind reading powers, so you will have to help me by telling me what error you are encountering. Please follow the steps on this topic, but paste the error here instead of creating another topic.

[whoandwoo]

YOUR MOD IS UNWORKABLE! T DOESNT FREKIN WORK NO MATTER WHAT I'VE DONE!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

[Pitriss]

whoandwoo: If you don't stop shouting and being rude, nobody will want to help you. It is not matter how much angry you will be. So calm down and post here atleast error message that you get.

[Froggy]

PLEASE TELL ME HOW THE HELL I INSTALL THIS MOD BECAUSE IT WONT FREKIN WORK FOR ME!!!!

Download the mod.
Unzip the file.
Rename the folder to "firearms".
Move the folder to your .../minetest/mods folder. Create it if necessary.
Create a new world (if necessary).
Highlight selected world and click the "Configure" button.
Highlight "firearms", and check off "enabled" at the upper portion of the menu.
Click "Save".
Click "Play".

Now, it should be enabled. Type "/mods" while in game and look if "firearms" is on the list. If so, then it works.

[Evergreen]

YOUR MOD IS UNWORKABLE! T DOESNT FREKIN WORK NO MATTER WHAT I'VE DONE!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Also, it doesn't matter if your 13. I know 13 year olds who know way more about computers than you do.

[Azuna]

Craft recipes for .45 pistol?? or atleast item string

[kaeza]

Craft recipes for .45 pistol?? or atleast item string

The itemstring is "firearms:m9", and the craft recipe is as follows:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

Steel Ingot | Steel Ingot | Steel Ingot
     -      |      -      |    Wood


Edit: For those who know about weapons, my apologies, as the Beretta M9 is 9mm, not .45 :P

[AlexF]

http://im.bilderkiste.org/5137682139802/bug.PNG

I'm using the 0.4.7 stable download and Minetest 0.4.7 stable.

I keep getting error messages
ERROR[main]: ServerError: LuaError: error running function 'on_step': ...est build\bin\..\mods\firearms\firearmslib/explosion.lua:39: attempt to index local 'bulletdef' (a nil value)

Please remove the firearms_destructive mod for now. I will look into it later.

Awsome mod! I think the problem is that line 44 of explosion.lua should be:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

obj:set_hp(obj:get_hp() - damage);

instead of:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

obj:set_hp(obj.entity:get_hp() - damage);

[Zaraki]

You forgot the crafts for bullets in the new version :/

[mcfan]

What do you push to zoom? And it crashes with the exploding weapons.

Nice mod though!

[JPRuehmann]

Hello
Fine mod especialy the Huds and the amunition Idea to make them dependent of the weapon.
But I have one tiny problem.
After loading the first shoot did not do anything.
And a Question.
Are you working on reenable the destroying Weapons of the old Version?
Thanks,
JPR

[cupofinsane]

No craft receipt for ammo?

[LemonLake]

Fixes sound 'bug' (untested but I'm 100% certain it'll work)

+ Spoiler

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all


--[[
  || action.lua
  || Useful actions for weapons.
  ||
  || Part of the Firearms Modpack for Minetest.
  || Copyright (C) 2013 Diego Martínez <kaeza>
  || See `LICENSE.txt' for details.
--]]

local random = math.random

--[[
  | shoot
  |
  | Shoots the current weapon, using the ammo for the currently
  | selected slot.
--]]
firearms.action.shoot = {
   description = "Shoot",
   func = function(player, player_info, weapon_info)
      local ammo_info
      if weapon_info then
         player_info.ammo = player_info.ammo_info or { }
         ammo_info = (player_info.ammo_info and
            player_info.ammo_info[player_info.current_weapon.name]
         )
      end
      -- No ammo left in magazine; must reload.
      if (not ammo_info) or (ammo_info.count == 0) then
         if weapon_info.sounds.empty then
            minetest.sound_play(weapon_info.sounds.empty)
         end
         return
      end
      if player_info.shoot_cooldown <= 0 then
         local player_pos = player:getpos()
         local player_dir = player:get_look_dir()
         if weapon_info.sounds.shoot then
            minetest.sound_play(weapon_info.sounds.shoot)
         end
         -- TODO: Calc this properly.
         local muzzle_pos = { x=player_pos.x, y=player_pos.y, z=player_pos.z, }
         local spread = weapon_info.spread or 10
         local yaw = player:get_look_yaw()
         ammo_info.count = ammo_info.count - 1
         muzzle_pos.y = muzzle_pos.y + 1.45
         muzzle_pos.x = muzzle_pos.x + (math.sin(yaw) / 2)
         muzzle_pos.z = muzzle_pos.z - (math.cos(yaw) / 2)
         if firearms.hud then
            firearms.hud.update_ammo_count(player,
              player_info,
              ammo_info.count
            )
         end
         player_info.shoot_cooldown = (weapon_info.shoot_cooldown or 1)
         player_pos.y = player_pos.y + 1.625
         local pellets = (ammo_info.item_def.firearms.pellets or 1)
         local damage = (ammo_info.item_def.firearms.damage or 0)
         local player_name = player:get_player_name()
         for n = 1, pellets do
            local bullet_dir = {
               x = player_dir.x + (random(-spread, spread) / 1000),
               y = player_dir.y + (random(-spread, spread) / 1000),
               z = player_dir.z + (random(-spread, spread) / 1000),
            }
            local ent = pureluaentity.add(player_pos, "firearms:bullet")
            ent.player = player
            ent.player_name = player_name
            ent.player_info = player_info
            ent.ammo_def = ammo_info.item_def
            ent.damage = damage / pellets
            ent.object:setvelocity({
               x = bullet_dir.x * 20,
               y = bullet_dir.y * 20,
               z = bullet_dir.z * 20,
            })
            local v = random(100, 150)
            local bullet_vel = {
               x = bullet_dir.x * v,
               y = bullet_dir.y * v,
               z = bullet_dir.z * v,
            }
            ent.life = (weapon_info.range or 10) / 20
            minetest.add_particle(
               muzzle_pos,         -- pos
               bullet_vel, -- velocity
               {x=0, y=0, z=0},    -- acceleration
               0.5,                -- expirationtime
               2,                  -- size
               false,              -- collisiondetection
               "firearms_bullet.png", -- texture
               player:get_player_name()
            )
         end
      end
   end,
}

--[[
  | reload
  |
  | Reloads the current weapon, using the ammo for the currently
  | selected slot.
--]]
firearms.action.reload = {
   description = "Reload",
   func = function(player, player_info, weapon_info)
      if weapon_info then
         local ammo_info = (player_info.ammo_info
                       and player_info.ammo_info[player_info.current_weapon.name])
         -- TODO: Add support for more than one slot.
         local clipsize = (weapon_info.slots
                           and weapon_info.slots[1]
                           and weapon_info.slots[1].clipsize)
         if not clipsize then
            firearms.warning(("clipsize not defined for %s; cannot reload"):format(
                              player_info.current_weapon.name
                            ))
            return
         end
         if not ammo_info then
            local item_def = firearms.ammo.registered[weapon_info.slots[1].ammo]
            if not item_def then
               firearms.warning(("bullet type %s is not registered"):format(
                  weapon_info.slots[1].ammo
               ))
               return
            end
            ammo_info = {
               count = 0,
               item_def = item_def,
            }
            player_info.ammo_info = player_info.ammo_info or { }
            player_info.ammo_info[player_info.current_weapon.name] = ammo_info
         end
         if ammo_info.count < clipsize then
            local inv = player:get_inventory()
            local count = firearms.count_items(inv, "main", ammo_info.item_def.name)
            if count > 0 then
               player_info.shoot_cooldown = weapon_info.reload_time or 3
               if weapon_info.sounds.reload then
                  minetest.sound_play(weapon_info.sounds.reload)
               end
               local needed = math.min(clipsize - ammo_info.count, count)
               player_info.ammo_info = player_info.ammo_info or { }
               player_info.ammo_info[player_info.current_weapon.name] =
                 player_info.ammo_info[player_info.current_weapon.name] or
                 ammo_info
               ammo_info.count = ammo_info.count + needed
               local stack = ItemStack({
                  name = ammo_info.item_def.name,
                  count = needed,
               })
               inv:remove_item("main", stack)
               if firearms.hud then
                  firearms.hud.update_ammo_count(player,
                    player_info,
                    ammo_info.count
                  )
               end
            end
         end
      end
   end,
}

function set_scope(player, player_info, weapon_info, flag)
   if weapon_info and flag then
      firearms.hud.set_player_overlay(player, weapon_info.hud.overlay)
      firearms.set_player_fov(player, weapon_info.zoomed_fov or -100)
   else
      firearms.set_player_fov(player, weapon_info and weapon_info.fov or -100)
      firearms.hud.set_player_overlay(player, nil)
   end
   player_info.zoomed = flag
end

--[[
  | toggle_scope
  |
  | Toggles on or off telescopic sights, and adjusts player
  | FOV accordingly (if supported).
--]]
firearms.action.toggle_scope = {
   description = "Toggle Scope",
   func = function(player, player_info, weapon_info)
      set_scope(player, player_info, weapon_info, not player_info.zoomed)
   end,
}

firearms.event.register("weapon_change", function(player, player_info, weapon_info)
   set_scope(player, player_info, weapon_info, false)
end)


[kaeza]

Update:

• Added LemonLake's patch to sound bugs.
• Added `enable_crafting' to enable/disable crafting of weapons. Useful if you want to use vending machines or other means for players to get guns.
• Removed outline from hands in wield textures.
• Fixed some bugs with HUD and added a nice background that shows ammo type.

[kaeza]

Yet another update. This time added recipes for the bullets. It supports the tnt mod (for gunpowder) or provides its own. Have fun :)

[stormchaser3000]

um

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

14:46:34: ERROR[main]: ServerError: ...er3000/.minetest/mods/firearms/firearmslib/explosion.lua:39: attempt to index local 'bulletdef' (a nil value)
14:46:34: ERROR[main]: stack traceback:
14:46:34: ERROR[main]:    ...er3000/.minetest/mods/firearms/firearmslib/explosion.lua:39: in function 'explosion'
14:46:34: ERROR[main]:    ...3000/.minetest/mods/firearms/firearmslib/firearmslib.lua:393: in function 'on_destroy'
14:46:34: ERROR[main]:    ...3000/.minetest/mods/firearms/firearmslib/firearmslib.lua:310: in function '_destroy'
14:46:34: ERROR[main]:    ...3000/.minetest/mods/firearms/firearmslib/firearmslib.lua:362: in function <...3000/.minetest/mods/firearms/firearmslib/firearmslib.lua:316>


[kaeza]

The old version is not supported anymore. Please update to the new version or get rid of the `firearms_destructive' mod.