[SOLVED] Some bugs with my workbench

[Esteban]

Hello, I wonder if anyone can help me fix some bugs I have with my workbench mod I have for my sub-game. The mod I am using is an edited version of darkrose's workbench mod (I know, it's pretty old).

I planned to use blockmen's version, but it was not compatible with the latest version of the armor mod, so I kept using darkrose's version instead since it didnt have dependencies on it. However, since the mod is old, it has some bugs, and I doubt I will get help from the creator...

If you know of a mod that adds a workbench apart of blockmen's I would really appreciate it. The only thing I would have to do is just change the craft recipe and close this thread. :)

If there are no other options,I would appreciate if someone could point out what causes the following problems:

A)Decreasing output: If I place the craft output in the crafting grid, it decreases the amount. Example, I place a wooden plank and I get 4 sticks. When I move the 4 sticks to the crafting grid, they are reduced to one stick.

B) Infinite output: Continuing the previous example, If I move that stick from the grid to the inventory, It does not remove the wooden planks. Thus, infinite sticks from a single wooden plank.

+ Visual representation

A quick doodle I made to show the problem

+ Edited Code from the mod

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

minetest.register_node("workbench:3x3", {
   description = "WorkBench",
   tile_images = {"workbench_3x3_top.png","workbench_3x3_bottom.png","workbench_3x3_side.png"},
   paramtype2 = "facedir",
   groups = {choppy=2,oddly_breakable_by_hand=1},
   legacy_facedir_simple = true,
   sounds = default.node_sound_wood_defaults(),
   on_construct = function(pos)
      local meta = minetest.env:get_meta(pos)
      meta:set_string("formspec",
         "size[8,9]"..
         "list[current_name;table;1,1;3,3;]"..
         "list[current_name;dst;6,2;1,1;]"..
         "list[current_player;main;0,5;8,4;]")
      meta:set_string("infotext", "3x3 WorkBench")
      local inv = meta:get_inventory()
      inv:set_size("table", 9)
      inv:set_size("dst", 1)
   end,
   can_dig = function(pos,player)
      local meta = minetest.env:get_meta(pos);
      local inv = meta:get_inventory()
      if inv:is_empty("table") and inv:is_empty("dst") then
         return true
      end
      return false
   end,
   allow_metadata_inventory_move = function(pos, from_list, from_index, to_list, to_index, count, player)
      if to_list == "dst" then
         return 0
      end
      return count
   end,
   allow_metadata_inventory_put = function(pos, listname, index, stack, player)
      if listname == "dst" then
         return 0
      end
      return stack:get_count()
   end,
   allow_metadata_inventory_take = function(pos, listname, index, stack, player)
      return stack:get_count()
   end,
   on_metadata_inventory_move = function(pos, from_list, from_index,
         to_list, to_index, count, player)
      minetest.node_metadata_inventory_move_allow_all(
            pos, from_list, from_index, to_list, to_index, count, player)
      if to_list == "table" or from_list == "table" then
         local meta = minetest.env:get_meta(pos)
         local inv = meta:get_inventory()
         local tablelist = inv:get_list("table")
         local crafted = nil

         if tablelist then
            crafted = minetest.get_craft_result({method = "normal", width = 3, items = tablelist})
         end

         if crafted then
            inv:set_stack("dst", 1, crafted.item)
         else
            inv:set_stack("dst", 1, nil)
         end
      end
   end,
   on_metadata_inventory_put = function(pos, listname, index, stack, player)
      if listname == "table" then
         local meta = minetest.env:get_meta(pos)
         local inv = meta:get_inventory()
         local tablelist = inv:get_list("table")
         local crafted = nil

         if tablelist then
            crafted = minetest.get_craft_result({method = "normal", width = 3, items = tablelist})
         end

         if crafted then
            inv:set_stack("dst", 1, crafted.item)
         else
            inv:set_stack("dst", 1, nil)
         end
      end
   end,
   on_metadata_inventory_take = function(pos, listname, index, count, player)
      if listname == "table" then
         local meta = minetest.env:get_meta(pos)
         local inv = meta:get_inventory()
         local tablelist = inv:get_list("table")
         local crafted = nil

         if tablelist then
            crafted = minetest.get_craft_result({method = "normal", width = 3, items = tablelist})
         end

         if crafted then
            inv:set_stack("dst", 1, crafted.item)
         else
            inv:set_stack("dst", 1, nil)
         end
      elseif listname == "dst" then
         local meta = minetest.env:get_meta(pos)
         local inv = meta:get_inventory()
         local tablelist = inv:get_list("table")
         local crafted = nil
         local table_dec = nil

         if tablelist then
            crafted,table_dec = minetest.get_craft_result({method = "normal", width = 3, items = tablelist})
         end

         if table_dec then
            inv:set_list("table", table_dec.items)
         else
            inv:set_list("table", nil)
         end

         local tablelist = inv:get_list("table")

         if tablelist then
            crafted,table_dec = minetest.get_craft_result({method = "normal", width = 3, items = tablelist})
         end

         if crafted then
            inv:set_stack("dst", 1, crafted.item)
         else
            inv:set_stack("dst", 1, nil)
         end
      end
      return post
   end,
})

minetest.register_node("workbench:4x4", {
   description = "4x4 WorkBench",
   tile_images = {"workbench_4x4_top.png","workbench_4x4_bottom.png","workbench_4x4_side.png"},
   paramtype2 = "facedir",
   groups = {choppy=2,oddly_breakable_by_hand=1},
   legacy_facedir_simple = true,
   sounds = default.node_sound_wood_defaults(),
   on_construct = function(pos)
      local meta = minetest.env:get_meta(pos)
      meta:set_string("formspec",
         "size[8,9]"..
         "list[current_name;table;1,0;4,4;]"..
         "list[current_name;dst;6,2;1,1;]"..
         "list[current_player;main;0,5;8,4;]")
      meta:set_string("infotext", "4x4 WorkBench")
      local inv = meta:get_inventory()
      inv:set_size("table", 16)
      inv:set_size("dst", 1)
   end,
   can_dig = function(pos,player)
      local meta = minetest.env:get_meta(pos);
      local inv = meta:get_inventory()
      if inv:is_empty("table") and inv:is_empty("dst") then
         return true
      end
      return false
   end,
   allow_metadata_inventory_move = function(pos, from_list, from_index, to_list, to_index, count, player)
      if to_list == "dst" then
         return 0
      end
      return count
   end,
   allow_metadata_inventory_put = function(pos, listname, index, stack, player)
      if listname == "dst" then
         return 0
      end
      return stack:get_count()
   end,
   allow_metadata_inventory_take = function(pos, listname, index, stack, player)
      return stack:get_count()
   end,
   on_metadata_inventory_move = function(pos, from_list, from_index,
         to_list, to_index, count, player)
      minetest.node_metadata_inventory_move_allow_all(
            pos, from_list, from_index, to_list, to_index, count, player)
      if to_list == "table" or from_list == "table" then
         local meta = minetest.env:get_meta(pos)
         local inv = meta:get_inventory()
         local tablelist = inv:get_list("table")
         local crafted = nil

         if tablelist then
            crafted = minetest.get_craft_result({method = "normal", width = 4, items = tablelist})
         end

         if crafted then
            inv:set_stack("dst", 1, crafted.item)
         else
            inv:set_stack("dst", 1, nil)
         end
      end
   end,
   on_metadata_inventory_put = function(pos, listname, index, stack, player)
      if listname == "table" then
         local meta = minetest.env:get_meta(pos)
         local inv = meta:get_inventory()
         local tablelist = inv:get_list("table")
         local crafted = nil

         if tablelist then
            crafted = minetest.get_craft_result({method = "normal", width = 4, items = tablelist})
         end

         if crafted then
            inv:set_stack("dst", 1, crafted.item)
         else
            inv:set_stack("dst", 1, nil)
         end
      end
   end,
   on_metadata_inventory_take = function(pos, listname, index, count, player)
      if listname == "table" then
         local meta = minetest.env:get_meta(pos)
         local inv = meta:get_inventory()
         local tablelist = inv:get_list("table")
         local crafted = nil

         if tablelist then
            crafted = minetest.get_craft_result({method = "normal", width = 4, items = tablelist})
         end

         if crafted then
            inv:set_stack("dst", 1, crafted.item)
         else
            inv:set_stack("dst", 1, nil)
         end
      elseif listname == "dst" then
         local meta = minetest.env:get_meta(pos)
         local inv = meta:get_inventory()
         local tablelist = inv:get_list("table")
         local crafted = nil
         local table_dec = nil

         if tablelist then
            crafted,table_dec = minetest.get_craft_result({method = "normal", width = 4, items = tablelist})
         end

         if table_dec then
            inv:set_list("table", table_dec.items)
         else
            inv:set_list("table", nil)
         end

         local tablelist = inv:get_list("table")

         if tablelist then
            crafted,table_dec = minetest.get_craft_result({method = "normal", width = 4, items = tablelist})
         end

         if crafted then
            inv:set_stack("dst", 1, crafted.item)
         else
            inv:set_stack("dst", 1, nil)
         end
      end
   end,
})

minetest.register_node("workbench:5x5", {
   description = "5x5 WorkBench",
   tile_images = {"workbench_5x5_top.png","workbench_5x5_bottom.png","workbench_5x5_side.png"},
   paramtype2 = "facedir",
   groups = {choppy=2,oddly_breakable_by_hand=1},
   legacy_facedir_simple = true,
   sounds = default.node_sound_wood_defaults(),
   on_construct = function(pos)
      local meta = minetest.env:get_meta(pos)
      meta:set_string("formspec",
         "size[8,10]"..
         "list[current_name;table;0,0;5,5;]"..
         "list[current_name;dst;6,2;1,1;]"..
         "list[current_player;main;0,6;8,4;]")
      meta:set_string("infotext", "5x5 WorkBench")
      local inv = meta:get_inventory()
      inv:set_size("table", 25)
      inv:set_size("dst", 1)
   end,
   can_dig = function(pos,player)
      local meta = minetest.env:get_meta(pos);
      local inv = meta:get_inventory()
      if inv:is_empty("table") and inv:is_empty("dst") then
         return true
      end
      return false
   end,
   allow_metadata_inventory_move = function(pos, from_list, from_index, to_list, to_index, count, player)
      if to_list == "dst" then
         return 0
      end
      return count
   end,
   allow_metadata_inventory_put = function(pos, listname, index, stack, player)
      if listname == "dst" then
         return 0
      end
      return stack:get_count()
   end,
   allow_metadata_inventory_take = function(pos, listname, index, stack, player)
      return stack:get_count()
   end,
   on_metadata_inventory_move = function(pos, from_list, from_index,
         to_list, to_index, count, player)
      minetest.node_metadata_inventory_move_allow_all(
            pos, from_list, from_index, to_list, to_index, count, player)
      if to_list == "table" or from_list == "table" then
         local meta = minetest.env:get_meta(pos)
         local inv = meta:get_inventory()
         local tablelist = inv:get_list("table")
         local crafted = nil

         if tablelist then
            crafted = minetest.get_craft_result({method = "normal", width = 5, items = tablelist})
         end

         if crafted then
            inv:set_stack("dst", 1, crafted.item)
         else
            inv:set_stack("dst", 1, nil)
         end
      end
   end,
   on_metadata_inventory_put = function(pos, listname, index, stack, player)
      if listname == "table" then
         local meta = minetest.env:get_meta(pos)
         local inv = meta:get_inventory()
         local tablelist = inv:get_list("table")
         local crafted = nil

         if tablelist then
            crafted = minetest.get_craft_result({method = "normal", width = 5, items = tablelist})
         end

         if crafted then
            inv:set_stack("dst", 1, crafted.item)
         else
            inv:set_stack("dst", 1, nil)
         end
      end
   end,
   on_metadata_inventory_take = function(pos, listname, index, count, player)
      if listname == "table" then
         local meta = minetest.env:get_meta(pos)
         local inv = meta:get_inventory()
         local tablelist = inv:get_list("table")
         local crafted = nil

         if tablelist then
            crafted = minetest.get_craft_result({method = "normal", width = 5, items = tablelist})
         end

         if crafted then
            inv:set_stack("dst", 1, crafted.item)
         else
            inv:set_stack("dst", 1, nil)
         end
      elseif listname == "dst" then
         local meta = minetest.env:get_meta(pos)
         local inv = meta:get_inventory()
         local tablelist = inv:get_list("table")
         local crafted = nil
         local table_dec = nil

         if tablelist then
            crafted,table_dec = minetest.get_craft_result({method = "normal", width = 5, items = tablelist})
         end

         if table_dec then
            inv:set_list("table", table_dec.items)
         else
            inv:set_list("table", nil)
         end

         local tablelist = inv:get_list("table")

         if tablelist then
            crafted,table_dec = minetest.get_craft_result({method = "normal", width = 5, items = tablelist})
         end

         if crafted then
            inv:set_stack("dst", 1, crafted.item)
         else
            inv:set_stack("dst", 1, nil)
         end
      end
   end,
})

minetest.register_craft({
   output = '"workbench:3x3"',
   recipe = {
      {'"group:tree"','"group:tree"'},
      {'"group:tree"','"group:tree"'},
   }
})

minetest.register_craft({
   output = '"workbench:4x4"',
   recipe = {
      {'"group:wood"','"group:wood"','"group:wood"'},
      {'"group:wood"','"group:wood"','"group:wood"'},
      {'"group:wood"','"group:wood"','"group:wood"'},
   }
})

minetest.register_craft({
   output = '"workbench:5x5"',
   recipe = {
      {'"group:wood"','"group:wood"','"group:wood"','"group:wood"'},
      {'"group:wood"','"group:wood"','"group:wood"','"group:wood"'},
      {'"group:wood"','"group:wood"','"group:wood"','"group:wood"'},
      {'"group:wood"','"group:wood"','"group:wood"','"group:wood"'},
   }
})


[Hybrid Dog]

l guess you need to make it remove the craft input when you take the output https://gist.github.com/HybridDog/d06d1 ... ch-lua-L98
what is post? https://gist.github.com/HybridDog/d06d1 ... h-lua-L127

[Esteban]

l guess you need to make it remove the craft input when you take the output https://gist.github.com/HybridDog/d06d1 ... ch-lua-L98

Thanks for pointing the problem out, but I changed the mod I was using. I found out that cornernote made an update to the code a long time ago, and so far it has no problems. I should've done a better search ...

what is post? https://gist.github.com/HybridDog/d06d1 ... h-lua-L127

I don't know, but it did appear a couple of times as an error in the log window of the game. Probably something I may have erased by accident.

Anyways, I appreciate your help , this tells more of how these weird formspec things work! :)

And for other peeps that want a crafting table/workbench, here is a copy for the updated code by cornernote:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

-- init.lua
--
-- workbench minetest mod, by darkrose
-- Copyright (C) Lisa Milne 2012 <lisa@ltmnet.com>
--
-- updated by cornernote
-- Copyright (C) Brett O'Donnell 2012 <cornernote@gmail.com>
--
-- This program is free software: you can redistribute it and/or modify
-- it under the terms of the GNU Lesser General Public License as
-- published by the Free Software Foundation, either version 2.1 of the
-- License, or (at your option) any later version.
--
-- This program is distributed in the hope that it will be useful, but
-- WITHOUT ANY WARRANTY; without even the implied warranty of
-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
-- Lesser General Public License for more details.
--
-- You should have received a copy of the GNU Lesser General Public
-- License along with this program.  If not, see
-- <http://www.gnu.org/licenses/>

-- expose api
workbench = {}

-- on_construct
workbench.on_construct = function(pos)
   local width = minetest.get_item_group(minetest.env:get_node(pos).name, "craft_width")
   local meta = minetest.env:get_meta(pos)
   local inv = meta:get_inventory()
   inv:set_size("craftresult", 1)
   inv:set_size("table", width*width)
   inv:set_width("craft", width)
   meta:set_string("formspec", "size[8,"..(width+4.5).."]"
      .."list[current_name;craftresult;6,2;1,1;]"
      .."list[current_player;main;0,"..(width+0.5)..";8,4;]"
      .."list[current_name;table;0,0;"..width..","..width..";]")
   meta:set_string("infotext", width.."x"..width.." WorkBench")
   meta:set_int("width", width)
end

-- can_dig
workbench.can_dig = function(pos,player)
   local meta = minetest.env:get_meta(pos);
   local inv = meta:get_inventory()
   if inv:is_empty("table") and inv:is_empty("craftresult") then
      return true
   end
   return false
end

-- allow_metadata_inventory_move
workbench.allow_metadata_inventory_move = function(pos, from_list, from_index, to_list, to_index, count, player)
   if to_list == "craftresult" then
      return 0
   end
   if to_list == "table" then
      workbench.update_inventory(pos, true, true)
   end
   return count
end

-- allow_metadata_inventory_put
workbench.allow_metadata_inventory_put = function(pos, listname, index, stack, player)
   if listname == "craftresult" then
      return 0
   end
   return stack:get_count()
end

-- allow_metadata_inventory_take
workbench.allow_metadata_inventory_take = function(pos, listname, index, stack, player)
   return stack:get_count()
end

-- on_metadata_inventory_move
workbench.on_metadata_inventory_move = function(pos, from_list, from_index, to_list, to_index, count, player)
   if to_list == "table" then
      workbench.update_inventory(pos)
   end
end

-- on_metadata_inventory_put
workbench.on_metadata_inventory_put = function(pos, listname, index, stack, player)
   if listname == "table" then
      workbench.update_inventory(pos)
   end
end

-- on_metadata_inventory_take
workbench.on_metadata_inventory_take = function(pos, listname, index, count, player)
   if listname == "table" then
      workbench.update_inventory(pos)
   elseif listname == "craftresult" then
      workbench.update_inventory(pos, true)
   end
end

-- update_inventory
workbench.update_inventory = function(pos,update_table,skip_update_craft)
   local meta = minetest.env:get_meta(pos)
   local inv = meta:get_inventory()
   local width = meta:get_int("width")
   local tablelist = inv:get_list("table")
   local crafted = nil
   local table_dec = nil

   -- update table
   if update_table then
      -- get craft result
      if tablelist then
         _, table_dec = minetest.get_craft_result({method = "normal", width = width, items = tablelist})
      end
      -- update table
      if table_dec then
         inv:set_list("table", table_dec.items)
      else
         inv:set_list("table", nil)
      end
      tablelist = table_dec.items
   end   

   -- update craft result
   if not skip_update_craft then
      -- get craft result
      if tablelist then
         crafted = minetest.get_craft_result({method = "normal", width = width, items = tablelist})
      end
      -- update craft result
      if crafted then
         inv:set_stack("craftresult", 1, crafted.item)
      else
         inv:set_stack("craftresult", 1, nil)
      end
   end
   
end

-- register
workbench.register = function(width, recipe)
   minetest.register_node("workbench:"..width.."x"..width, {
      description = "WorkBench "..width.."x"..width,
      tile_images = {"workbench_"..width.."x"..width.."_top.png","workbench_"..width.."x"..width.."_bottom.png","workbench_"..width.."x"..width.."_side.png"},
      paramtype2 = "facedir",
      groups = {cracky=2,craft_width=width},
      legacy_facedir_simple = true,
      sounds = default.node_sound_wood_defaults(),
      on_construct = workbench.on_construct,
      can_dig = workbench.can_dig,
      allow_metadata_inventory_move = workbench.allow_metadata_inventory_move,
      allow_metadata_inventory_put = workbench.allow_metadata_inventory_put,
      allow_metadata_inventory_take = workbench.allow_metadata_inventory_take,
      on_metadata_inventory_move = workbench.on_metadata_inventory_move,
      on_metadata_inventory_put = workbench.on_metadata_inventory_put,
      on_metadata_inventory_take = workbench.on_metadata_inventory_take,
   })
   minetest.register_craft({
      output = "workbench:"..width.."x"..width,
      recipe = recipe,
   })
end

-- register workbenches
workbench.register(3, {
   {"default:wood","default:wood"},
   {"default:wood","default:wood"},
})
workbench.register(4, {
   {"default:stone","default:stone","default:stone"},
   {"default:wood","default:wood","default:wood"},
   {"default:wood","default:wood","default:wood"},
})
workbench.register(5, {
   {"default:steel_ingot","default:steel_ingot","default:steel_ingot","default:steel_ingot"},
   {"default:wood","default:wood","default:wood","default:wood"},
   {"default:wood","default:wood","default:wood","default:wood"},
   {"default:wood","default:wood","default:wood","default:wood"},
})



[BrandonReese]

I know you solved your problem, but there is also a good workbench mod from MirceaKitsune. It's going to be faster than cornernote's workbench mob because this one uses your native crafting grid.

https://github.com/MirceaKitsune/minete ... _workbench

[Esteban]

I know you solved your problem, but there is also a good workbench mod from MirceaKitsune. It's going to be faster than cornernote's workbench mob because this one uses your native crafting grid.

https://github.com/MirceaKitsune/minete ... _workbench

Wow! Thanks for the suggestion! :D