[Mod] Formspex - Consistent Backgrounds [formspex]

[orwell]

This mod makes all formspecs automatically look like they look in minetest_game. No work on the side of other mods is required.

-specific background image and colors for forms
-player inventory hotbar is highlighted in a darker color.

Depends: default
License: WTFPL
There are no textures and sounds

Notes: formspecs set by set_inventory_formspec and set_creative_formspec remain unchanged (would be too difficult to implement). For many containers, it is required to re-place the node.
I won't continue development on this mod except if bugs are found.

Latest version:

formspex_1_2.zip

v. 1.2

(1.7 KiB) Downloaded 230 times

-fixed: forms already declaring a background element (e.g. signs_lib) looked weird
-fixed some other stuff I don't remember

Old versions:

formspex.zip

v. 1.1

(1.45 KiB) Downloaded 181 times

- Fix: meta:from_table() not working
- Fix: showed a warning "invalid use of background without a size[] element" when using short form of field[] in formspecs (won't modify these forms.)

formspex.zip

v. 1.0

(1.45 KiB) Downloaded 203 times

[4aiman]

A screenie? Pretty please?

[orwell]

screenshot showing a craft-guide form.
nothing in craft-guide's source was changed.

Without Formspex

fs_screenie_cg_no.png (225.39 KiB) Viewed 3447 times

With Formspex

screenshot_1848063.png (102.62 KiB) Viewed 3447 times

Highlighted Hotbar

fs_screenie_hotbardark.png (15.18 KiB) Viewed 3447 times

[4aiman]

A before/after image would be great :)
Anyways, judging by the code, this mod will add extra lag when opening inventories.

It is One Thing to concat strings while registering nodes (i.e. at a server startup) and The Other Thing to do that every time someone opens inventory. Aside from additional calculations this adds an extra delay - once the minetest.show_formspec is called the server will wait it to finish. The same goes to the get_meta replacement.



The idea of quickly changing formspecs IS great on it's own nevertheless.

To speed-up your code, try using a table.
Just populate it with the pieces of a formspec and then use table.concat.

Regards!

[Minetestforfun]

+1 for screens

[rubenwardy]

The name was confusing to me, maybe put: [Mod] Formspex [formspex] - Consistent backgrounds

It is One Thing to concat strings while registering nodes (i.e. at a server startup) and The Other Thing to do that every time someone opens inventory. Aside from additional calculations this adds an extra delay - once the minetest.show_formspec is called the server will wait it to finish. The same goes to the get_meta replacement.

I doubt that the delay will be noticeable. Even with 40 players there won't be more than 100 opens per second. Optimise in the right places, in the places that need it most. If this was C++ or a lower level language, then yes these optimisations would be good.

[orwell]

The name was confusing to me, maybe put: [Mod] Formspex [formspex] - Consistent backgrounds

Thanks. I changed the title.

It is One Thing to concat strings while registering nodes (i.e. at a server startup) and The Other Thing to do that every time someone opens inventory. Aside from additional calculations this adds an extra delay - once the minetest.show_formspec is called the server will wait it to finish. The same goes to the get_meta replacement.

To the show_formspec method: It is a function, and so it is unpredictable for my mod what it will return.
To the meta replacement: every time a mod sets the "formspec" meta tag, the style information is added. (not every time someone opens formspecs). Again, it is unpredictable what the tag will be set to.
So, nothing can be set on load time.

I doubt that the delay will be noticeable. Even with 40 players there won't be more than 100 opens per second. Optimise in the right places, in the places that need it most. If this was C++ or a lower level language, then yes these optimisations would be good.

This is Lua, and Lua is great!

[4aiman]

@orwell
You don't have to explain anything to me, since I can't remember suggesting to use concatenation only at load-time. :/
Actually, I can't really tell why you decided I've told you to do that...


Anyway, I'd like to cite the other part of my message (which was the reason to post it):

To speed-up your code, try using a table.
Just populate it with the pieces of a formspec and then use table.concat.

^ This is really important. Just try it and you'll see the difference.

[Minetestforfun]

Always no screens :(

EDIT : i see it, sorry and thank you :)

[4aiman]

See this post, Minetestforrun: viewtopic.php?f=9&t=12939&p=186824#p185813

[orwell]

@orwell
Anyway, I'd like to cite the other part of my message (which was the reason to post it):

To speed-up your code, try using a table.
Just populate it with the pieces of a formspec and then use table.concat.

^ This is really important. Just try it and you'll see the difference.

Sorry, now I understand what you mean with this part of your post. I've seen it in another mod.
I will think about it.

[amadin]

How change color for slots by using formspecx?

[orwell]

just enable both your mod and this one.

[amadin]

I mean change to not default color, for example to red.

[orwell]

I mean change to not default color, for example to red.

And I mean, just try to enable both your mod viewtopic.php?f=11&t=15640 and this one.
See what happens when you open e.g. a homedecor nightstand(it must have been placed after formspex was enabled)