Swap Node On Rightclick Problem

[octacian]

I'm trying to use minetest.swap_node to turn a computer on when it is rightclicked. First the computer is set to the bios version, then using minetest.after it is set to the fully on computer after 3.5 seconds. Full code is at the bottom of this post.

The first of my issues, is that on rightclick, I get this error in the chat and the node does not change, though the 3.5 second counter still attempts to run and fails.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

ERROR[Server]: Map::setNode(): Not allowing to place CONTENT_IGNORE while trying to replace "digiterm:basic" at (179,6,-51) (block (11,0,-4))

After 3.5 seconds, the game crashes with:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

2016-07-11 21:00:34: ERROR[Main]: ServerError: Runtime error from mod 'creative' in callback environment_Step(): ...local/share/minetest/games/testing/mods/digiterm/api.lua:21: attempt to index local 'pos' (a nil value)
2016-07-11 21:00:34: ERROR[Main]: stack traceback:
2016-07-11 21:00:34: ERROR[Main]:    ...local/share/minetest/games/testing/mods/digiterm/api.lua:21: in function 'func'
2016-07-11 21:00:34: ERROR[Main]:    /usr/local/share/minetest/builtin/game/misc.lua:34: in function </usr/local/share/minetest/builtin/game/misc.lua:11>
2016-07-11 21:00:34: ERROR[Main]:    /usr/local/share/minetest/builtin/game/register.lua:369: in function </usr/local/share/minetest/builtin/game/register.lua:349>

Swap node function:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

-- turn on (not functional)
function digiterm.system.on(pos, node)
  minetest.swap_node({x = pos.x, y = pos.y, z = pos.z}, {name = node.."_bios"}) -- set node to bios
  minetest.after(3.5, function(pos)
    minetest.swap_node({x = pos.x, y = pos.y, z = pos.z}, {name = node.."_on"}) -- set node to on after 5 seconds
  end)
end
-- turn off
function digiterm.system.off(pos, termstring)
  minetest.swap_node(pos, "digiterm:"..termstring.."_bios") -- set node to on
end
-- reboot
function digiterm.system.reboot(pos, termstring)
  digiterm.system.off(pos, termstring)
  digiterm.system.on(pos, termstring)
end

I tried manually entering the info, which worked, but cannot be relied upon when more nodes are added. I can do all this manually within the node register, though I think such a function is more effecient as I will also be using it later. However, though this did work, the node was placed facing the wrong direction. What can I do to fix this?

+ Full Code (API)

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

-- digiterm/api.lua

-- FORMSPECS
digiterm.formspec = {}
-- normal
function digiterm.formspec.normal(output, input)
  return 'size[10,11] textarea[.25,.25;10,10.5;output;;'..output..'] button[0,9.5;10,1;update;update] field[.25,10.75;9,1;input;;'..input..'] button[9,10.5;1,1;submit;submit]'
end
-- refresh
function digiterm.formspec.operating(startspace)
  return (startspace and ' ' or '')..digiterm.formspec.normal('${output}', '${input}');
end
-- /FORMSPECS

-- SYSTEM FUNCTIONS
digiterm.system = {}
-- turn on (not functional)
function digiterm.system.on(pos, node)
  minetest.swap_node({x = pos.x, y = pos.y, z = pos.z}, {name = node.."_bios"}) -- set node to bios
  minetest.after(3.5, function(pos)
    minetest.swap_node({x = pos.x, y = pos.y, z = pos.z}, {name = node.."_on"}) -- set node to on after 5 seconds
  end)
end
-- turn off
function digiterm.system.off(pos, termstring)
  minetest.swap_node(pos, "digiterm:"..termstring.."_bios") -- set node to on
end
-- reboot
function digiterm.system.reboot(pos, termstring)
  digiterm.system.off(pos, termstring)
  digiterm.system.on(pos, termstring)
end
-- /SYSTEM FUNCTIONS

function digiterm.register_terminal(termstring, desc)
  -- off
  minetest.register_node("digiterm:"..termstring, {
    description = desc.description,
    tiles = desc.off_tiles,
    paramtype2 = "facedir",
    groups = {cracky = 2},
    sounds = default.node_sound_stone_defaults(),
    digiline = {
      receptor = {},
      effector = {
        action = function(pos, node, channel, msg)
          local meta = minetest.get_meta(pos) -- get meta =
          -- if channel is correct, turn on
          if channel == meta:get_string("channel") then
            if msg.system == "on" then
              digiterm.system.on(pos)
            end
          end
        end
      },
    },
    on_rightclick = function(pos)
      digiterm.system.on(pos, termstring)
    end,
  })
  -- bios
  minetest.register_node("digiterm:"..termstring.."_bios", {
    description = desc.description,
    tiles = desc.bios_tiles,
    paramtype2 = "facedir",
     groups = {cracky = 2},
     sounds = default.node_sound_stone_defaults(),
  })
  -- on
  minetest.register_node("digiterm:"..termstring.."_on", {
    description = desc.description,
    tiles = desc.on_tiles,
    paramtype2 = "facedir",
     groups = {cracky = 2},
     sounds = default.node_sound_stone_defaults(),
    digiline = {
      receptor = {},
      effector = {
        action = function(pos, node, channel, msg)
          local meta = minetest.get_meta(pos) -- get meta
          if channel ~= meta:get_string("channel") then return end -- ignore if not proper channel
          if type(msg) ~= "table" then
            meta:set_string("output", meta:get_string("output")..msg) -- set output buffer meta
          elseif type(msg) == "table" then -- process tables
            if msg.display == "clear" then meta:set_string("output", "") end -- clear display
          end
        end
      },
    },
    on_construct = function(pos) -- set meta and formspec
      local meta = minetest.get_meta(pos) -- get meta
      meta:set_string("output", "") -- output buffer
      meta:set_string("input", "") -- input buffer
      meta:set_string("formspec", "field[channel;Set Channel:;${channel}]") -- channel specification formspec
    end,
    on_receive_fields = function(pos, formname, fields, sender) -- precess formdata
      local meta = minetest.get_meta(pos) -- get meta
      -- if channel received, set meta
      if fields.channel then
        meta:set_string("channel", fields.channel) -- set channel meta
        meta:set_string("formspec", digiterm.formspec.operating(true)) -- refresh formspec
        return
      end
      -- if submit, reset field print to output and send digiline
      if fields.submit then
        digiline:receptor_send(pos, digiline.rules.default, meta:get_string("channel"), fields.input) -- send digiline data
        meta:set_string("output", meta:get_string("channel").."@minetest:~$\n "..fields.input.."\n") -- repeat input
      else meta:set_string("input", fields.input) end -- else, do nothing
      -- refresh formspec
      meta:set_string("formspec", digiterm.formspec.operating(meta:get_string("formspec"):sub(0, 1) ~= " "))
    end,
  })
end

+ Node Register using API

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

-- digiterm/nodes.lua

digiterm.register_terminal("basic", {
   description = "Basic Digiterm",
   off_tiles = {
      "digiterm_side.png",
      "digiterm_side.png",
      "digiterm_side.png",
      "digiterm_side.png",
      "digiterm_side.png",
      "digiterm_front_off.png"
   },
   bios_tiles = {
      "digiterm_side.png",
      "digiterm_side.png",
      "digiterm_side.png",
      "digiterm_side.png",
      "digiterm_side.png",
      "digiterm_front_off.png^bios.png"
   },
   on_tiles = {
      "digiterm_side.png",
      "digiterm_side.png",
      "digiterm_side.png",
      "digiterm_side.png",
      "digiterm_side.png",
      "digiterm_front.png"
   }
})

[Krock]

Try this one:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

minetest.after(3.5, function(pos_)
   minetest.swap_node(pos_, {name = node.."_on"}) -- set node to on after 5 seconds
end, vector.new(pos))

When you define a function with a parameter in "minetest.after", you must also give the parameters to be sent.

[addi]

hmm in api you define the node as minetest.register_node("digiterm:"..termstring,
but in your on() function you want to swap the node {name = node.."_bios"}) . which fails, because that nodename is not registered. the probably correct function might be:

function digiterm.system.on(pos, node)
minetest.swap_node(pos, {name ="digiterm:".. node.."_bios"}) -- set node to bios
minetest.after(3.5, function(pos)
minetest.swap_node(pos, {name ="digiterm:".. node.."_on"}) -- set node to on after 5 seconds
end, pos)
end

[octacian]

Thanks! Putting both of your responses together fixed the problem. Now for my other problem. How do I use facedir (paramtype2) with swap node?