Remove "LARGE AMOUNT OF ITEMS!"

[jordan4ibanez]

Please remove this in line 1607 environment.cpp:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

    bool large_amount = (block->m_static_objects.m_stored.size() > 49);
    if(large_amount){
        errorstream<<"suspiciously large amount of objects detected: "
                <<block->m_static_objects.m_stored.size()<<" in "
                <<PP(block->getPos())
                <<"; removing all of them."<<std::endl;
        // Clear stored list
        block->m_static_objects.m_stored.clear();
        block->raiseModified(MOD_STATE_WRITE_NEEDED,
                "stored list cleared in activateObjects due to "
                "large amount of objects");
        return;
    }

Or at least raise the number to 500 or so so that mods that use entities don't have to constantly deal with this.

[0gb.us]

On my machine, having anywhere close to 49 objects in the same place causes severe lag. Removing the limit or setting it too high could cause problems.

If the limit must be removed or raised, what about having some sort of setting in minetest.conf? That way, weaker machines aren't taxed by the raise, but more powerful machines can do whatever they please.

Then again, that means weaker machines connecting to a world that allows massive amounts of objects could have issues .....

[PilzAdam]

Related pull request: https://github.com/celeron55/minetest/pull/163

[mauvebic]

Is quite annoying after firing just a few rounds lol couldn't the message be moved off the chat interface and into the logs?

[rarkenin]

Is quite annoying after firing just a few rounds lol couldn't the message be moved off the chat interface and into the logs?

This behavior shouldn't just be for this, but every recurribg server message. Maybe like:

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

Blahblahblah issue
blahblahblah issue
blahblahblah issue

blahblahblah happened 100 times

blahblahblah happened 100 times

blahblahblah happened 100 times



[4aiman]

+100