Patch to make add_entity return reference to created entity

sapier
Member
 
Posts: 763
Joined: Tue Aug 16, 2011 18:17

Patch to make add_entity return reference to created entity

by sapier » Mon Jan 02, 2012 02:02

DON'T mention coding style!
(c) sapier all rights reserved
 

User avatar
dannydark
Member
 
Posts: 428
Joined: Fri Aug 12, 2011 21:28

by dannydark » Mon Jan 02, 2012 05:00

I know you already linked this in IRC but It might be a good idea to link it on the patchsets page on the wiki, that way people who don't use the forum/IRC should be able to test any patches out plus I think celeron55 checks that page more often than the forum.

Also means the patch won't get buried / forgotten about.

I would probably also do the same for your other patches (like the texture caching).

http://c55.me/~celeron55/minetest/wiki/doku.php?id=patchsets
Last edited by dannydark on Mon Jan 02, 2012 05:01, edited 1 time in total.
 

sapier
Member
 
Posts: 763
Joined: Tue Aug 16, 2011 18:17

by sapier » Mon Jan 02, 2012 11:33

I do agree with what you say, but i've already created 3 accounts for minetest and don't have one for wiki by now ... I simply don't want to remember another password.

But feel free to link it.

As you probably might have read in irc texture caching is already on it's way beeing tested for master.
By now noone did even download the precompiled version i provided so I don't expect to many people to test the patch on it's own. Especialy as it breaks protocol compatibility with current minetest version.

EDIT1:
I've just noticed both patches (with slight modifications) are already in master so linking isn't necessary
Last edited by sapier on Mon Jan 02, 2012 11:45, edited 1 time in total.
DON'T mention coding style!
(c) sapier all rights reserved
 

User avatar
dannydark
Member
 
Posts: 428
Joined: Fri Aug 12, 2011 21:28

by dannydark » Mon Jan 02, 2012 12:10

Yep just added to the Patchsets page for you then saw your edit haha I removed now.

Also you can login to the wiki using openid ^_^ if that makes any difference.
 


Return to Minetest Engine

Who is online

Users browsing this forum: No registered users and 7 guests

cron