[Mod]closed_by_key-first GIT[closed_by_key][0.6]

[pandaro]

Closed by key v0.6 first GIT version
the most advanced system of chest and doors, but perhaps also the worst.

sourcecode:https://github.com/pandaro/closed_by_key
Code license: GPLv3;
Texture license: WTFPL;
Depends: default;
More info:readme.txt in mod;
Contributor:0gb.us,PilzAdam.

This mod add:
CHEST and DOOR closed by KEY, an EMPTY KEYRING for store keys in a FULL KEYRING.And a KEY-MANAGER to handle them

MAJOR CHANGE OF LATEST VERSION:(see full changelog in readme.txt)
closed_by_key_v0.6 -rename my mod, now called: "closed by key";
-open door and chest with rightclick;
-add disguised chest and door: very mimetic, but destructable;
-add mese chest and door: you can not destroy them;
-add on explode drop item if the chest is destructable;
-texture update a little bit;
-push code on GITHUB;
-minor change.



CRAFTING: full crafting guide in readme!!!!

O=empty slot
S=steel ingot
C=chest
D=dry shrub
M=Mese

-Steel chest: -Empty keyring: -Key-manager: -Steel door
SSS DOD M -SS
SOS ODO C -SS
SSS DOD -SS


How to:
CHEST:
-place the chest, you find the key in your inventory;
-If you remove the chest:Now is the same chest, maintains key
-if you lose the key: forget your chest!

DOOR:
-place the door, you find the key in your inventory;
-If you remove the door:Now is the same door, maintains key
-if you lose the key: forget your door!

KEY:
If the correct key is in your inventory or in the chest: you can open the chest.

KEYRING:
Merge multiple keys on a keyring.

KEY-MANAGER:
If a KEY is in the slot in the middle and at least one steel ingot in the KEY-MANAGER main menu:
press "copy" to copy the key(
If a EMPTY KEYRING is in the slot in the middle:
press "make" to merge all the keys of the key inventory-manager on a keychain;
If a FULL KEYRING is in the slot in the middle:
-press "unmake" to undo.
-press "copy" to copy all the keyring(you need 1 steel ingot for each key)


So: download and try it.
.zip

TO DO:
-maybe:key colour(maybe not);
-better crafting;
-much more.

[Likwid H-Craft]

I love this idea it, goes great of locked chest.

[pandaro]

try it and tell me if it works, I'm not sure...

[Likwid H-Craft]

I can't the file not a zip I only open zips since others, don't open, for me, that much.

[pandaro]

I can't the file not a zip I only open zips since others, don't open, for me, that much.

try now!

[Likwid H-Craft]

Testing.
Note this will be edit when done.

:( I am sorry to say, it can be open with out the need of keys.

[pandaro]

Testing.

:( I am sorry to say, it can be open with out the need of keys.

how? my problem was a crash!!
are you sure you can insert, move and remove items from the basket without the key?

[Topywo]

Seems to work just fine. Without the right keys in your inventory, you can't move stuff in and out the chest.

- The chest's back appears in front of the player (maybe a rearranging of the 'tiles'-line will solve this easily)

Warning: You can put the keys of the chest in the chest, but you can't get them out again.

2 things to think about (but maybe to hard to implement):
- It would be nice to see a difference between the keys
- Digging an empty chest and placing it back gives an extra key.

[pandaro]

thancks topywo for the feedback!

Seems to work just fine. Without the right keys in your inventory, you can't move stuff in and out the chest.

sometimes there is a crash if you place the key block as a block in the world;

- The chest's back appears in front of the player (maybe a rearranging of the 'tiles'-line will solve this easily)

I have to study better the definition of the blocks;

- It would be nice to see a difference between the keys

I think I can not do

Digging an empty chest and placing it back gives an extra key.

yes and the old key is useless

[4aiman]

WOOT!
Maybe if someone has placed his key in a chest and do not have another one for this chest, the chest should be available to everyone? I mean, how is it possible to lock a chest with a key if that key is in the chest you're trying to lock?
Maybe this chest should drop 3-5 keys? And if you do not want many of them, then you should be able to melt them in a furnace? Let's say to a ball of metal.
Then some NPC, the "KeyMaker", can be added to make keys from the metal balls if you give him the original key and some mese. (Just my thoughts)

[rarkenin]

I can't the file not a zip I only open zips since others, don't open, for me, that much.

Just install 7zip or something. It handles tarballs.

[pandaro]

WOOT!
Maybe if someone has placed his key in a chest and do not have another one for this chest, the chest should be available to everyone? I mean, how is it possible to lock a chest with a key if that key is in the chest you're trying to lock?
Maybe this chest should drop 3-5 keys? And if you do not want many of them, then you should be able to melt them in a furnace? Let's say to a ball of metal.
Then some NPC, the "KeyMaker", can be added to make keys from the metal balls if you give him the original key and some mese. (Just my thoughts)

I also think that if the key is in the chest should be open to all, I will try to implement it soon.

I do not think that the chest must provide two or more keys at once, however I think it should be possible to copy the key, so that more people can have the key to a chest and you can be sure that if you lose a key you have always another .

I like your idea of being able to have an NPC that can copy the key! +1 I had already done:
go here!

try it! now is not able to create or copy keys, but it would be simple change!

some have tried to place the key as a block??

thanks to you for the feedback

[jojoa1997]

if you put the key in the chest then it should become open to everyone. also you shpould be able to put stuff in the chests if you dont have a key. like the dropbox from morechests but you wont be able to see what is in there

[4aiman]

There are mail boxes to "be able to put but not be able to get".
Chests aren't supposed to give access to a person without a key.

[Likwid H-Craft]

I can't the file not a zip I only open zips since others, don't open, for me, that much.

Just install 7zip or something. It handles tarballs.

I don't like Zzip or others it crash my pc alot. that why I love zips it a free ware and, only maybe why I can open a rar or something other then a zip will, be online.

[rarkenin]

I can't the file not a zip I only open zips since others, don't open, for me, that much.

Just install 7zip or something. It handles tarballs.

I don't like Zzip or others it crash my pc alot. that why I love zips it a free ware and, only maybe why I can open a rar or something other then a zip will, be online.

7zip shouldn't be crashy... Are you sure you don't have some proprietary imitation?

[4aiman]

There is a thread with a "war" allready...
There are a lot of people who just affraid to install anything, not only 7zip. But they definetely NEED that experience of problems with some software.
Windows users never complained about installing VC++ redistributable on their OS. But there are many of them, who keep saying "I do not want to install needless otherwise software!" or "That thing which is not working for me is BAD. I wouldn't use that." instead of "Wow, and what this software can do else?" and "What am I doing wrong, that anyone else can run this software and I don't?".
Get real. You NEED 7zip. Consider that a requirement like VC++redist for almost ANY game. In fact, VC++redist is on almost EVERY disc with ANY game. And VC++ is installed in the "backgroung" mode, sometimes without even notifying user. Or if VC++ is a "bad" example, then think of different toolbars for IE, that comes with different soft.
If anyone have problems with 7zip then ASK FOR HELP instead of implying that some good stable software make your system crash. Post logs, error messages - anything. But DO NOT be so stubborn about "useless" or "crashy" software.

Minetest is way more unstable then 7zip. Yet we play it. Please, describe your problem with 7zip and I personally will help to overcome it. Anti-advertisment isn't a good thing to do in this case.

[Topywo]

some have tried to place the key as a block??

Just tried, both in creative and not in creative (as singleplayer). No crashes so far.

[Mito551]

+1
cool idea :)

[jojoa1997]

There is a thread with a "war" allready...
There are a lot of people who just affraid to install anything, not only 7zip. But they definetely NEED that experience of problems with some software.
Windows users never complained about installing VC++ redistributable on their OS. But there are many of them, who keep saying "I do not want to install needless otherwise software!" or "That thing which is not working for me is BAD. I wouldn't use that." instead of "Wow, and what this software can do else?" and "What am I doing wrong, that anyone else can run this software and I don't?".
Get real. You NEED 7zip. Consider that a requirement like VC++redist for almost ANY game. In fact, VC++redist is on almost EVERY disc with ANY game. And VC++ is installed in the "backgroung" mode, sometimes without even notifying user. Or if VC++ is a "bad" example, then think of different toolbars for IE, that comes with different soft.
If anyone have problems with 7zip then ASK FOR HELP instead of implying that some good stable software make your system crash. Post logs, error messages - anything. But DO NOT be so stubborn about "useless" or "crashy" software.

Minetest is way more unstable then 7zip. Yet we play it. Please, describe your problem with 7zip and I personally will help to overcome it. Anti-advertisment isn't a good thing to do in this case.

some of use can't install it. I barely got my unzipped paste my mom

[Sokomine]

Do the keys stack? Can something which carries individual data stack? Else your inventory might get filled soon. 1000 diffrent possible codes may seem much, but Minetest players are sometimes crazy :-) It is only a matter of time until there are collusions. Especially on a multiplayer server. Maybe it's more intresting for quests/adventure maps?

[4aiman]

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

some of use can't install it. I barely got my unzipped paste my mom

That's not an excuse. People should learn a lot of things while using such thing as PC or smartphone. I don't want to be offensive or rude. I'm terribly sorry if I offended you, but really... if anyone want to use a PC then they should learn some new "tricks". I taught my aunt (57 y.o.) how to install & use software under ubuntu (libre office, firefox, thunderbird, audacious, gnomebaker and many more). And that's provided she NEVER had used any kind of PC before.
After a month of "free flight" she asked me what the heck the "Windows" is. )))
So nothing is impossible. You need to put some time into "education", though.

Sokomine,
I believe that here sha1 or md5 or whatever hash would be sufficient. Or a guid. And if by some weird coincidence 2 keys would have identical hashes, then one should remember that even 2 different keys may unlock the same door in real life.

Keys shouldn't stack... maybe it would be nice to have some kind of a key holder?

pandaro, I always want to ask about that crafter... If I have all necessary materials to craft smth then why do I need to go to that guy?

[Mito551]

I taught my aunt (57 y.o.) how to install & use software under ubuntu (libre office, firefox, thunderbird, audacious, gnomebaker and many more). And that's provided she NEVER had used any kind of PC before.
After a month of "free flight" she asked me what the heck the "Windows" is. )))

oh wow.

[4aiman]

I taught my aunt (57 y.o.) how to install & use software under ubuntu (libre office, firefox, thunderbird, audacious, gnomebaker and many more). And that's provided she NEVER had used any kind of PC before.
After a month of "free flight" she asked me what the heck the "Windows" is. )))

oh wow.

After 2 months she asked me what the heck "linux" is ))
And only one more week later she asked about differences (hail to wikipedia, I guess?).

[pandaro]

4aiman wrote:

I believe that here sha1 or md5 or whatever hash would be sufficient. Or a guid. And if by some weird coincidence 2 keys would have identical hashes, then one should remember that even 2 different keys may unlock the same door in real life.

1 + for you!

Keys shouldn't stack... maybe it would be nice to have some kind of a key holder?

I never thought, I do not know if it's possible, I'll try.

pandaro, I always want to ask about that crafter... If I have all necessary materials to craft smth then why do I need to go to that guy?

It was an idea ... maybe you can not do chest closed without paying a crafter to do so, as you can not copy keys alone, but you must go to one of them.
Or you can do it all alone without crafter, the crafter at this point is just a quirk (whim).

sokomine wrote:

Do the keys stack? Can something which carries individual data stack? Else your inventory might get filled soon. 1000 diffrent possible codes may seem much, but Minetest players are sometimes crazy :-) It is only a matter of time until there are collusions. Especially on a multiplayer server. Maybe it's more intresting for quests/adventure maps?

I do not know how to save data from a stack and recovering the right keys at the right time.
I can try to make a key holder.

these are my answers at the moment.
I now have a question:

Can i show (in formspec or in other ways) a variable?
if yes: how?
this is necessary to know which key I'm watching (key 123, key 732, etc. ..)

I continue to thank you for the positive feedback.

[Bas080]

No need to type commands for who has acces to a chest, give someone your key or give a copy of it. Simple and practical.

- It would be nice to see a difference between the keys

I assume the keys have a ID for checking if they belong to eachother.

Your phone or window isn't wide enough to display the code box. If it's a phone, try rotating it to landscape mode.

Code: Select all

meta:set_string("infotext", "[Chess] " .. player .. " is owner")

With this code you can set what text should appear when looking at a node. For checking if the key belongs to a chest I assume you use a ID. Put the ID in the infotext and then when you point at key or chest you can see what the ID is.

[rarkenin]

What about making a separate keyring manager? You craft keyrings and they have UUIDs and a list of keys. You then fit 12 or so into one ring.

[0gb.us]

and thanks to 0gb.us for code base.

It's nice to know that code is being used for something. Once Minetest 0.4.5 is released, my implementation will be obsolete, but yours keeps the code alive.

[pandaro]

It's nice to know that code is being used for something. Once Minetest 0.4.5 is released, my implementation will be obsolete, but yours keeps the code alive.

I had an idea and tried to achieve it.
Our Mod can go together:

-I like cobble chest, I think that the chest can not dig if full but you can do with tnt explode;
so if the basket may be camouflaged is better.

-I like the chest wifi but I think the mod Mailcan be substituted in the chest wifi. So you can only move objects (and perhaps you also have to pay for it)

-Secret Chest:
"As long as you remember to click" close "before you leave the chest, no one can see what the chest contains. Only the chest's owner can click" open "and" close "on the chest's formspec, revealing and hiding the chest's contents . "
This should be implemented in closed_chest.

As you can see I think it's still much to be done.

We can add to close_chest more_chest
We can continue a project "together."
we can continue "alone".

Tell me what you think.

[pandaro]

closed_chest_v0.3:
-improved:place the chest, The KEY appears in the chest. Take it, and put it in your inventory.
-add:infotext
-add:EMPTY KEYRING
-add:FULL KEYRING
-add:KEY-MANAGER