Volumetric coloring of fog, based on sun / moon & horizon color

[Inocudom]

MirceaKitsune, this is a glorious day in the history of Minetest. I sincerely hope that the developers add this to the game, for they would be foolish not to. An open-source project that has no regard for greatness is a doomed open-source project. That is an infallible truth.

[MirceaKitsune]

PICS

It's a bit toooo sharp. But it looks good. The intensity of fog is way way way way way way way way too powerful.

Some screenshots were taken before the brightness adjustment. If you mean the saturation, that's intended. The purpose is to obtain beautiful environment colors, and if it doesn't do that the effect can be considered useless.

And here are some screenshots with a better draw distance... forgot to make those:

[MirceaKitsune]

Sorry for the image span. A lot of people suggested the fog is too strong and intensity should be decreased. I brought the blend value to half, and since it still looks beautiful I'm ok with it (but not any lower). I amended the commit on GIT so do another pull to get the change. Screenshots:

[EDIT] Amended the commit again, and made yellow fog a bit more orange (looks better).

[sfan5]

Win32 build of the github repo: http://sfan.sf.funpic.de/minetest-builds/c55/minetest-0.4.6-37ca885-betterfog-win32.7z

[MirceaKitsune]

Win32 build of the github repo: http://sfan.sf.funpic.de/minetest-builds/c55/minetest-0.4.6-37ca885-betterfog-win32.7z

Thanks :) You might want to re-make it though. I just amended the commit again right after you posted that (tweaked yellow fog color a bit).

[sfan5]

Something was wrong with the old one anyway...

[sfan5]

Here it is: http://sfan.sf.funpic.de/minetest-builds/c55/minetest-0.4.7-37ca885-betterfog-win32.7z

[Evergreen]

Sorry for the image span. A lot of people suggested the fog is too strong and intensity should be decreased. I brought the blend value to half, and since it still looks beautiful I'm ok with it (but not any lower). I amended the commit on GIT so do another pull to get the change. Screenshots:

[EDIT] Amended the commit again, and made yellow fog a bit more orange (looks better).

-snip-

Amazing work! It looks beautiful. :D

[fraang]

Nice work MirceaKitsune! I see forward to see your work upstream. :-)

[Topywo]

I'm quite fond of the current color set

I like the work you've done.

I preferred the first color set, but I guess it's allright you use a set that appeals to most people.

[MirceaKitsune]

Since there haven't been any major objections and I can't think of anything else to change, I created a pull request. If you want this feature, please support it and let the developers know! I already heard devs disagreeing with this for reasons as little as "fog doesn't match the cloud color" (although horizon and clouds don't need to match and it's barely even noticeable). I think it's good and really hope this won't be another case of code getting lost over admins needing little things (that are fine as) is to be changed right away.

[Inocudom]

Since there haven't been any major objections and I can't think of anything else to change, I created a pull request. If you want this feature, please support it and let the developers know! I already heard devs disagreeing with this for reasons as little as "fog doesn't match the cloud color" (although horizon and clouds don't need to match and it's barely even noticeable). I think it's good and really hope this won't be another case of code getting lost over admins needing little things (that are fine as) is to be changed right away.

I support the addition of this feature to Minetest. If there are any issues, the developers must work with you to solve them.

[MirceaKitsune]

Amended the commit again (pull request should be automatically updated). Made the effect last less, it was activated / deactivated way too early / late.

[paramat]

I'm happy to see the yellow haze has been dropped :) that was the only feature that didn't look right to me.
As the sun sets or rises the light ray colour goes from yellow through to deep red ... at the minetest dusk / dawn sequence the sun is already close to the horizon so the haze colour should start at yellowy-orange or even orange.

Also perhaps the clouds should be coloured too with the same light ray colour? This would happen IRL is it suitable for Minetest? If you try it i would love to see a screenshot.

Interestingly i prefer the intense colours of your first version, or perhaps even better something between that and your latest compromise. In reality sunrise / sunset is often an intense bright event, in Mineteset surely it should be just as intense perhaps even more abstract and intense as reality? Love the purple.

[paramat]

... perhaps also, if you want to follow real life physics, the sun colour could change at the horizon and that colour is used for tinting the haze and clouds. Then, everything is defined by the time/colour gradient of the sun, which perhaps could be stored as a texture.

EDIT However ... i already like it as it is, even if the sun and clouds don't match. I would love to have an intensity parameter or option too (so i can turn it up!).

[MirceaKitsune]

The reason I'm not coloring clouds is not that I don't want to, but because cloud colors are determined somewhere else and I don't know how to change them from Sky::Render and if to remove the old way entirely. Also, when the horizon is a deep purple tint (sun already set / didn't rise yet) that shouldn't change cloud colors, so I'd also need a filter to decide when.

I might consider it (no promises) if someone can explain which video::SColor I should change from Sky::Render for the clouds, and where to remove the existing cloud coloring which makes clouds orange at sunset / sunrise (this would override it). Note that like the horizon, all cloud's colors would then change based on where you are looking... so we should think twice if that would look acceptable or not also.

[MirceaKitsune]

Added a new commit which fixes several issues:

- By popular demand, clouds are also influenced by the directional colors.

- Don't blend sun and moon influences over a full rotation, only fade them between the "corners" of the sky. Fixes the red moon issue outlined by PilzAdam. Also removed view pitch from the calculation.

- Moved the code from Sky::render to Sky::update and properly apply the effect to colors rather than modifying them on the go.

[Thermal_Shock]

That's some beautiful work there.

I wouldn't think it, but does this affect performance at all. Gotta think of the poor souls on toasters after all.

[MirceaKitsune]

That's some beautiful work there.

I wouldn't think it, but does this affect performance at all. Gotta think of the poor souls on toasters after all.

It couldn't affect performance, unless Minetest is running on a hand watch. It doesn't add any extra render calls or costly functions, just further modifies sky colors each frame using simple maths (simple for the PC at least).

[paramat]

Ah that looks better now.
Although, with apologies for more criticism, the haze is still a little too yellow in the first screenshot, i would recommend starting the colour sequence at orange or yellowy-orange.
Concerning purple, we have purple clouds where i live, purple clouds after sunset could be visually stunning.

[sfan5]

Made a new Win32 build directly after I saw the new post, but I had to go.
Anyway, here it is: http://sfan.sf.funpic.de/minetest-builds/c55/minetest-0.4.7-fe4ce03-betterfog-win32.7z

[MirceaKitsune]

Ah that looks better now.
Although, with apologies for more criticism, the haze is still a little too yellow in the first screenshot, i would recommend starting the colour sequence at orange or yellowy-orange.
Concerning purple, we have purple clouds where i live, purple clouds after sunset could be visually stunning.

I played around with the color transition quite a bit. The current tint of orange is the best I could get. If I make it more red, it starts to look brown and washed out instead. As for the purple color, that's the part I love most as well... and it is indeed close to reality too.

[paramat]

Cool, yeah i can see from earlier screenshots that you have corrected the yellow and made it more orangey, it's probably just the recent screenshot with a close view distance making it look odd to my eyes.
Anyways awesome work, the last 2 screenshots in post 32 are absolutely stunning, very atmospheric. Hope to see your work merged.

[Dopium]

+1 for this feature enhancement to be added to the game as default.

Is there a simple way for me to add this effect to my client that im currently using or does it need to be added to the source code and compiled? Anyway looks great

[sfan5]

+1 for this feature enhancement to be added to the game as default.

Is there a simple way for me to add this effect to my client that im currently using or does it need to be added to the source code and compiled? Anyway looks great

If you use Windows you can use this:

Made a new Win32 build directly after I saw the new post, but I had to go.
Anyway, here it is: http://sfan.sf.funpic.de/minetest-builds/c55/minetest-0.4.7-fe4ce03-betterfog-win32.7z

[Dopium]

+1 for this feature enhancement to be added to the game as default.

Is there a simple way for me to add this effect to my client that im currently using or does it need to be added to the source code and compiled? Anyway looks great

If you use Windows you can use this:

Made a new Win32 build directly after I saw the new post, but I had to go.
Anyway, here it is: http://sfan.sf.funpic.de/minetest-builds/c55/minetest-0.4.7-fe4ce03-betterfog-win32.7z

Thanks, yeah i noticed your build and is when i discovered i got a strange bug with the water on later builds. Thats why i was asking if there is a way to implement this feature to an older 0.4.7 build that im using.

Thanks anyway

[sfan5]

+1 for this feature enhancement to be added to the game as default.

Is there a simple way for me to add this effect to my client that im currently using or does it need to be added to the source code and compiled? Anyway looks great

If you use Windows you can use this:

Made a new Win32 build directly after I saw the new post, but I had to go.
Anyway, here it is: http://sfan.sf.funpic.de/minetest-builds/c55/minetest-0.4.7-fe4ce03-betterfog-win32.7z

Thanks, yeah i noticed your build and is when i discovered i got a strange bug with the water on later builds. Thats why i was asking if there is a way to implement this feature to an older 0.4.7 build that im using.

Thanks anyway

You can't just "implement" something into a binary file that was produced while building.

[MirceaKitsune]

By popular suggestion, made sky color also be affected by the sun & moon blend, not just horizon. Also put the color mix into its own function.

[mauvebic]

By popular suggestion, made sky color also be affected by the sun & moon blend, not just horizon. Also put the color mix into its own function.

That looks better, much less 'boxy' than the first shots :-)

[paramat]

Looks good.